Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: rsvndump - Remote Subversion repository dumping tool
https://bugzilla.redhat.com/show_bug.cgi?id=575085
Summary: Review Request: rsvndump - Remote Subversion repository dumping tool Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: kalev@smartlink.ee QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora
Spec URL: http://kalev.fedorapeople.org/rsvndump.spec SRPM URL: http://kalev.fedorapeople.org/rsvndump-0.5.3-1.fc14.src.rpm Description: rsvndump is a command line tool that is able to dump a subversion repository that resides on a remote server. All data is dumped in the format that can be read/written by svnadmin, so the data produced by rsvndump can easily be imported into a new subversion repository.
Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=2062838
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=575085
Terje Røsten terjeros@phys.ntnu.no changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |terjeros@phys.ntnu.no
--- Comment #1 from Terje Røsten terjeros@phys.ntnu.no 2010-03-19 08:58:54 EDT --- Looks good, maybe add a Requires: subversion >= 1.4 (see README)?.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=575085
--- Comment #2 from Kalev Lember kalev@smartlink.ee 2010-03-19 10:01:59 EDT --- (In reply to comment #1)
Looks good, maybe add a Requires: subversion >= 1.4 (see README)?.
I don't think it's necessary. 1.4 is a rather old version of subversion, and it is present even in RHEL 5. All current Fedora versions have at least subversion 1.6.6, so we shouldn't really care (and add explicit requires) for anything older. There's even a Fedora guideline against explicit library requires (subversion is a library here): https://fedoraproject.org/wiki/Packaging/Guidelines#Explicit_Requires
However, F-11 ships with asciidoc-8.2.5, but needed is at least 8.4. I'm thinking of not building rsvndump for F-11 at all, as it will be EOL soon anyway. What do you think, should I add BuildRequires: asciidoc >= 1.4 to guard against users who might want to rebuild it themselves on F-11?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=575085
Terje Røsten terjeros@phys.ntnu.no changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@fedoraproject.org |terjeros@phys.ntnu.no Flag| |fedora-review?
--- Comment #3 from Terje Røsten terjeros@phys.ntnu.no 2010-03-20 16:40:02 EDT --- ok rpmlint ok naming ok spec ok license ok license tag ok perms, owns and dirs ok buildflags ok sha1sum 3704f8bf3dacace95b91d344b38c8026c0aa29fd rsvndump-0.5.3.tar.bz2 3704f8bf3dacace95b91d344b38c8026c0aa29fd rsvndump-0.5.3.tar.bz2.spec ok koji http://koji.fedoraproject.org/koji/taskinfo?taskID=2065270
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=575085
Terje Røsten terjeros@phys.ntnu.no changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
--- Comment #4 from Terje Røsten terjeros@phys.ntnu.no 2010-03-20 16:43:25 EDT --- No issues here:
The package rsvndump is APPROVED.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=575085
Kalev Lember kalev@smartlink.ee changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
--- Comment #5 from Kalev Lember kalev@smartlink.ee 2010-03-20 16:56:45 EDT --- Thanks for the review, Terje!
New Package CVS Request ======================= Package Name: rsvndump Short Description: Remote Subversion repository dumping tool Owners: kalev Branches: F-12 F-13 InitialCC:
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=575085
--- Comment #6 from Kevin Fenzi kevin@tummy.com 2010-03-23 23:28:55 EDT --- CVS done (by process-cvs-requests.py).
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=575085
--- Comment #7 from Fedora Update System updates@fedoraproject.org 2010-03-24 03:08:07 EDT --- rsvndump-0.5.3-1.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/rsvndump-0.5.3-1.fc12
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=575085
--- Comment #8 from Fedora Update System updates@fedoraproject.org 2010-03-24 03:08:12 EDT --- rsvndump-0.5.3-1.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/rsvndump-0.5.3-1.fc13
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=575085
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |ON_QA
--- Comment #9 from Fedora Update System updates@fedoraproject.org 2010-03-24 19:28:54 EDT --- rsvndump-0.5.3-1.fc12 has been pushed to the Fedora 12 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update rsvndump'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/rsvndump-0.5.3-1.fc12
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=575085
--- Comment #10 from Fedora Update System updates@fedoraproject.org 2010-03-24 19:34:56 EDT --- rsvndump-0.5.3-1.fc13 has been pushed to the Fedora 13 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update rsvndump'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/rsvndump-0.5.3-1.fc13
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=575085
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Fixed In Version| |rsvndump-0.5.3-1.fc12 Resolution| |ERRATA
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=575085
--- Comment #11 from Fedora Update System updates@fedoraproject.org 2010-03-29 22:26:55 EDT --- rsvndump-0.5.3-1.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=575085
--- Comment #12 from Fedora Update System updates@fedoraproject.org 2010-04-09 00:15:37 EDT --- rsvndump-0.5.3-1.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=575085
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|rsvndump-0.5.3-1.fc12 |rsvndump-0.5.3-1.fc13
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla