https://bugzilla.redhat.com/show_bug.cgi?id=1736027
Bug ID: 1736027 Summary: Review Request: perl-goto-file - Stop parsing the current file and move on to a different one Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: ppisar@redhat.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://ppisar.fedorapeople.org/perl-goto-file/perl-goto-file.spec SRPM URL: https://ppisar.fedorapeople.org/perl-goto-file/perl-goto-file-0.005-1.fc31.s... Description: It is rare, but there are times where you want to swap out the currently compiling file for a different one. This Perl module does that. From the point you use the module perl will be parsing the new file instead of the original.
Fedora Account System Username: ppisar
https://bugzilla.redhat.com/show_bug.cgi?id=1736027
Robert-André Mauchin zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST CC| |zebob.m@gmail.com Assignee|nobody@fedoraproject.org |zebob.m@gmail.com Flags| |fedora-review+
--- Comment #1 from Robert-André Mauchin zebob.m@gmail.com --- URL and Source addresses are Ok. Source archive (SHA-256: c6cdd5ee4a6cdcbdbf314d92a4f9985dbcdf9e4258048cae76125c052aa31f77) is original. Ok. Summary verified from lib/goto/file.pm. Ok. Description verified from lib/goto/file.pm. Ok. License verified from lib/goto/file.pm and README. Ok. No XS code, noarch BuildArch is Ok.
$ rpmlint perl-goto-file.spec review-perl-goto-file/results/perl-goto-file-0.005-1.fc31.noarch.rpm review-perl-goto-file/results/perl-goto-file-0.005-1.fc31.src.rpm 2 packages and 1 specfiles checked; 0 errors, 0 warnings.
$ rpm -q -lv -p perl-goto-file-0.005-1.fc31.noarch.rpm drwxr-xr-x 2 root root 0 Aug 1 22:50 /usr/share/doc/perl-goto-file -rw-r--r-- 1 root root 512 Oct 24 2017 /usr/share/doc/perl-goto-file/Changes -rw-r--r-- 1 root root 2585 Oct 24 2017 /usr/share/doc/perl-goto-file/README drwxr-xr-x 2 root root 0 Aug 1 22:50 /usr/share/licenses/perl-goto-file -rw-r--r-- 1 root root 18346 Oct 24 2017 /usr/share/licenses/perl-goto-file/LICENSE -rw-r--r-- 1 root root 2346 Aug 1 22:50 /usr/share/man/man3/goto::file.3pm.gz drwxr-xr-x 2 root root 0 Aug 1 22:50 /usr/share/perl5/vendor_perl/goto -rw-r--r-- 1 root root 4478 Oct 24 2017 /usr/share/perl5/vendor_perl/goto/file.pm File permissions and layout are Ok.
$ rpm -q --requires -p perl-goto-file-0.005-1.fc31.noarch.rpm | sort -f | uniq -c 1 perl(:MODULE_COMPAT_5.30.0) 1 perl(Filter::Util::Call) 1 perl(strict) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsZstd) <= 5.4.18-1 Binary requires are Ok.
$ rpm -q --provides -p perl-goto-file-0.005-1.fc31.noarch.rpm perl(goto::file) = 0.005 perl-goto-file = 0.005-1.fc31 Binary provides are Ok.
Package builds in Koji (https://koji.fedoraproject.org/koji/taskinfo?taskID=36741791). Ok
Resolution: Package approved.
https://bugzilla.redhat.com/show_bug.cgi?id=1736027
Petr Pisar ppisar@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1737051
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1737051 [Bug 1737051] Review Request: perl-Test2-Harness - Test2 Harness designed for the Test2 event system
https://bugzilla.redhat.com/show_bug.cgi?id=1736027
--- Comment #2 from Gwyn Ciesla gwync@protonmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-goto-file
https://bugzilla.redhat.com/show_bug.cgi?id=1736027
Petr Pisar ppisar@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |CLOSED Fixed In Version| |perl-goto-file-0.005-1.fc31 Resolution|--- |RAWHIDE Last Closed| |2019-08-02 13:49:20
--- Comment #3 from Petr Pisar ppisar@redhat.com --- Thank you for the review and the repository.
package-review@lists.fedoraproject.org