[Bug 823226] New: Review Request: sqlheavy - GObject wrapper for SQLite

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=823226

Bug ID: 823226
        QA Contact: [e-mail]
          Severity: medium
           Version: rawhide
          Priority: medium
                CC: [e-mail],
                    [e-mail]
          Assignee: [e-mail]
           Summary: Review Request: sqlheavy - GObject wrapper for SQLite
        Regression: ---
      Story Points: ---
    Classification: Fedora
                OS: Linux
          Reporter: [e-mail]
              Type: ---
     Documentation: ---
          Hardware: All
        Mount Type: ---
            Status: NEW
         Component: Package Review
           Product: Fedora

Spec URL: http://alvesadrian.fedorapeople.org/sqlheavy.spec
SRPM URL: http://alvesadrian.fedorapeople.org/sqlheavy-0.1.1-1.fc16.src.rpm
Description: SQLHeavy is a wrapper on top of SQLite with a GObject-based
interface
Fedora Account System Username: alvesadrian

[Bug 823226] Review Request: sqlheavy - GObject wrapper for SQLite

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=823226

Michael Scherer  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from Michael Scherer  ---
Hi,

a few comment on the spec  :
- you should have a -devel subpackage for developpement related files ( .h,
.pc, etc )
https://fedoraproject.org/wiki/Packaging:Guidelines#Devel_Packages

- I am not sure, but I think there was some discussion regarding the place of
vala files. However, that's not in the policy yet, so I would just suggest to
keep a eye on it

- the package do not compile on rawwhide ( it does on f17 however ). Not sure
why, but you can check with mock.

- the license tag is invalid 
https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#Valid_License_S...

- there is no ldconfig call in %post, and that's kinda required
https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Shared_libraries

[Bug 823226] Review Request: sqlheavy - GObject wrapper for SQLite

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=823226

--- Comment #2 from Adrian Alves  ---
(In reply to comment #1)
> Hi,
>
> a few comment on the spec  :
> you should have a -devel subpackage for developpement related files ( .h,
>
> .pc, etc )
> https://fedoraproject.org/wiki/Packaging:Guidelines#Devel_Packages
> I am not sure, but I think there was some discussion regarding the place
>
> of vala files. However, that's not in the policy yet, so I would just
> suggest to keep a eye on it
> the package do not compile on rawwhide ( it does on f17 however ). Not
>
> sure why, but you can check with mock.
> the license tag is invalid
>
> https://fedoraproject.org/wiki/Packaging:
> LicensingGuidelines#Valid_License_Short_Names
> there is no ldconfig call in %post, and that's kinda required
>
> https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Shared_libraries

I added sub-package devel but not sure if that is correct:
Spec URL: http://alvesadrian.fedorapeople.org/sqlheavy.spec
SRPM URL: http://alvesadrian.fedorapeople.org/sqlheavy-0.1.1-2.fc16.src.rpm

By the way fixed the license tag and added the ldconfig in post and postun

[Bug 823226] Review Request: sqlheavy - GObject wrapper for SQLite

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=823226

Thomas Moschny  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #3 from Thomas Moschny  ---
Your %files section needs a bit of rework. See
http://thm.fedorapeople.org/sqlheavy/sqlheavy.spec .

Also, rpmlint warns about mixed tabs and spaces, maybe you want to recheck that
and either use tabs or spaces for indention.

[Bug 823226] Review Request: sqlheavy - GObject wrapper for SQLite

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=823226

--- Comment #4 from Adrian Alves  ---
(In reply to comment #3)
> Your %files section needs a bit of rework. See
> http://thm.fedorapeople.org/sqlheavy/sqlheavy.spec .
>
> Also, rpmlint warns about mixed tabs and spaces, maybe you want to recheck
> that and either use tabs or spaces for indention.

Added ur modifications:
Spec URL: http://alvesadrian.fedorapeople.org/sqlheavy.spec
SRPM URL: http://alvesadrian.fedorapeople.org/sqlheavy-0.1.1-3.fc16.src.rpm

[Bug 823226] Review Request: sqlheavy - GObject wrapper for SQLite

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=823226

Jason Tibbitts  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
              Flags|                            |needinfo?([e-mail])

--- Comment #5 from Jason Tibbitts  ---
I am triaging old review tickets.  I can't promise a review if you reply, but
by closing out the stale tickets we can devote extra attention to the ones
which aren't stale.

This fails to build for me.  A scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=5403710

[Bug 823226] Review Request: sqlheavy - GObject wrapper for SQLite

https://bugzilla.redhat.com/show_bug.cgi?id=823226

Elliott Sales de Andrade  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |CLOSED
                 CC|                            |[e-mail]
             Blocks|                            |201449 (FE-DEADREVIEW)
         Resolution|---                         |NOTABUG
        Last Closed|                            |2017-10-04 23:39:59

--- Comment #6 from Elliott Sales de Andrade  ---
It doesn't seem like anyone replied.

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=201449
[Bug 201449] FE-DEADREVIEW -- Reviews stalled due to lack of submitter
response should be blocking this bug.