https://bugzilla.redhat.com/show_bug.cgi?id=1227446
Bug ID: 1227446 Summary: Review Request: eclipse-tm-terminal - Terminal plugin for Eclipse Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: akurtako@redhat.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://akurtakov.fedorapeople.org/eclipse-tm-terminal.spec SRPM URL: https://akurtakov.fedorapeople.org/eclipse-tm-terminal-4.0.0-0.1.git4ea71eb.... Description: An integrated Eclipse View for the local command prompt (console) or remote hosts (SSH, Telnet, Serial). Fedora Account System Username: akurtakov
https://bugzilla.redhat.com/show_bug.cgi?id=1227446
Mat Booth mat.booth@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |mat.booth@redhat.com Assignee|nobody@fedoraproject.org |mat.booth@redhat.com Flags| |fedora-review?
--- Comment #1 from Mat Booth mat.booth@redhat.com --- Taken
https://bugzilla.redhat.com/show_bug.cgi?id=1227446
--- Comment #2 from Mat Booth mat.booth@redhat.com --- Three extremely minor issues:
- Summary line must not end in a period, please remove it - Description line too long, please wrap at 80 characters See https://fedoraproject.org/wiki/Packaging:Guidelines#Summary_and_description - Group tag is no longer used these days and can be removed (unless you wish to support RHEL 5 ;-) See https://fedoraproject.org/wiki/Packaging:Guidelines#Group_tag
If you can address these, then this package is APPROVED
Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
===== MUST items =====
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [-]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [-]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. [x]: Packages must not store files under /srv, /opt or /usr/local
Java: [x]: Bundled jar/class files should be removed before build [x]: Packages have proper BuildRequires/Requires on jpackage-utils Note: Maven packages do not need to (Build)Require jpackage-utils. It is pulled in by maven-local
Maven: [-]: If package contains pom.xml files install it (including metadata) even when building with ant [x]: POM files have correct Maven mapping [x]: Maven packages should use new style packaging [x]: Old add_to_maven_depmap macro is not being used [x]: Packages DO NOT have Requires(post) and Requires(postun) on jpackage- utils for %update_maven_depmap macro [x]: Package DOES NOT use %update_maven_depmap in %post/%postun [x]: Packages use .mfiles file list instead of %{_datadir}/maven2/poms
===== SHOULD items =====
Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
Java: [x]: Package uses upstream build method (ant/maven/etc.) [x]: Packages are noarch unless they use JNI
===== EXTRA items =====
Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: eclipse-tm-terminal-4.0.0-0.1.git4ea71eb.fc23.noarch.rpm eclipse-tm-terminal-4.0.0-0.1.git4ea71eb.fc23.src.rpm eclipse-tm-terminal.noarch: W: summary-ended-with-dot C Terminal plugin for Eclipse. eclipse-tm-terminal.noarch: E: description-line-too-long C An integrated Eclipse View for the local command prompt (console) or remote hosts (SSH, Telnet, Serial). eclipse-tm-terminal.noarch: W: no-documentation eclipse-tm-terminal.src: W: summary-ended-with-dot C Terminal plugin for Eclipse. eclipse-tm-terminal.src: E: description-line-too-long C An integrated Eclipse View for the local command prompt (console) or remote hosts (SSH, Telnet, Serial). 2 packages and 0 specfiles checked; 2 errors, 3 warnings.
Rpmlint (installed packages) ---------------------------- eclipse-tm-terminal.noarch: W: summary-ended-with-dot C Terminal plugin for Eclipse. eclipse-tm-terminal.noarch: E: description-line-too-long C An integrated Eclipse View for the local command prompt (console) or remote hosts (SSH, Telnet, Serial). eclipse-tm-terminal.noarch: W: no-documentation 1 packages and 0 specfiles checked; 1 errors, 2 warnings.
Requires -------- eclipse-tm-terminal (rpmlib, GLIBC filtered): java-headless jpackage-utils osgi(org.eclipse.cdt.core) osgi(org.eclipse.cdt.core.linux) osgi(org.eclipse.cdt.core.linux.x86_64) osgi(org.eclipse.cdt.core.native) osgi(org.eclipse.remote.core) osgi(org.eclipse.remote.ui) osgi(org.eclipse.rse.core) osgi(org.eclipse.rse.subsystems.files.core) osgi(org.eclipse.rse.ui)
Provides -------- eclipse-tm-terminal: eclipse-tm-terminal mvn(org.eclipse.tm.terminal:org.eclipse.tm.terminal.connector.local)
mvn(org.eclipse.tm.terminal:org.eclipse.tm.terminal.connector.local.feature)
mvn(org.eclipse.tm.terminal:org.eclipse.tm.terminal.connector.local.sdk.feature) mvn(org.eclipse.tm.terminal:org.eclipse.tm.terminal.connector.process) mvn(org.eclipse.tm.terminal:org.eclipse.tm.terminal.connector.remote)
mvn(org.eclipse.tm.terminal:org.eclipse.tm.terminal.connector.remote.feature)
mvn(org.eclipse.tm.terminal:org.eclipse.tm.terminal.connector.remote.sdk.feature) mvn(org.eclipse.tm.terminal:org.eclipse.tm.terminal.connector.ssh) mvn(org.eclipse.tm.terminal:org.eclipse.tm.terminal.connector.ssh.feature)
mvn(org.eclipse.tm.terminal:org.eclipse.tm.terminal.connector.ssh.sdk.feature) mvn(org.eclipse.tm.terminal:org.eclipse.tm.terminal.connector.telnet)
mvn(org.eclipse.tm.terminal:org.eclipse.tm.terminal.connector.telnet.feature)
mvn(org.eclipse.tm.terminal:org.eclipse.tm.terminal.connector.telnet.sdk.feature) mvn(org.eclipse.tm.terminal:org.eclipse.tm.terminal.control) mvn(org.eclipse.tm.terminal:org.eclipse.tm.terminal.control.feature) mvn(org.eclipse.tm.terminal:org.eclipse.tm.terminal.control.sdk.feature) mvn(org.eclipse.tm.terminal:org.eclipse.tm.terminal.feature) mvn(org.eclipse.tm.terminal:org.eclipse.tm.terminal.sdk.feature) mvn(org.eclipse.tm.terminal:org.eclipse.tm.terminal.view.core) mvn(org.eclipse.tm.terminal:org.eclipse.tm.terminal.view.feature) mvn(org.eclipse.tm.terminal:org.eclipse.tm.terminal.view.rse.feature) mvn(org.eclipse.tm.terminal:org.eclipse.tm.terminal.view.rse.sdk.feature) mvn(org.eclipse.tm.terminal:org.eclipse.tm.terminal.view.sdk.feature) mvn(org.eclipse.tm.terminal:org.eclipse.tm.terminal.view.ui) mvn(org.eclipse.tm.terminal:org.eclipse.tm.terminal.view.ui.rse) mvn(org.eclipse.tm.terminal:terminal-parent:pom:) osgi(org.eclipse.tm.terminal.connector.local) osgi(org.eclipse.tm.terminal.connector.local.feature) osgi(org.eclipse.tm.terminal.connector.local.sdk.feature) osgi(org.eclipse.tm.terminal.connector.process) osgi(org.eclipse.tm.terminal.connector.remote) osgi(org.eclipse.tm.terminal.connector.remote.feature) osgi(org.eclipse.tm.terminal.connector.remote.sdk.feature) osgi(org.eclipse.tm.terminal.connector.ssh) osgi(org.eclipse.tm.terminal.connector.ssh.feature) osgi(org.eclipse.tm.terminal.connector.ssh.sdk.feature) osgi(org.eclipse.tm.terminal.connector.telnet) osgi(org.eclipse.tm.terminal.connector.telnet.feature) osgi(org.eclipse.tm.terminal.connector.telnet.sdk.feature) osgi(org.eclipse.tm.terminal.control) osgi(org.eclipse.tm.terminal.control.feature) osgi(org.eclipse.tm.terminal.control.sdk.feature) osgi(org.eclipse.tm.terminal.feature) osgi(org.eclipse.tm.terminal.sdk.feature) osgi(org.eclipse.tm.terminal.view.core) osgi(org.eclipse.tm.terminal.view.feature) osgi(org.eclipse.tm.terminal.view.rse.feature) osgi(org.eclipse.tm.terminal.view.rse.sdk.feature) osgi(org.eclipse.tm.terminal.view.sdk.feature) osgi(org.eclipse.tm.terminal.view.ui) osgi(org.eclipse.tm.terminal.view.ui.rse)
Source checksums ---------------- http://git.eclipse.org/c/tm/org.eclipse.tm.terminal.git/snapshot/org.eclipse... : CHECKSUM(SHA256) this package : 4ea0155f3ecb50a6f12f4640af12012486f17da18c38a056ce1fd5b0029be553 CHECKSUM(SHA256) upstream package : 4ea0155f3ecb50a6f12f4640af12012486f17da18c38a056ce1fd5b0029be553
Generated by fedora-review 0.5.3 (bcf15e3) last change: 2015-05-04 Command line :/usr/bin/fedora-review -b 1227446 -P Java:on --mock-config fedora-rawhide-x86_64 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, Java Disabled plugins: C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
https://bugzilla.redhat.com/show_bug.cgi?id=1227446
Mat Booth mat.booth@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
https://bugzilla.redhat.com/show_bug.cgi?id=1227446
--- Comment #3 from Alexander Kurtakov akurtako@redhat.com --- Fixed version: Spec URL: https://akurtakov.fedorapeople.org/eclipse-tm-terminal.spec SRPM URL: https://akurtakov.fedorapeople.org/eclipse-tm-terminal-4.0.0-0.2.git4ea71eb....
https://bugzilla.redhat.com/show_bug.cgi?id=1227446
Alexander Kurtakov akurtako@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?
--- Comment #4 from Alexander Kurtakov akurtako@redhat.com --- New Package SCM Request ======================= Package Name: eclipse-tm-terminal Short Description: Terminal plugin for Eclipse Upstream URL: https://www.eclipse.org/tm/ Owners: akurtakov group::eclipse-sig Branches: f22 InitialCC: eclipse-sig
https://bugzilla.redhat.com/show_bug.cgi?id=1227446
Jon Ciesla limburgher@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs? |fedora-cvs+
https://bugzilla.redhat.com/show_bug.cgi?id=1227446
--- Comment #5 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).
https://bugzilla.redhat.com/show_bug.cgi?id=1227446
Alexander Kurtakov akurtako@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |RAWHIDE Last Closed| |2015-06-03 03:12:50
--- Comment #6 from Alexander Kurtakov akurtako@redhat.com --- Built in rawhide.
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla