Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Merge Review: dbus
https://bugzilla.redhat.com/show_bug.cgi?id=225676
------- Additional Comments From johnp(a)redhat.com 2007-11-15 14:28 EST -------
Fixed most of the items in the devel branch
(In reply to comment #1)
[mclasen@localhost devel]$ rpmlint i386/dbus-1.1.2-8.fc8.i386.rpm
dbus.i386: E: executable-marked-as-config-file /etc/rc.d/init.d/messagebus
Should probably be fixed to follow the packaging guidelines.
removed the %config macro
dbus.i386: W: spurious-executable-perm
/usr/share/doc/dbus-1.1.2/COPYING
dbus.i386: W: spurious-executable-perm /usr/share/doc/dbus-1.1.2/ChangeLog
dbus.i386: W: spurious-executable-perm /usr/share/doc/dbus-1.1.2/NEWS
Should be fixed.
did a chmod in prep because the upstream tarball has these bits set though
curiously upstream git does not. May be fixed in next upstream release or
something is wrong during tarball packaging.
dbus.i386: W: conffile-without-noreplace-flag
/etc/dbus-1/session.conf
dbus.i386: W: conffile-without-noreplace-flag /etc/dbus-1/system.conf
I think these should probably be %config(noreplace)
Done
dbus.i386: W: conffile-without-noreplace-flag
/etc/rc.d/init.d/messagebus
Shouldn't be %config
fixed
dbus.i386: W: incoherent-init-script-name messagebus
Not sure what this is about, spurious warning.
Sticking with the upstream default
[mclasen@localhost devel]$ rpmlint i386/dbus-x11-1.1.2-8.fc8.i386.rpm
dbus-x11.i386: E: explicit-lib-dependency libX11
Remove libX11 requires.
rpm -qp dbus-x11-1.1.2-9.fc9.i386.rpm --requires shows libX11 was properly picked up
Packaging guidelines:
- uses of BuildPreReq and PreReq should be removed
Moved them to BuildRequires and Requires(pre) respectively
- the conflict with cups is somewhat curious and deserves a little
comment
Comment added from Tim Waugh's changelog
- the -devel subpackage should probably requires the -libs package,
not
the main package
This is a multilib thing I am told but the main package does require the -libs
package as it contains the actual versioned libraries
- should not mix $RPM_BUILD_ROOT and %{buildroot}
switched to using %{buildroot} exclusively
- Should the service be stopped in %preun before deleting it ? The
wiki
seems to imply that
Done
- %{_datadir}/man should perhaps be %{_mandir}
Done
- -devel should probably requires devhelp for
/usr/share/devhelp/books
directory ownership
I really don't like this since it would require KDE to have a GTK+ requirement
to build on Fedora. As much as I have an I don't care attitude I know there are
plenty who do care. Suggestions welcome. We could make a -devhelp sub package
but I think that is just a waste.
directory ownership: see above
Again - see above
file permissions: see above
Fixed
consistent macro use: see above
Fixed
--
Configure bugmail:
https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.