https://bugzilla.redhat.com/show_bug.cgi?id=2323149
Bug ID: 2323149 Summary: Review Request: nwg-dock-hyprland - A GTK3-based Dock for Hyprland Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Assignee: nobody@fedoraproject.org Reporter: nighti@nighti.dev QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://download.copr.fedorainfracloud.org/results/nightishaman/nwg-shell/sr... SRPM URL: https://download.copr.fedorainfracloud.org/results/nightishaman/nwg-shell/sr... Description: A GTK3-based Dock for the Hyprland window manager. This package is part of the nwg-shell project (https://nwg-piotr.github.io/nwg-shell/).
For a better experience, install nwg-drawer alongside this package.
Fedora Account System Username: nightishaman
Source and further explanation: https://github.com/nwg-piotr/nwg-dock-hyprland
This is my first ticket and I'd appreciate a sponsor for this. Here is a successful build from Koji using scratch-build: https://koji.fedoraproject.org/koji/taskinfo?taskID=125421458 Here is the copr build: https://copr.fedorainfracloud.org/coprs/nightishaman/nwg-shell/build/8198963...
Note: I'm using Go 1.23.2 as a build tool in the package, because the package requires it to build. Will find out whether I can drop this later anyhow. Note: I got permission from the author to package this app up for Fedora.
Thanks for reading!
https://bugzilla.redhat.com/show_bug.cgi?id=2323149
--- Comment #1 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Cannot find any valid SRPM URL for this ticket. Common causes are:
- You didn't specify `SRPM URL: ...` in the ticket description or any of your comments - The URL schema isn't HTTP or HTTPS - The SRPM package linked in your URL doesn't match the package name specified in the ticket summary
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2323149
Jannik Müller nighti@nighti.dev changed:
What |Removed |Added ---------------------------------------------------------------------------- Comment|0 |updated
--- Comment #0 has been edited ---
Spec URL: https://download.copr.fedorainfracloud.org/results/nightishaman/nwg-shell/sr... SRPM URL: https://download.copr.fedorainfracloud.org/results/nightishaman/nwg-shell/sr... Description: A GTK3-based Dock for the Hyprland window manager. This package is part of the nwg-shell project (https://nwg-piotr.github.io/nwg-shell/).
For a better experience, install nwg-drawer alongside this package.
Fedora Account System Username: nightishaman
Source and further explanation: https://github.com/nwg-piotr/nwg-dock-hyprland
This is my first ticket and I'd appreciate a sponsor for this. Here is a successful build from Koji using scratch-build: https://koji.fedoraproject.org/koji/taskinfo?taskID=125421458 Here is the copr build: https://copr.fedorainfracloud.org/coprs/nightishaman/nwg-shell/build/8198963...
Note: I'm using Go 1.23.2 as a build tool in the package, because the package requires it to build. Will find out whether I can drop this later anyhow. Note: I got permission from the author to package this app up for Fedora.
Thanks for reading!
https://bugzilla.redhat.com/show_bug.cgi?id=2323149
--- Comment #2 from Jannik Müller nighti@nighti.dev --- [fedora-review-service-build]
https://bugzilla.redhat.com/show_bug.cgi?id=2323149
Fedora Review Service fedora-review-bot@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- URL| |https://github.com/nwg-piot | |r/nwg-dock-hyprland
--- Comment #3 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/8199061 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Found issues:
- Upstream MD5sum check error, diff is in /var/lib/copr-rpmbuild/results/nwg-dock-hyprland/diff.txt Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/
Please know that there can be false-positives.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2323149
Mikel Olasagasti Uranga mikel@olasagasti.info changed:
What |Removed |Added ---------------------------------------------------------------------------- Doc Type|--- |If docs needed, set a value Assignee|nobody@fedoraproject.org |mikel@olasagasti.info CC| |mikel@olasagasti.info Status|NEW |ASSIGNED
--- Comment #5 from Mikel Olasagasti Uranga mikel@olasagasti.info --- As with `nwg-drawer` or `nwg-dock` I would advise to use go2rpm to generate the spec.
You can use the following command:
go2rpm -q --name nwg-dock-hyprland -f https://github.com/nwg-piotr/nwg-dock-hyprland nwg-dock-hyprland
You can check https://src.fedoraproject.org/rpms/nwg-drawer/blob/rawhide/f/nwg-drawer.spec and https://src.fedoraproject.org/rpms/nwg-dock/blob/rawhide/f/nwg-dock.spec as examples in case you need to modify the resulting spec.
About this module, I'm confused on why it's named `nwg-dock-hyprland` and not like `github.com/nwg-piotr/nwg-drawer` or `github.com/nwg-piotr/nwg-dock`. Can you suggest upstream to change the module name and adapt the go2rpm so it sets the correct goipath? I'm referring to this: https://github.com/nwg-piotr/nwg-dock-hyprland/blob/master/go.mod#L1
I would also recommend joining "Fedora Miracle" channel in Matrix to discuss more about this if you want.
https://bugzilla.redhat.com/show_bug.cgi?id=2323149
--- Comment #6 from Mikel Olasagasti Uranga mikel@olasagasti.info --- The unmodified spec generated by the go2rpm example fails to build with:
/usr/lib/golang/pkg/tool/linux_amd64/link: -X flag requires argument of the form importpath.name=value
This is because of the goipath and I guess a limitation in our tooling.
With this it works fine:
go2rpm -q --name nwg-dock-hyprland -f https://github.com/nwg-piotr/nwg-dock-hyprland github.com/nwg-piotr/nwg-dock-hyprland
So if upstream can change from nwg-dock-hyprland to github.com/nwg-piotr/nwg-dock-hyprland it would be great.
https://bugzilla.redhat.com/show_bug.cgi?id=2323149
--- Comment #7 from Jannik Müller nighti@nighti.dev --- Spec URL: https://download.copr.fedorainfracloud.org/results/nightishaman/nwg-shell/sr... SRPM URL: https://download.copr.fedorainfracloud.org/results/nightishaman/nwg-shell/sr...
https://bugzilla.redhat.com/show_bug.cgi?id=2323149
--- Comment #8 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Created attachment 2055238 --> https://bugzilla.redhat.com/attachment.cgi?id=2055238&action=edit The .spec file difference from Copr build 8199061 to 8204005
https://bugzilla.redhat.com/show_bug.cgi?id=2323149
Fedora Review Service fedora-review-bot@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |AutomationTriaged
--- Comment #9 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/8204005 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2323149
--- Comment #10 from Mikel Olasagasti Uranga mikel@olasagasti.info ---
%gopkginstall (...) %gopkgfiles
These create the `golang-github-nwg-piotr-dock-hyprland-devel` package, that is required in case some other package has them as dependency. IIUC this is a binary only package, so they can be removed.
Once we clarify that spec would be approved as it's correct.
https://bugzilla.redhat.com/show_bug.cgi?id=2323149
--- Comment #11 from Jannik Müller nighti@nighti.dev --- Spec URL: https://download.copr.fedorainfracloud.org/results/nightishaman/nwg-shell/sr... SRPM URL: https://download.copr.fedorainfracloud.org/results/nightishaman/nwg-shell/sr...
https://bugzilla.redhat.com/show_bug.cgi?id=2323149
--- Comment #12 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Created attachment 2055375 --> https://bugzilla.redhat.com/attachment.cgi?id=2055375&action=edit The .spec file difference from Copr build 8204005 to 8205931
https://bugzilla.redhat.com/show_bug.cgi?id=2323149
--- Comment #13 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/8205931 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2323149
Mikel Olasagasti Uranga mikel@olasagasti.info changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review+
--- Comment #14 from Mikel Olasagasti Uranga mikel@olasagasti.info --- Golang Package Review ==============
This package was generated using go2rpm, which simplifies the review.
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
- [x] The latest version is packaged or packaging an earlier version is justified. - [x] The License tag reflects the package contents and uses the correct identifiers. - [x] The package builds successfully in mock. - [x] Package is installable (checked by fedora-review). - [x] There are no relevant rpmlint errors. - [x] The package runs tests in %check. - [x] `%goipath` is set correctly. - [-] The package's binaries don't conflict with binaries already in the distribution. (Some Go projects include utility binaries with very generic names) - [-] There are no `%{_bindir}/*` wildcards in %files. (go2rpm includes these by default) - [x] The package does not use `%gometa -f` if it has dependents that still build for %ix86. - [x] The package complies with the Golang and general Packaging Guidelines.
Package approved! On import, don't forget to do the following:
- [ ] Add the package to release-monitoring.org. - [ ] Give go-sig privileges (at least commit) on the package. - [ ] Close the review bug by referencing its ID in the rpm changelog and the Bodhi ticket. It can be done with a commit message like "Initial commit - Closes rhbz#2323149". - [ ] Consider configuring Packit service to help with maintenance.
Feel free to ask if you have any doubt with these actions.
Thanks!
https://bugzilla.redhat.com/show_bug.cgi?id=2323149
--- Comment #15 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Hello @nightishaman, since this is your first Fedora package, you need to get sponsored by a package sponsor before it can be accepted.
A sponsor is an experienced package maintainer who will guide you through the processes that you will follow and the tools that you will use as a future maintainer. A sponsor will also be there to answer your questions related to packaging.
You can find all active sponsors here: https://docs.pagure.org/fedora-sponsors/
I created a sponsorship request for you: https://pagure.io/packager-sponsors/issue/691 Please take a look and make sure the information is correct.
Thank you, and best of luck on your packaging journey.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
https://bugzilla.redhat.com/show_bug.cgi?id=2323149
Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RELEASE_PENDING
--- Comment #16 from Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org --- The Pagure repository was created at https://src.fedoraproject.org/rpms/nwg-dock-hyprland
https://bugzilla.redhat.com/show_bug.cgi?id=2323149
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RELEASE_PENDING |MODIFIED
--- Comment #17 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-4d23d3e22e (nwg-dock-hyprland-0.3.2-2.fc42) has been submitted as an update to Fedora 42. https://bodhi.fedoraproject.org/updates/FEDORA-2024-4d23d3e22e
https://bugzilla.redhat.com/show_bug.cgi?id=2323149
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |CLOSED Resolution|--- |ERRATA Last Closed| |2024-11-04 13:38:39
--- Comment #18 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-4d23d3e22e (nwg-dock-hyprland-0.3.2-2.fc42) has been pushed to the Fedora 42 stable repository. If problem still persists, please make note of it in this bug report.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com