https://bugzilla.redhat.com/show_bug.cgi?id=2149834
Bug ID: 2149834 Summary: Review Request: tuner - Minimalist radio station player Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nobody@fedoraproject.org Reporter: vascom2@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://raw.githubusercontent.com/Vascom/tuner/main/tuner.spec SRPM URL: https://kojipkgs.fedoraproject.org//work/tasks/3436/94733436/tuner-1.5.1-1.f...
Description: Discover and Listen to your favourite internet radio stations.
https://bugzilla.redhat.com/show_bug.cgi?id=2149834
Benson Muite benson_muite@emailplus.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Doc Type|--- |If docs needed, set a value Assignee|nobody@fedoraproject.org |benson_muite@emailplus.org Flags| |fedora-review? CC| |benson_muite@emailplus.org
https://bugzilla.redhat.com/show_bug.cgi?id=2149834
--- Comment #1 from Vasiliy Glazov vascom2@gmail.com --- Any progress?
https://bugzilla.redhat.com/show_bug.cgi?id=2149834
--- Comment #2 from Benson Muite benson_muite@emailplus.org --- Need another day or so. Thanks for your patience and making this available to Fedora linux users.
https://bugzilla.redhat.com/show_bug.cgi?id=2149834
--- Comment #3 from Benson Muite benson_muite@emailplus.org --- Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
===== MUST items =====
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* GNU General Public License, Version 3", "GNU General Public License v3.0 or later". 66 files have unknown license. Detailed output of licensecheck in /home/fedora/tuner/2149834-tuner/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [?]: Sources contain only permissible code or content. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [?]: The spec file handles locales properly. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [?]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [?]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: tuner-1.5.1-1.fc38.aarch64.rpm tuner-debuginfo-1.5.1-1.fc38.aarch64.rpm tuner-debugsource-1.5.1-1.fc38.aarch64.rpm tuner-1.5.1-1.fc38.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp1b5l041j')] checks: 31, packages: 4
tuner.aarch64: W: no-manual-page-for-binary com.github.louis77.tuner tuner.aarch64: W: files-duplicate /usr/share/icons/hicolor/128x128@2/apps/com.github.louis77.tuner.svg /usr/share/icons/hicolor/128x128/apps/com.github.louis77.tuner.svg tuner.aarch64: W: files-duplicate /usr/share/icons/hicolor/16x16@2/apps/com.github.louis77.tuner.svg /usr/share/icons/hicolor/16x16/apps/com.github.louis77.tuner.svg tuner.aarch64: W: files-duplicate /usr/share/icons/hicolor/24x24@2/apps/com.github.louis77.tuner.svg /usr/share/icons/hicolor/24x24/apps/com.github.louis77.tuner.svg tuner.aarch64: W: files-duplicate /usr/share/icons/hicolor/32x32@2/apps/com.github.louis77.tuner.svg /usr/share/icons/hicolor/32x32/apps/com.github.louis77.tuner.svg tuner.aarch64: W: files-duplicate /usr/share/icons/hicolor/48x48@2/apps/com.github.louis77.tuner.svg /usr/share/icons/hicolor/48x48/apps/com.github.louis77.tuner.svg tuner.aarch64: W: files-duplicate /usr/share/icons/hicolor/64x64@2/apps/com.github.louis77.tuner.svg /usr/share/icons/hicolor/64x64/apps/com.github.louis77.tuner.svg 4 packages and 0 specfiles checked; 0 errors, 7 warnings, 0 badness; has taken 2.1 s
Rpmlint (debuginfo) ------------------- Checking: tuner-debuginfo-1.5.1-1.fc38.aarch64.rpm ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpo2a4cv0g')] checks: 31, packages: 1
1 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 0.8 s
Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 3
tuner.aarch64: W: no-manual-page-for-binary com.github.louis77.tuner tuner.aarch64: W: files-duplicate /usr/share/icons/hicolor/128x128@2/apps/com.github.louis77.tuner.svg /usr/share/icons/hicolor/128x128/apps/com.github.louis77.tuner.svg tuner.aarch64: W: files-duplicate /usr/share/icons/hicolor/16x16@2/apps/com.github.louis77.tuner.svg /usr/share/icons/hicolor/16x16/apps/com.github.louis77.tuner.svg tuner.aarch64: W: files-duplicate /usr/share/icons/hicolor/24x24@2/apps/com.github.louis77.tuner.svg /usr/share/icons/hicolor/24x24/apps/com.github.louis77.tuner.svg tuner.aarch64: W: files-duplicate /usr/share/icons/hicolor/32x32@2/apps/com.github.louis77.tuner.svg /usr/share/icons/hicolor/32x32/apps/com.github.louis77.tuner.svg tuner.aarch64: W: files-duplicate /usr/share/icons/hicolor/48x48@2/apps/com.github.louis77.tuner.svg /usr/share/icons/hicolor/48x48/apps/com.github.louis77.tuner.svg tuner.aarch64: W: files-duplicate /usr/share/icons/hicolor/64x64@2/apps/com.github.louis77.tuner.svg /usr/share/icons/hicolor/64x64/apps/com.github.louis77.tuner.svg 3 packages and 0 specfiles checked; 0 errors, 7 warnings, 0 badness; has taken 2.9 s
Source checksums ---------------- https://github.com/louis77/tuner/archive/refs/tags/1.5.1.tar.gz : CHECKSUM(SHA256) this package : bbb5e7c97da1ee495651d85aca33c2fe58daba81906ae247e12b6a41b1ed7592 CHECKSUM(SHA256) upstream package : bbb5e7c97da1ee495651d85aca33c2fe58daba81906ae247e12b6a41b1ed7592
Requires -------- tuner (rpmlib, GLIBC filtered): hicolor-icon-theme ld-linux-aarch64.so.1()(64bit) libc.so.6()(64bit) libgdk-3.so.0()(64bit) libgdk_pixbuf-2.0.so.0()(64bit) libgee-0.8.so.2()(64bit) libgeoclue-2.so.0()(64bit) libgeocode-glib.so.0()(64bit) libgio-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libgranite.so.6()(64bit) libgstplayer-1.0.so.0()(64bit) libgstreamer-1.0.so.0()(64bit) libgtk-3.so.0()(64bit) libjson-glib-1.0.so.0()(64bit) libjson-glib-1.0.so.0(libjson-glib-1.0.so.0)(64bit) libsoup-2.4.so.1()(64bit) rtld(GNU_HASH)
tuner-debuginfo (rpmlib, GLIBC filtered):
tuner-debugsource (rpmlib, GLIBC filtered):
Provides -------- tuner: application() application(com.github.louis77.tuner.desktop) metainfo() metainfo(com.github.louis77.tuner.appdata.xml) tuner tuner(aarch-64)
tuner-debuginfo: debuginfo(build-id) tuner-debuginfo tuner-debuginfo(aarch-64)
tuner-debugsource: tuner-debugsource tuner-debugsource(aarch-64)
Generated by fedora-review 0.9.0 (6761b6c) last change: 2022-08-23 Command line :/usr/bin/fedora-review -b 2149834 Buildroot used: fedora-rawhide-aarch64 Active plugins: Shell-api, Generic Disabled plugins: Haskell, Perl, Python, SugarActivity, C/C++, Java, R, Ocaml, fonts, PHP Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
Comments: a) May want to have %global forgeurl https://github.com/louis77/tuner %global tag %{version} at the top of your spec file and the use URL: %{forgeurl}
%forgemeta Source: %{forgesource} b) The license seems to be GPLv3 not GPLv3+ c) Some build warnings: ted in error domains yet 250 | public unowned string get_name (); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../src/Controllers/PlayerController.vala:38.5-38.41: warning: Type `Gst.PlayerSt ate?' can not be used for a GLib.Object property 38 | public Gst.PlayerState? current_state { | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Additional warnings: cpio: redhat-linux-build/AboutDialog.c: Cannot stat: No such file or directory cpio: redhat-linux-build/AbstractContentList.c: Cannot stat: No such file or dir ectory cpio: redhat-linux-build/Application.c: Cannot stat: No such file or directory cpio: redhat-linux-build/ContentBox.c: Cannot stat: No such file or directory cpio: redhat-linux-build/Countries.c: Cannot stat: No such file or directory cpio: redhat-linux-build/CountryList.c: Cannot stat: No such file or directory cpio: redhat-linux-build/DBusInterface.c: Cannot stat: No such file or directory cpio: redhat-linux-build/DBusMediaPlayer.c: Cannot stat: No such file or directo ry cpio: redhat-linux-build/DirectoryController.c: Cannot stat: No such file or dir ectory cpio: redhat-linux-build/Genre.c: Cannot stat: No such file or directory cpio: redhat-linux-build/HeaderBar.c: Cannot stat: No such file or directory cpio: redhat-linux-build/HeaderLabel.c: Cannot stat: No such file or directory cpio: redhat-linux-build/LocationDiscovery.c: Cannot stat: No such file or direc tory cpio: redhat-linux-build/Main.c: Cannot stat: No such file or directory cpio: redhat-linux-build/PlayerController.c: Cannot stat: No such file or direct ory cpio: redhat-linux-build/PreferencesPopover.c: Cannot stat: No such file or dire ctory cpio: redhat-linux-build/RadioBrowserDirectory.c: Cannot stat: No such file or d irectory cpio: redhat-linux-build/RevealLabel.c: Cannot stat: No such file or directory cpio: redhat-linux-build/Station.c: Cannot stat: No such file or directory cpio: redhat-linux-build/StationBox.c: Cannot stat: No such file or directory cpio: redhat-linux-build/StationContextMenu.c: Cannot stat: No such file or dire ctory cpio: redhat-linux-build/StationList.c: Cannot stat: No such file or directory cpio: redhat-linux-build/StationStore.c: Cannot stat: No such file or directory cpio: redhat-linux-build/Theme.c: Cannot stat: No such file or directory cpio: redhat-linux-build/WelcomeButton.c: Cannot stat: No such file or directory cpio: redhat-linux-build/Window.c: Cannot stat: No such file or directory cpio: redhat-linux-build/glib-2.0.vapi: Cannot stat: No such file or directory
d) Assume icons have been made for this project and so are also under GPLv3? e) It is helpful to do a build on Copr/Koji for all required architectures. f) Could the files %{_datadir}/icons/hicolor/*/apps/com.github.louis77.%{name}.svg %{_datadir}/metainfo/com.github.louis77.%{name}.appdata.xml %{_datadir}/applications/com.github.louis77.%{name}.desktop %{_datadir}/glib-2.0/schemas/com.github.louis77.%{name}.gschema.xml be placed in %{_datadir}/tuner/icons/hicolor/*/apps/com.github.louis77.%{name}.svg %{_datadir}/tuner/metainfo/com.github.louis77.%{name}.appdata.xml %{_datadir}/tuner/applications/com.github.louis77.%{name}.desktop %{_datadir}/tuner/glib-2.0/schemas/com.github.louis77.%{name}.gschema.xml and also add %dir %{_datadir}/tuner to the spec file
https://bugzilla.redhat.com/show_bug.cgi?id=2149834
--- Comment #4 from Vasiliy Glazov vascom2@gmail.com --- a) No need to create additional macro for Source: and Version: b) I will change license to GPL-3.0-only c) Warnings is not errors :) d) Special license for icons not described by upstream. e) Package build directly in koji for all supported arches https://koji.fedoraproject.org/koji/taskinfo?taskID=94733366 f) Icons, desktop and xml files on their places. No need to move them and create additional %{_datadir}/tuner directory.
https://bugzilla.redhat.com/show_bug.cgi?id=2149834
--- Comment #5 from Vasiliy Glazov vascom2@gmail.com --- Addition e) Review request process not require from me build anything. Only spec-file and src.rpm package.
https://bugzilla.redhat.com/show_bug.cgi?id=2149834
--- Comment #6 from Vasiliy Glazov vascom2@gmail.com --- Fix: b) Source files contain in header SPDX-License-Identifier: GPL-3.0-or-later
So License identifier GPLv3+ was right. I will change it to GPL-3.0-or-later
https://bugzilla.redhat.com/show_bug.cgi?id=2149834
--- Comment #7 from Benson Muite benson_muite@emailplus.org --- a) Just a suggestion, seems cleaner, not essential b) Thanks. c) Ok. Maybe report upstream? Any idea why getting cpio errors? d) Assume it is fine. e) Thanks - this makes it helpful to review. It is not necessary on your part but speeds up the review process. f) This seems fine.
Checking functionality.
https://bugzilla.redhat.com/show_bug.cgi?id=2149834
--- Comment #8 from Vasiliy Glazov vascom2@gmail.com --- cpio errors seems like Fedora's problem during debuginfo extracting.
https://bugzilla.redhat.com/show_bug.cgi?id=2149834
--- Comment #9 from Vasiliy Glazov vascom2@gmail.com --- Spec URL: https://raw.githubusercontent.com/Vascom/tuner/main/tuner.spec SRPM URL: https://kojipkgs.fedoraproject.org//work/tasks/2747/95122747/tuner-1.5.1-1.f...
Fixed license name.
https://bugzilla.redhat.com/show_bug.cgi?id=2149834
--- Comment #10 from Benson Muite benson_muite@emailplus.org --- It seems to work. Why not name the binary executable tuner instead of com.github.louis77.tuner ?
In the description, may want to indicate it uses radio-browser.info/radio-browser.org to get station information.
Is tracking enabled/disabled by default?
https://bugzilla.redhat.com/show_bug.cgi?id=2149834
--- Comment #11 from Vasiliy Glazov vascom2@gmail.com --- Since it have desktop-file i think it is not need to rename executable. I will add radio-browser.info/radio-browser.org to description. About enabled/disabled tracking I don't know.
https://bugzilla.redhat.com/show_bug.cgi?id=2149834
--- Comment #12 from Benson Muite benson_muite@emailplus.org --- Not everybody will use a desktop to launch the application, some may launch it from the command line.
For tracking information, check when you launch the application and the source code. Preferred default is tracking disabled.
https://bugzilla.redhat.com/show_bug.cgi?id=2149834
--- Comment #13 from Vasiliy Glazov vascom2@gmail.com --- This naming provided by upstream. If anyone want run binary from command line it is not difficult to find name. Also "tuner" seems widely used word and can conflict with other binaries in the future.
Default tracking is enabled. Can you help me find what need to change to disable by default?
https://bugzilla.redhat.com/show_bug.cgi?id=2149834
--- Comment #14 from Benson Muite benson_muite@emailplus.org --- See https://github.com/louis77/tuner/blob/master/src/Widgets/Window.vala#L33 Perhaps use a patch or sed to change: { ACTION_DISABLE_TRACKING, on_action_disable_tracking, null, "false" } to { ACTION_DISABLE_TRACKING, on_action_disable_tracking, null, "true" }
It seems to affect: https://github.com/louis77/tuner/blob/master/src/Controllers/DirectoryContro...
https://bugzilla.redhat.com/show_bug.cgi?id=2149834
--- Comment #15 from Vasiliy Glazov vascom2@gmail.com --- May be change https://github.com/louis77/tuner/blob/master/data/com.github.louis77.tuner.g...
https://bugzilla.redhat.com/show_bug.cgi?id=2149834
--- Comment #16 from Vasiliy Glazov vascom2@gmail.com --- Spec URL: https://raw.githubusercontent.com/Vascom/tuner/main/tuner.spec SRPM URL: https://kojipkgs.fedoraproject.org//work/tasks/2747/95122747/tuner-1.5.1-1.f...
Tracking disabled by default.
https://bugzilla.redhat.com/show_bug.cgi?id=2149834
--- Comment #17 from Vasiliy Glazov vascom2@gmail.com --- Spec URL: https://raw.githubusercontent.com/Vascom/tuner/main/tuner.spec https://kojipkgs.fedoraproject.org//work/tasks/9700/95349700/tuner-1.5.1-2.f...
Tracking disabled by default.
https://bugzilla.redhat.com/show_bug.cgi?id=2149834
--- Comment #19 from Benson Muite benson_muite@emailplus.org --- Looks ok, builds on all architectures: https://copr.fedorainfracloud.org/coprs/fed500/tuner/build/5144455/
Should https://github.com/louis77/tuner/blob/master/src/Widgets/Window.vala#L33 also be changed?
Just comparing with settings for autoplay: https://github.com/louis77/tuner/blob/master/data/com.github.louis77.tuner.g... https://github.com/louis77/tuner/blob/master/src/Widgets/Window.vala#L34
If not why not?
https://bugzilla.redhat.com/show_bug.cgi?id=2149834
--- Comment #20 from Vasiliy Glazov vascom2@gmail.com --- I think https://github.com/louis77/tuner/blob/master/src/Widgets/Window.vala#L33 no need to change.
https://bugzilla.redhat.com/show_bug.cgi?id=2149834
--- Comment #21 from Benson Muite benson_muite@emailplus.org --- Why?
https://bugzilla.redhat.com/show_bug.cgi?id=2149834
--- Comment #22 from Vasiliy Glazov vascom2@gmail.com --- Is it mandatory?
https://bugzilla.redhat.com/show_bug.cgi?id=2149834
--- Comment #23 from Benson Muite benson_muite@emailplus.org --- We want to ensure a good Fedora user experience, so it is helpful to get this done correctly.
https://bugzilla.redhat.com/show_bug.cgi?id=2149834
--- Comment #24 from Vasiliy Glazov vascom2@gmail.com --- I'm not sure this is necessary to change more.
https://bugzilla.redhat.com/show_bug.cgi?id=2149834
--- Comment #25 from Vasiliy Glazov vascom2@gmail.com --- So review approved or I need to make some changes?
https://bugzilla.redhat.com/show_bug.cgi?id=2149834
--- Comment #26 from Benson Muite benson_muite@emailplus.org --- Trying to understand where tracking information is actually set. Does schema.xml take precedence over window.vala? If so, why duplicate settings in window.vala?
https://bugzilla.redhat.com/show_bug.cgi?id=2149834
--- Comment #27 from Benson Muite benson_muite@emailplus.org --- The documentation https://valadoc.org/gio-2.0/GLib.SimpleAction.SimpleAction.stateful.html#! indicates the last entry is the initial state, so this should match what is in the schema.
Schema example at https://wiki.gnome.org/Projects/Vala/GSettingsSample seems much clearer.
https://bugzilla.redhat.com/show_bug.cgi?id=2149834
--- Comment #28 from Benson Muite benson_muite@emailplus.org --- Project development has moved to Codeberg https://codeberg.org/tuner/tuner
https://bugzilla.redhat.com/show_bug.cgi?id=2149834
--- Comment #29 from Vasiliy Glazov vascom2@gmail.com --- Spec URL: https://raw.githubusercontent.com/Vascom/tuner/main/tuner.spec SRPM URL: https://kojipkgs.fedoraproject.org//work/tasks/852/95620852/tuner-1.5.1-3.fc...
Updated URL and Source.
https://bugzilla.redhat.com/show_bug.cgi?id=2149834
--- Comment #30 from Vasiliy Glazov vascom2@gmail.com --- What do I need to do to get your approval?
https://bugzilla.redhat.com/show_bug.cgi?id=2149834
Benson Muite benson_muite@emailplus.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(benson_muite@emai | |lplus.org) |
--- Comment #32 from Benson Muite benson_muite@emailplus.org --- Going through it. Upstream is not very active.
Product: Fedora Version: rawhide Component: Package Review
Benson Muite benson_muite@emailplus.org has canceled Package Review package-review@lists.fedoraproject.org's request for Benson Muite benson_muite@emailplus.org's needinfo: Bug 2149834: Review Request: tuner - Minimalist radio station player https://bugzilla.redhat.com/show_bug.cgi?id=2149834
--- Comment #32 from Benson Muite benson_muite@emailplus.org --- Going through it. Upstream is not very active.
https://bugzilla.redhat.com/show_bug.cgi?id=2149834
Artur Frenszek-Iwicki fedora@svgames.pl changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |fedora@svgames.pl
--- Comment #35 from Artur Frenszek-Iwicki fedora@svgames.pl --- Are you still interested in this, Vasiliy? The Codeberg repo seems to be gone, but there's been a v2.0.0 release on GitHub.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com