[Bug 2064155] New: Review Request: rust-vcsgraph - Library to perform various computation of a version control graph

https://bugzilla.redhat.com/show_bug.cgi?id=2064155

Bug ID: 2064155
           Summary: Review Request: rust-vcsgraph - Library to perform
                    various computation of a version control graph
           Product: Fedora
           Version: rawhide
          Hardware: All
                OS: Linux
            Status: NEW
         Component: Package Review
          Severity: medium
          Priority: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]
  Target Milestone: ---
    Classification: Fedora

Spec URL:
https://alebastr.fedorapeople.org/review/mercurial-rs/rust-vcsgraph.spec
SRPM URL:
https://alebastr.fedorapeople.org/review/mercurial-rs/rust-vcsgraph-0.2.0-1....
Description:
Library to perform various computation of a version control graph.
Fedora Account System Username: alebastr

Regarding `-a` flag - see https://pagure.io/fedora-rust/rust2rpm/issue/110

[Bug 2064155] Review Request: rust-vcsgraph - Library to perform various computation of a version control graph

https://bugzilla.redhat.com/show_bug.cgi?id=2064155

Aleksei Bavshin  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |2063941

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=2063941
[Bug 2063941] Feature request: Enable Mercurial rust extensions

[Bug 2064155] Review Request: rust-vcsgraph - Library to perform various computation of a version control graph

https://bugzilla.redhat.com/show_bug.cgi?id=2064155

Mads Kiilerich  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Doc Type|---                         |If docs needed, set a value
                 CC|                            |[e-mail]

--- Comment #1 from Mads Kiilerich  ---
I verified that the spec and source is exactly as generated with "rust2rpm -as
vcsgraph", except

@@ -28,7 +28,6 @@
 %description -n %{crate} %{_description}

%files       -n %{crate}
-# FIXME: no license files detected
 %doc README.md
 %{_bindir}/analytics
 %{_bindir}/testing
@@ -43,7 +42,6 @@
 use the "%{crate}" crate.

%files          devel
-# FIXME: no license files detected
 %doc %{crate_instdir}/README.md
 %{crate_instdir}/

@@ -88,17 +86,17 @@
 %cargo_prep

%generate_buildrequires
-%cargo_generate_buildrequires
+%cargo_generate_buildrequires -a

%build
-%cargo_build
+%cargo_build -a

%install
-%cargo_install
+%cargo_install -a

%if %{with check}
 %check
-%cargo_test
+%cargo_test -a
 %endif

%changelog

I think the -a explanation should be a comment in the spec so the deviation
from rust2rpm is obvious. While
https://pagure.io/fedora-rust/rust2rpm/issue/110 might be the core problem, it
would be nice to have a hint what -a does and why it is a valid workaround. It
seems like it is an argument for cargo-inspector, but it is not clear to me
what it changes from what default.

The license file FIXME seems valid and points out an upstream problem - should
it really just be removed like that?

The GPLv2+ license is OK.

The package builds locally on f35, installs, and works for enabling
experimental build of Mercurial with Rust extensions.

rpmlint is clean, except "W: no-documentation".

[Bug 2064155] Review Request: rust-vcsgraph - Library to perform various computation of a version control graph

https://bugzilla.redhat.com/show_bug.cgi?id=2064155

--- Comment #2 from Aleksei Bavshin  ---
Updated the spec with comments about both issues.

The upstream issue for missing license is
https://foss.heptapod.net/mercurial/vcsgraph/-/issues/16

[Bug 2064155] Review Request: rust-vcsgraph - Library to perform various computation of a version control graph

https://bugzilla.redhat.com/show_bug.cgi?id=2064155

Mads Kiilerich  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |fedora-review+

[Bug 2064155] Review Request: rust-vcsgraph - Library to perform various computation of a version control graph

https://bugzilla.redhat.com/show_bug.cgi?id=2064155

Mads Kiilerich  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|[e-mail]    |[e-mail]

[Bug 2064155] Review Request: rust-vcsgraph - Library to perform various computation of a version control graph

https://bugzilla.redhat.com/show_bug.cgi?id=2064155

--- Comment #3 from Gwyn Ciesla  ---
(fedscm-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/rust-vcsgraph

[Bug 2064155] Review Request: rust-vcsgraph - Library to perform various computation of a version control graph

https://bugzilla.redhat.com/show_bug.cgi?id=2064155

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |MODIFIED

--- Comment #4 from Fedora Update System  ---
FEDORA-2022-c7ededf903 has been submitted as an update to Fedora 36.
https://bodhi.fedoraproject.org/updates/FEDORA-2022-c7ededf903

[Bug 2064155] Review Request: rust-vcsgraph - Library to perform various computation of a version control graph

https://bugzilla.redhat.com/show_bug.cgi?id=2064155

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|MODIFIED                    |ON_QA

--- Comment #5 from Fedora Update System  ---
FEDORA-2022-c7ededf903 has been pushed to the Fedora 36 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing
--advisory=FEDORA-2022-c7ededf903 *`
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2022-c7ededf903

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information
on how to test updates.

[Bug 2064155] Review Request: rust-vcsgraph - Library to perform various computation of a version control graph

https://bugzilla.redhat.com/show_bug.cgi?id=2064155

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ON_QA                       |CLOSED
         Resolution|---                         |ERRATA
        Last Closed|                            |2022-05-07 04:17:49

--- Comment #6 from Fedora Update System  ---
FEDORA-2022-c7ededf903 has been pushed to the Fedora 36 stable repository.
If problem still persists, please make note of it in this bug report.