[Bug 486584] New: Review Request: <main package name here> - <short summary here>

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: <main package name here> - <short summary here>

https://bugzilla.redhat.com/show_bug.cgi?id=486584

Summary: Review Request: <main package name here> - <short
                    summary here>
           Product: Fedora
           Version: rawhide
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: low
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail], [e-mail]
   Estimated Hours: 0.0
    Classification: Fedora

Spec URL:
http://people.parinux.org/~seyman/fedora/perl-CGI-Application/perl-CGI-Appli...
SRPM URL:
http://people.parinux.org/~seyman/fedora/perl-CGI-Application/perl-CGI-Appli...
Description:

CGI::Application is an Object-Oriented Perl module which implements an
Abstract Class. It is not intended that this package be instantiated
directly. Instead, it is intended that your Application Module will be
implemented as a Sub-Class of CGI::Application.

[Bug 486584] Review Request: perl-CGI-Application - Framework for building reusable web-applications

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=486584

Emmanuel Seyman  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Review Request: <main       |Review Request:
                   |package name here> - <short |perl-CGI-Application -
                   |summary here>               |Framework for building
                   |                            |reusable web-applications

[Bug 486584] Review Request: perl-CGI-Application - Framework for building reusable web-applications

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=486584

Suravee Suthikulpanit  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |suravee.suthikulpanit@amd.c
                   |                            |om

--- Comment #1 from Suravee Suthikulpanit   2009-03-02 11:18:23 EDT ---
This is an unofficial review:

- The build return errors complaining "Test::More is not installed". Should be
part of the BuildRequires?

OKAYs:
- Checksum matches upstream
(778ecbaf87bc3fe56df210841a80aa83eb64b78a26c4bd0079143705a1301be9 
CGI-Application-4.21.tar.gz)
- BuildRoot (%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n))
- Licensing (GPL+ or Artistic, included in package)
- Latest upstream version (4.21)
- Rpmlint quiet
- %clean, %install present and starts with "rm -rf $RPM_BUILD_ROOT"
- file permission (-,root,root,-)

[Bug 486584] Review Request: perl-CGI-Application - Framework for building reusable web-applications

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=486584

--- Comment #2 from Emmanuel Seyman   2009-03-02 19:19:13 EDT ---
(In reply to comment #1)
> This is an unofficial review:

Thanks for investing your time on this review, Suravee. It's very much
appreciated.
> The build return errors complaining "Test::More is not installed". Should be
>
> part of the BuildRequires?

Correct. I've uploaded another release (4.21-2) which corrects this.

Spec URL:
http://people.parinux.org/~seyman/fedora/perl-CGI-Application/perl-CGI-Appli...
SRPM URL:
http://people.parinux.org/~seyman/fedora/perl-CGI-Application/perl-CGI-Appli...

[Bug 486584] Review Request: perl-CGI-Application - Framework for building reusable web-applications

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=486584

Jason Tibbitts  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |177841(FE-NEEDSPONSOR)

--- Comment #3 from Jason Tibbitts   2009-03-07 12:35:55 EDT ---
I do not see that you are in the packager group, so I have indicated that you
need a sponsor.

[Bug 486584] Review Request: perl-CGI-Application - Framework for building reusable web-applications

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=486584

Xavier Lamien  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
             Blocks|177841(FE-NEEDSPONSOR)      |
               Flag|                            |fedora-review?

--- Comment #4 from Xavier Lamien   2009-03-08 08:31:52 EDT ---
k, taking the review and removing sponsor request block, i take care of that
one.

[Bug 486584] Review Request: perl-CGI-Application - Framework for building reusable web-applications

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=486584

Xavier Lamien  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|[e-mail]    |[e-mail]

[Bug 486584] Review Request: perl-CGI-Application - Framework for building reusable web-applications

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=486584

Xavier Lamien  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #5 from Xavier Lamien   2009-03-15 07:24:14 EDT ---
Merging additional review block from comment #1

OK source files match upstream(double checked):
 778ecbaf87bc3fe56df210841a80aa83eb64b78a26c4bd0079143705a1301be9 
CGI-Application-4.21.tar.gz
OK package meets naming and versioning guidelines.
OK specfile is properly named, is cleanly written and uses macros consistently.
OK dist tag is present.
OK build root is correct.
OK license field matches the actual license.
OK License text included in package.
OK latest version is being packaged (not mandatory).
OK BuildRequires are proper and match PERL packaging Guideline.
OK      Build framework is used and correctly BR'ed.
OK %clean is present.
OK package builds in koji (Rawhide, f-10).
OK rpmlint is silent.
OK final provides and requires look good.
OK %check is present and all tests pass.
OK owns the directories it creates.
OK doesn't own any directories it shouldn't.
OK no duplicates in %files.
OK file permissions are appropriate.
OK documentation is small, so no -docs subpackage is necessary.

That package is good for FPC.

*APPROVED*

Please, follow those steps below before request CVS branch and sponsorship.
Sponsorship:
https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group

Once you get approved as a Fedora packager go to:
https://fedoraproject.org/wiki/CVS_admin_requests

I'd also like that you start review a couple of packages Review Requests to
track down your skills and your understanding in Fedora rpm packaging's way.

[Bug 486584] Review Request: perl-CGI-Application - Framework for building reusable web-applications

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=486584

Emmanuel Seyman  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?

--- Comment #6 from Emmanuel Seyman   2009-03-20 10:16:57 EDT ---
New Package CVS Request
=======================
Package Name: perl-CGI-Application
Short Description: Framework for building reusable web-applications
Owners: eseyman
Branches: F-9 F-10
InitialCC: perl-sig

[Bug 486584] Review Request: perl-CGI-Application - Framework for building reusable web-applications

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=486584

Kevin Fenzi  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-cvs?                 |fedora-cvs+

--- Comment #7 from Kevin Fenzi   2009-03-22 01:48:09 EDT ---
cvs done.

[Bug 486584] Review Request: perl-CGI-Application - Framework for building reusable web-applications

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=486584

--- Comment #8 from Fedora Update System   2009-04-01 05:22:43 EDT ---
perl-CGI-Application-4.21-2.fc10 has been submitted as an update for Fedora 10.
http://admin.fedoraproject.org/updates/perl-CGI-Application-4.21-2.fc10

[Bug 486584] Review Request: perl-CGI-Application - Framework for building reusable web-applications

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=486584

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |ON_QA

--- Comment #9 from Fedora Update System   2009-04-02 13:22:25 EDT ---
perl-CGI-Application-4.21-2.fc10 has been pushed to the Fedora 10 testing
repository.  If problems still persist, please make note of it in this bug
report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update perl-CGI-Application'.  You can
provide feedback for this update here:
http://admin.fedoraproject.org/updates/F10/FEDORA-2009-3291

[Bug 486584] Review Request: perl-CGI-Application - Framework for building reusable web-applications

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=486584

--- Comment #10 from Fedora Update System   2009-04-14 11:54:33 EDT ---
perl-CGI-Application-4.21-2.fc10 has been pushed to the Fedora 10 stable
repository.  If problems still persist, please make note of it in this bug
report.

[Bug 486584] Review Request: perl-CGI-Application - Framework for building reusable web-applications

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=486584

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ON_QA                       |CLOSED
   Fixed In Version|                            |4.21-2.fc10
         Resolution|                            |NEXTRELEASE

[Bug 486584] Review Request: perl-CGI-Application - Framework for building reusable web-applications

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=486584

Emmanuel Seyman  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-cvs+                 |fedora-cvs?

--- Comment #11 from Emmanuel Seyman  2012-02-15 07:52:51 EST ---
Package Change Request
======================
Package Name: perl-CGI-Application
New Branches: el6
Owners: eseyman ktdreyer
InitialCC: perl-sig

Ken Dreyer contacted me for an el6 branch for this module.

[Bug 486584] Review Request: perl-CGI-Application - Framework for building reusable web-applications

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=486584

--- Comment #12 from Jon Ciesla  2012-02-15 08:51:44 EST ---
Git done (by process-git-requests).