[Bug 1352215] New: Review Request: llvm37 -- Versioned LLVM 3.7

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1352215

Bug ID: 1352215
           Summary: Review Request: llvm37 -- Versioned LLVM 3.7
           Product: Fedora
           Version: rawhide
         Component: Package Review
          Severity: medium
          Priority: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]

Spec URL: https://nalimilan.fedorapeople.org/llvm37.spec
SRPM URL: https://nalimilan.fedorapeople.org/llvm37-3.7.1-3.fc24.src.rpm
Description: LLVM is a compiler infrastructure designed for compile-time,
link-time, runtime, and idle-time optimization of programs from
arbitrary programming languages.  The compiler infrastructure includes
mirror sets of programming tools as well as libraries with equivalent
functionality.
Fedora Account System Username: nalimilan
Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=14740294

This package is based on the llvm35 .spec file, updated to build with LLVM 3.7.
I'm going to need it soon to package Julia 0.5.0 in rawhide. Then I will retire
the llvm33 package, which will no longer have any reverse dependencies.

The package includes several patches which are needed by Julia. These have been
submitted upstream, and are often included in LLVM 3.8.1 (which doesn't work
with Julia yet). I've been using it for several months in a Copr without
issues.

[Bug 1352215] Review Request: llvm37 -- Versioned LLVM 3.7

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1352215

Milan Bouchet-Valat  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail],
                   |                            |[e-mail]
             Blocks|                            |505154 (FE-SCITECH)

--- Comment #1 from Milan Bouchet-Valat  ---
Jens, Orion: Since you've followed the review for llvm33, you're probably in
the best position to review this new one.

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=505154
[Bug 505154] Tracker: Review Requests for Science and Technology related
packages

[Bug 1352215] Review Request: llvm37 -- Versioned LLVM 3.7

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1352215

Jens Petersen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |1206852 (ghc-8.0.1)

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1206852
[Bug 1206852] ghc-8.0.1 is available

[Bug 1352215] Review Request: llvm37 -- Versioned LLVM 3.7

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1352215

--- Comment #2 from Jens Petersen  ---
I am taking a look.

[Bug 1352215] Review Request: llvm37 -- Versioned LLVM 3.7

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1352215

Jens Petersen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Alias|                            |llvm37

[Bug 1352215] Review Request: llvm37 -- Versioned LLVM 3.7

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1352215

--- Comment #3 from Milan Bouchet-Valat  ---
Thanks! As per the latest guidelines, it seems that we don't actually have to
follow the standard review process since LLVM is already packaged in Fedora:
https://fedoraproject.org/wiki/Packaging:ReviewGuidelines#Package_Review_Pro...

I'd still appreciate your comments, and of course I need somebody other than me
to validate the request.

[Bug 1352215] Review Request: llvm37 -- Versioned LLVM 3.7

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1352215

--- Comment #4 from Jason Tibbitts  ---
Yeah, I didn't see the point in reviewing something that had already been
reviewed.  Though I'm sure it could be cleaned up, there is probably utility in
keeping the specs and organization similar between versions.

[Bug 1352215] Review Request: llvm37 -- Versioned LLVM 3.7

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1352215

--- Comment #5 from Milan Bouchet-Valat  ---
I still need somebody to support my request in order to get the git repos set
up. :-)

[Bug 1352215] Review Request: llvm37 -- Versioned LLVM 3.7

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1352215

--- Comment #6 from Jason Tibbitts  ---
Sorry, what request do you need to be validated?  Have you requested your
package in the package database?  You can use this ticket as the reference.  I
can process the request, or if John does it first then he'll see this ticket.

However, it is important to note that this package is not correctly named, and
you only get the review exemption if you actually follow the naming guidelines.

The name should be "llvm3.7".  Unless it really is version thirty-seven.  See
https://fedoraproject.org/wiki/Packaging:Naming  The fact that llvm33 and
certainly other packages are doing it wrong isn't a good reason for failing to
do it correctly now.

[Bug 1352215] Review Request: llvm37 -- Versioned LLVM 3.7

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1352215

--- Comment #7 from Milan Bouchet-Valat  ---
Actually, I wanted to follow that naming convention too, but in the initial
review I was asked to use llvm33 instead. Glad to see the guidelines have been
made more explicit. I've changed it back to llvm3.7.

I've just requested the creation of a new git repo.

[Bug 1352215] Review Request: llvm3.7 -- Versioned LLVM 3.7

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1352215

Milan Bouchet-Valat  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Review Request: llvm37 --   |Review Request: llvm3.7 --
                   |Versioned LLVM 3.7          |Versioned LLVM 3.7

[Bug 1352215] Review Request: llvm3.7 -- Versioned LLVM 3.7

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1352215

Milan Bouchet-Valat  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Alias|                            |llvm3.7

[Bug 1352215] Review Request: llvm3.7 -- Versioned LLVM 3.7

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1352215

--- Comment #8 from Jason Tibbitts  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/llvm3.7

[Bug 1352215] Review Request: llvm3.7 -- Versioned LLVM 3.7

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1352215

--- Comment #9 from Fedora Update System  ---
llvm3.7-3.7.1-3.fc25 has been submitted as an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-a012749321

[Bug 1352215] Review Request: llvm3.7 -- Versioned LLVM 3.7

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1352215

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |MODIFIED

[Bug 1352215] Review Request: llvm3.7 -- Versioned LLVM 3.7

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1352215

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|MODIFIED                    |ON_QA

--- Comment #10 from Fedora Update System  ---
llvm3.7-3.7.1-3.fc25 has been pushed to the Fedora 25 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-a012749321

[Bug 1352215] Review Request: llvm3.7 -- Versioned LLVM 3.7

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1352215

--- Comment #11 from Fedora Update System  ---
llvm3.7-3.7.1-3.fc25 has been pushed to the Fedora 25 stable repository. If
problems still persist, please make note of it in this bug report.

[Bug 1352215] Review Request: llvm3.7 -- Versioned LLVM 3.7

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1352215

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ON_QA                       |CLOSED
         Resolution|---                         |ERRATA
        Last Closed|                            |2016-08-27 06:14:49

[Bug 1352215] Review Request: llvm3.7 -- Versioned LLVM 3.7

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1352215

--- Comment #12 from Jens Petersen  ---
Thank you!

How about building for F24 too?

[Bug 1352215] Review Request: llvm3.7 -- Versioned LLVM 3.7

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1352215

--- Comment #13 from Milan Bouchet-Valat  ---
Do you need it there? If so, I can backport it of course.

[Bug 1352215] Review Request: llvm3.7 -- Versioned LLVM 3.7

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1352215

--- Comment #14 from Orion Poplawski  ---
Milan - could you build this for EPEL7 too?

[Bug 1352215] Review Request: llvm3.7 -- Versioned LLVM 3.7

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1352215

--- Comment #15 from Orion Poplawski  ---
Hmm, maybe hold of a bit.  I'm trying to use it to compile pocl, but not having
luck yet.

[Bug 1352215] Review Request: llvm3.7 -- Versioned LLVM 3.7

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1352215

--- Comment #16 from Jens Petersen  ---
(Works great for me with ghc-8.0 FWIW.)

[Bug 1352215] Review Request: llvm3.7 -- Versioned LLVM 3.7

https://bugzilla.redhat.com/show_bug.cgi?id=1352215

Susi Lehtola  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|505154 (FE-SCITECH)         |

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=505154
[Bug 505154] Tracker: Review Requests for Science and Technology related
packages

[Bug 1352215] Review Request: llvm3.7 -- Versioned LLVM 3.7

https://bugzilla.redhat.com/show_bug.cgi?id=1352215

--- Comment #17 from Milan Bouchet-Valat  ---
Jens: I was going to orphan llvm3.7 since Julia now uses llvm3.9, then I
realized ghc depends on it on F26 (I had only checked F25...), so I reverted
the change. But llvm3.7 still fails according to Koschei, so you may want to
have a look before it's a problem for ghc.

[Bug 1352215] Review Request: llvm3.7 -- Versioned LLVM 3.7

https://bugzilla.redhat.com/show_bug.cgi?id=1352215

--- Comment #18 from Milan Bouchet-Valat  ---
I've just orphaned llvm3.7 on F28 and rawhide since builds have started to fail
and ghc no longer uses it.

[Bug 1352215] Review Request: llvm3.7 -- Versioned LLVM 3.7

https://bugzilla.redhat.com/show_bug.cgi?id=1352215

--- Comment #19 from Jens Petersen  ---
Okay, f27 ghc uses llvm3.7