Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=211718
Summary: Review Request: thewidgetfactory - A tool for previewing widgets Product: Fedora Extras Version: devel Platform: All OS/Version: Linux Status: NEW Severity: normal Priority: normal Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: luya_tfz@thefinalzone.com QAContact: fedora-package-review@redhat.com
Spec URL: http://www.thefinalzone.com/RPMS/thewidgetfactory.spec SRPM URL: http://www.thefinalzone.com/RPMS/thewidgetfactory-0.2.1-1.x86_64.rpm Description: The Widget Factory is a program designed to show a wide range of widgets on a single window.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: thewidgetfactory - A tool for previewing widgets Alias: thewidgetfactory
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=211718
luya_tfz@thefinalzone.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Alias| |thewidgetfactory
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: thewidgetfactory - A tool for previewing widgets Alias: thewidgetfactory
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=211718
------- Additional Comments From rc040203@freenet.de 2006-10-21 00:13 EST ------- (In reply to comment #0)
SRPM URL: http://www.thefinalzone.com/RPMS/thewidgetfactory-0.2.1-1.x86_64.rpm
SRPM?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: thewidgetfactory - A tool for previewing widgets Alias: thewidgetfactory
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=211718
------- Additional Comments From luya_tfz@thefinalzone.com 2006-10-21 00:50 EST ------- Whoops. Here is the SRPM http://www.thefinalzone.com/RPMS/thewidgetfactory-0.2.1-1.src.rpm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: thewidgetfactory - A tool for previewing widgets Alias: thewidgetfactory
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=211718
peter@thecodergeek.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@fedoraproject.org |peter@thecodergeek.com OtherBugsDependingO|163776 |163778 nThis| |
------- Additional Comments From peter@thecodergeek.com 2006-10-21 03:14 EST ------- A brief comment before I start a formal review of this: Your %files section contains %{_bindir}, which means that the package will own /usr/bin (or whatever directory it expands to for the user's RPM macros). It should only own the specific binaries it provides. %{_bindir} and other system directories are owned by the fileystem package, and this is a Very Bad Thing(TM). (See http://fedoraproject.org/wiki/Packaging/Guidelines#head-a5931a7372c4a0006571... for more information.)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: thewidgetfactory - A tool for previewing widgets Alias: thewidgetfactory
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=211718
peter@thecodergeek.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NOTABUG
------- Additional Comments From peter@thecodergeek.com 2006-10-21 04:21 EST ------- Hi, Luya. Ok, here we go. :)
** MUST items **
GOOD: rpmlint on the source RPM is silent The binary RPM gives one error: E: thewidgetfactory standard-dir-owned-by-package /usr/bin See the Blockers section below for more information.
GOOD: Timestamps in the source appear to be preserved.
GOOD: Package complies with the NamingGuidelines
GOOD: The spec file is named appropriately, in the form "%{name}.spec"
GOOD: License is open-source compatible (GPL), and the License field in the spec file correctly notes this.
GOOD: A copy of the license is included in the package (COPYING, in %doc)
GOOD: The spec is written in American English, and is clear and legible.
GOOD: The source tarball included in the SRPM matches that of upstream. $ md5sum thewidgetfactory-*.tar.gz 60175721233c6f265326fcdc0334c269 thewidgetfactory-0.2.1-srpm.tar.gz 60175721233c6f265326fcdc0334c269 thewidgetfactory-0.2.1-upstream.tar.gz
GOOD: The package successfully builds in mock (FC6/x86)
GOOD: All necessary BuildRequires listed. (Probably a bit simpler than many other packages, since there is only one. ^_^)
GOOD: No duplicate files listed in %files.
GOOD: The spec contains a %clean section, which invokes a single "rm -rf $RPM_BUILD_ROOT" command.
GOOD: Usage of macros in the spec is consistent.
GOOD: The package contains code, and no prohibited content.
GOOD: Files marked as %doc do not affect the program at runtime if not present.
GOOD: Package contains no .la libtool archives.
** SHOULD items **
GOOD: A copy of the license (GPL) is included in the tarball from upstream ("COPYING").
GOOD: The package appears to build properly on all supported architectures that I was able to test (built in an FC6/x86 Mock chroot, and is currently chugging through an FC5/x86 Mock build, which I expect to succeed).
GOOD: The software contained in the binary package runs as described, with no noticable errors (FC6/x86).
** Not Applicable ** N/A: The package does not require ExcludeArch semantics.
N/A: The package does not require %find_lang semantics, since it installs no locales.
N/A: The package does not require %post/%postun calls to /sbin/ldconfig, since it installs no shared libraries.
N/A: Package is not relocatable.
N/A: There is no large documentation, so a -doc subpackage is not needed.
N/A: No header files, shared or static library files, so no -devel subpackage is needed.
N/A: The package contains no pkgconfig (.pc) files.
N/A: The package does not use translations, so no translated %description or Summary tag is available.
N/A: No scriplets are used.
N/A: No subpackages exist, so worries about fully-versioned Requires for those are not present.
** Blockers **
BAD: The application includes a GUI interface, but no .desktop file for that application. (See http://fedoraproject.org/wiki/Packaging/Guidelines#desktop on the wiki for more information.) If the source from upstream does not have one, as it seems for this package, please create one yourself and include it as a separate Source in the RPM. (Remember, then, to add the desktop-file-install scriptlet to the %install section of the spec file, and add desktop-file-utils as a BuildRequires for this script call. Also, you'll need to add the generated .desktop file to your %files listing.)
BAD: The package should not own %{_bindir}, which is owned by the filesystem package. Unless there is good reason for such ownership to be shared, this should be changed in the %files to only list the specific binary within that directory (such as "%{_bindir}/twf").
--
Those are the only two blockers I can see in this. Fix those, and I'll approve the package for importing into CVS.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: thewidgetfactory - A tool for previewing widgets Alias: thewidgetfactory
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=211718
peter@thecodergeek.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|CLOSED |NEW Keywords| |Reopened Resolution|NOTABUG |
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: thewidgetfactory - A tool for previewing widgets Alias: thewidgetfactory
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=211718
peter@thecodergeek.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED
------- Additional Comments From peter@thecodergeek.com 2006-10-21 04:24 EST ------- Er..didn't mean to close the bug....
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: thewidgetfactory - A tool for previewing widgets Alias: thewidgetfactory
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=211718
------- Additional Comments From luya_tfz@thefinalzone.com 2006-10-21 19:40 EST ------- Thank you for this excellent reviewing. I have updated these following files:
Spec URL: http://www.thefinalzone.com/RPMS/thewidgetfactory.spec SRPM URL: http://www.thefinalzone.com/RPMS/thewidgetfactory-0.2.1-2.x86_64.rpm
Upstream does not have a icon for the desktop file, I have to comment out the Icon part.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: thewidgetfactory - A tool for previewing widgets Alias: thewidgetfactory
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=211718
peter@thecodergeek.com changed:
What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO|163778 |163779 nThis| |
------- Additional Comments From peter@thecodergeek.com 2006-10-21 21:18 EST ------- The %{_bindir} ownership has been fixed; and the .desktop stuff looks good. Nice work.
The only other issue I can see is that you might want to use the %{name} macro as part of the Source1 tag instead of hardcoding it, but that's entirely personal preference as I understand it, and certainly not a blocker.
This package is therefore APPROVED. Go ahead and import it into CVS and request branches as needed, etc.
Don't forget to close this bug as NEXTRELEASE after you import and build it.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: thewidgetfactory - A tool for previewing widgets Alias: thewidgetfactory
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=211718
peter@thecodergeek.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords|Reopened | Component|Package Review |915resolution
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: thewidgetfactory - A tool for previewing widgets Alias: thewidgetfactory
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=211718
peter@thecodergeek.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Component|915resolution |Package Review
------- Additional Comments From peter@thecodergeek.com 2006-10-21 21:22 EST ------- (Er. How the heck did that change from Package Review to 915resolution? Sorry about that one...)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: thewidgetfactory - A tool for previewing widgets Alias: thewidgetfactory
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=211718
------- Additional Comments From luya_tfz@thefinalzone.com 2006-10-21 21:34 EST ------- It looks like a problem related to bugzilla.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: thewidgetfactory - A tool for previewing widgets Alias: thewidgetfactory
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=211718
luya_tfz@thefinalzone.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: thewidgetfactory - A tool for previewing widgets Alias: thewidgetfactory
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=211718
bugzilla@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |medium Priority|normal |medium Product|Fedora Extras |Fedora
mtasaka@ioa.s.u-tokyo.ac.jp changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |cheese@nosuchhost.net
------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2007-07-27 13:57 EST ------- *** Bug 249595 has been marked as a duplicate of this bug. ***
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: thewidgetfactory - A tool for previewing widgets Alias: thewidgetfactory
https://bugzilla.redhat.com/show_bug.cgi?id=211718
bugzilla@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Version|devel |rawhide
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=211718
Luya Tshimbalanga luya@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |luya@fedoraproject.org Flag| |fedora-cvs?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=211718
Dennis Gilmore dennis@ausil.us changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |
--- Comment #11 from Dennis Gilmore dennis@ausil.us 2009-04-01 12:29:24 EDT --- unsetting cvs flag. please reset with a cvs request if you have one.
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla