[Bug 1315021] New: Review Request: openvibe - A software platform for brain-computer interfaces

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1315021

Bug ID: 1315021
           Summary: Review Request: openvibe - A software platform for
                    brain-computer interfaces
           Product: Fedora
           Version: rawhide
         Component: Package Review
          Severity: medium
          Priority: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]

Spec URL:
http://copr-dist-git.fedorainfracloud.org/cgit/bizdelnick/neuro/openvibe.git...
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/bizdelnick/neuro/fedora-rawh...
Description: OpenViBE is a software for real-time neurosciences (that is, for
real-time processing of brain signals). It can be used to acquire, filter,
process, classify and visualize brain signals in real time.
Fedora Account System Username: bizdelnick

[Bug 1315021] Review Request: openvibe - A software platform for brain-computer interfaces

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1315021

Dmitry Mikhirev  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |1276941 (fedora-neuro)
              Alias|                            |openvibe

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1276941
[Bug 1276941] Fedora NeuroImaging and NeuroScience tracking bug

[Bug 1315021] Review Request: openvibe - A software platform for brain-computer interfaces

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1315021

Zbigniew Jędrzejewski-Szmek  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
         Depends On|                            |1311752 (vrpn)

--- Comment #1 from Zbigniew Jędrzejewski-Szmek  ---
Can you make vrpn mandatory? I'll review vrpn, and conditionals make everything
more complicated.

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1311752
[Bug 1311752] Review Request: vrpn -The Virtual Reality Peripheral Network

[Bug 1315021] Review Request: openvibe - A software platform for brain-computer interfaces

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1315021

--- Comment #2 from Dmitry Mikhirev  ---
Sure, I'll make it mandatory after vrpn will be approved. Or should I do this
right now?

[Bug 1315021] Review Request: openvibe - A software platform for brain-computer interfaces

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1315021

--- Comment #3 from Zbigniew Jędrzejewski-Szmek  ---
Right now. Unless you think there's some reason to think that vrpn might not be
approved. Looks like a well done package, so I wouldn't think so.

[Bug 1315021] Review Request: openvibe - A software platform for brain-computer interfaces

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1315021

--- Comment #4 from Dmitry Mikhirev  ---
Done.

Spec URL:
http://copr-dist-git.fedorainfracloud.org/cgit/bizdelnick/neuro/openvibe.git...
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/bizdelnick/neuro/fedora-rawh...

[Bug 1315021] Review Request: openvibe - A software platform for brain-computer interfaces

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1315021

Zbigniew Jędrzejewski-Szmek  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|[e-mail]    |[e-mail]
              Flags|                            |fedora-review?

--- Comment #5 from Zbigniew Jędrzejewski-Szmek  ---
Change python-devel to python2-devel, or maybe python3-devel? Would it work
with python3?

There should be an appdata file
[https://fedoraproject.org/wiki/Packaging:AppData].

Note: if you package for F23- (F24+ is fine as is), you'll need to add
scriptlets for the desktop files
[https://fedoraproject.org/wiki/Packaging:Scriptlets?rd=Packaging:ScriptletSn...].

[Bug 1315021] Review Request: openvibe - A software platform for brain-computer interfaces

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1315021

--- Comment #6 from Dmitry Mikhirev  ---
> Change python-devel to python2-devel, or maybe python3-devel? Would it work with python3?

It wants python 2.7 only. Changed to python2-devel.
> Note: if you package for F23- (F24+ is fine as is), you'll need to add scriptlets for the desktop files

Added.
> There should be an appdata file

Well, "should" is not "must", right? ☺

Spec URL:
http://copr-dist-git.fedorainfracloud.org/cgit/bizdelnick/neuro/openvibe.git...
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/bizdelnick/neuro/fedora-rawh...

[Bug 1315021] Review Request: openvibe - A software platform for brain-computer interfaces

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1315021

--- Comment #7 from Zbigniew Jędrzejewski-Szmek  ---
It's "SHOULD" not "should" ;) It means "must unless there's a good reason not
to".

[Bug 1315021] Review Request: openvibe - A software platform for brain-computer interfaces

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1315021

--- Comment #8 from Dmitry Mikhirev  ---
Is not XML a good enough reason? Okay...

Spec URL:
http://copr-dist-git.fedorainfracloud.org/cgit/bizdelnick/neuro/openvibe.git...
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/bizdelnick/neuro/fedora-rawh...

[Bug 1315021] Review Request: openvibe - A software platform for brain-computer interfaces

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1315021

--- Comment #9 from Zbigniew Jędrzejewski-Szmek  ---
Please always link to the raw spec file for fedora-review's sake.

+ latest version
+ license is acceptable (AGPLv3)
+ license file is present, %license is used
+ scriptlets look OK
- provides/requires are not OK (see below)
+ builds and installs OK

No %check (apart from the desktop files and appdata) :(
Use appstream-util validate-relax --nonet, otherwise it fails in mock.

Installation fails with:
nothing provides libquat.so.07()(64bit) needed by openvibe-1.1.0-1.fc25.x86_64.

[Bug 1315021] Review Request: openvibe - A software platform for brain-computer interfaces

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1315021

--- Comment #10 from Dmitry Mikhirev  ---
> Please always link to the raw spec file for fedora-review's sake.

I'm sorry.
> No %check (apart from the desktop files and appdata) :(

I did not add running tests because they require X server connection. I
supposed that there should be a workaround, but I found the page
https://fedoraproject.org/wiki/PackageMaintainers/GraphicalTests only after
submitting this review request. So I can try to enable tests now.
> Use appstream-util validate-relax --nonet, otherwise it fails in mock.

OK.
> Installation fails with:
> nothing provides libquat.so.07()(64bit) needed by openvibe-1.1.0-1.fc25.x86_64.

Right, it is provided by vrpn package.

[Bug 1315021] Review Request: openvibe - A software platform for brain-computer interfaces

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1315021

Zbigniew Jędrzejewski-Szmek  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |POST
              Flags|fedora-review?              |fedora-review+

--- Comment #11 from Zbigniew Jędrzejewski-Szmek  ---
(In reply to Dmitry Mikhirev from comment #10)
> > Please always link to the raw spec file for fedora-review's sake.
>
> I'm sorry.

Not a big problem, just an additional step.
> > No %check (apart from the desktop files and appdata) :(
>
> I did not add running tests because they require X server connection. I
> supposed that there should be a workaround, but I found the page
> https://fedoraproject.org/wiki/PackageMaintainers/GraphicalTests only after
> submitting this review request. So I can try to enable tests now.

I think it's useful. At least checking if the binaries actually run
can be useful:
$ /usr/bin/openvibe-external-application-launcher
/usr/bin/openvibe-external-application-launcher: line 24: /usr/bin/: Is a
directory

It seems that something is wrong here.
> > Installation fails with:
> > nothing provides libquat.so.07()(64bit) needed by openvibe-1.1.0-1.fc25.x86_64.
>
> Right, it is provided by vrpn package.

Oh, OK. I didn't notice that. With vrpn installed everything installs fine.

Package is APPROVED.

[Bug 1315021] Review Request: openvibe - A software platform for brain-computer interfaces

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1315021

--- Comment #12 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/openvibe

[Bug 1315021] Review Request: openvibe - A software platform for brain-computer interfaces

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1315021

Sat6QE Jenkins  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|POST                        |MODIFIED

[Bug 1315021] Review Request: openvibe - A software platform for brain-computer interfaces

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1315021

Mike McCune  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|MODIFIED                    |POST

--- Comment #13 from Mike McCune  ---
This bug was accidentally moved from POST to MODIFIED via an error in
automation, please see [e-mail] with any questions

[Bug 1315021] Review Request: openvibe - A software platform for brain-computer interfaces

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1315021
Bug 1315021 depends on bug 1311752, which changed state.

Bug 1311752 Summary: Review Request: vrpn -The Virtual Reality Peripheral Network
https://bugzilla.redhat.com/show_bug.cgi?id=1311752

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|POST                        |CLOSED
         Resolution|---                         |CURRENTRELEASE

[Bug 1315021] Review Request: openvibe - A software platform for brain-computer interfaces

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1315021

Dmitry Mikhirev  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|POST                        |CLOSED
         Resolution|---                         |RAWHIDE
        Last Closed|                            |2016-04-03 16:50:09