[Bug 2109939] New: Review Request: mitmproxy - Interactive SSL-capable intercepting HTTP proxy

https://bugzilla.redhat.com/show_bug.cgi?id=2109939

Bug ID: 2109939
           Summary: Review Request: mitmproxy - Interactive SSL-capable
                    intercepting HTTP proxy
           Product: Fedora
           Version: rawhide
          Hardware: All
                OS: Linux
            Status: NEW
         Component: Package Review
          Severity: medium
          Priority: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]
  Target Milestone: ---
    Classification: Fedora

Spec URL: https://rathann.fedorapeople.org/review/mitmproxy/mitmproxy.spec
SRPM URL:
https://rathann.fedorapeople.org/review/mitmproxy/mitmproxy-8.1.1-1.fc36.src...
Description:
mitmproxy is an interactive, SSL-capable man-in-the-middle proxy for HTTP with
a console interface.

mitmdump is the command-line version of mitmproxy. Think tcpdump for HTTP.

libmproxy is the library that mitmproxy and mitmdump are built on.

Fedora Account System Username: rathann

Previous attempt by Fabian Affolter: bug 1198760.

[Bug 2109939] Review Request: mitmproxy - Interactive SSL-capable intercepting HTTP proxy

https://bugzilla.redhat.com/show_bug.cgi?id=2109939

Petr Menšík  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Doc Type|---                         |If docs needed, set a value
              Flags|                            |needinfo?(dominik@greysecto
                   |                            |r.net)
                 CC|                            |[e-mail]

--- Comment #1 from Petr Menšík  ---
The current spec failed to build to me when trying fedora-review -b 2109939. I
admit I have trouble finding what exactly is reponsible for the failure.

I think the package should Provides: python3-%{name}, as recommended by python
guidelines.

I think the main issue reported in root.log:

DEBUG util.py:443:  Error: 
DEBUG util.py:443:   Problem 1: nothing provides requested
(python3dist(blinker) < 1.5~~ with python3dist(blinker) >= 1.4)
DEBUG util.py:443:   Problem 2: nothing provides requested (python3dist(flask)
< 2.2~~ with python3dist(flask) >= 1.1.1)
DEBUG util.py:443:   Problem 3: nothing provides requested
(python3dist(wsproto) < 1.2~~ with python3dist(wsproto) >= 1)
DEBUG util.py:443:   Problem 4: nothing provides requested
(python3dist(zstandard) < 0.19~~ with python3dist(zstandard) >= 0.11)
DEBUG util.py:445:  (try to add '--skip-broken' to skip uninstallable packages
or '--nobest' to use not only best candidate packages)
DEBUG util.py:596:  Child return code was: 1

Please fix dependencies to build on current rawhide. It seems adjustment to
newer versions is required.

python3-blinker-0:1.5-1.fc37.noarch
python3-flask-1:2.2.2-1.fc37.noarch
python3-wsproto-0:1.2.0-1.fc38.noarch
python3-zstandard-0:0.19.0-1.fc38.x86_64

[Bug 2109939] Review Request: mitmproxy - Interactive SSL-capable intercepting HTTP proxy

https://bugzilla.redhat.com/show_bug.cgi?id=2109939

--- Comment #2 from Petr Menšík  ---
Created attachment 1939023
  --> https://bugzilla.redhat.com/attachment.cgi?id=1939023&action=edit
root.log

[Bug 2109939] Review Request: mitmproxy - Interactive SSL-capable intercepting HTTP proxy

https://bugzilla.redhat.com/show_bug.cgi?id=2109939

--- Comment #3 from Petr Menšík  ---
Created attachment 1939024
  --> https://bugzilla.redhat.com/attachment.cgi?id=1939024&action=edit
build.log

[Bug 2109939] Review Request: mitmproxy - Interactive SSL-capable intercepting HTTP proxy

https://bugzilla.redhat.com/show_bug.cgi?id=2109939

Dominik 'Rathann' Mierzejewski  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends On|                            |2048162

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=2048162
[Bug 2048162] pyOpenSSL-23.0.0 is available

[Bug 2109939] Review Request: mitmproxy - Interactive SSL-capable intercepting HTTP proxy

https://bugzilla.redhat.com/show_bug.cgi?id=2109939

Dominik 'Rathann' Mierzejewski  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|needinfo?(dominik@greysecto |
                   |r.net)                      |

--- Comment #4 from Dominik 'Rathann' Mierzejewski  ---
Spec URL: https://rathann.fedorapeople.org/review/mitmproxy/mitmproxy.spec
SRPM URL:
https://rathann.fedorapeople.org/review/mitmproxy/mitmproxy-8.1.1-2.fc37.src...

* Fri Jan 20 2023 Dominik Mierzejewski  - 8.1.1-2
- relax deps versions requirements to fix build on rawhide
- fix tests

NOTE: I can't update to 9.0.x because some dependencies are too old in Fedora
rawhide, in particular pyOpenSSL 22.1 is required.

[Bug 2109939] Review Request: mitmproxy - Interactive SSL-capable intercepting HTTP proxy

https://bugzilla.redhat.com/show_bug.cgi?id=2109939

Fabio Valentini  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #5 from Fabio Valentini  ---
If you need help with packaging mitmproxy_wireguard (a new dependency of
mitmproxy 9), let me know. I'm the upstream developer. :)

[Bug 2109939] Review Request: mitmproxy - Interactive SSL-capable intercepting HTTP proxy

https://bugzilla.redhat.com/show_bug.cgi?id=2109939

--- Comment #6 from Jakub Kadlčík  ---
Copr build:
https://copr.fedorainfracloud.org/coprs/build/5278069
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

[Bug 2109939] Review Request: mitmproxy - Interactive SSL-capable intercepting HTTP proxy

https://bugzilla.redhat.com/show_bug.cgi?id=2109939
Bug 2109939 depends on bug 2048162, which changed state.

Bug 2048162 Summary: pyOpenSSL-23.0.0 is available
https://bugzilla.redhat.com/show_bug.cgi?id=2048162

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|MODIFIED                    |CLOSED
         Resolution|---                         |ERRATA

[Bug 2109939] Review Request: mitmproxy - Interactive SSL-capable intercepting HTTP proxy

https://bugzilla.redhat.com/show_bug.cgi?id=2109939

--- Comment #7 from Petr Menšík  ---
It seems once again the package is no longer buildable as it is. Review failed
to build it with:

Finish: rpmbuild mitmproxy-8.1.1-2.fc37.src.rpm
Finish: build phase for mitmproxy-8.1.1-2.fc37.src.rpm
ERROR:
Exception(/home/pemensik/fedora/rawhide/2109939-mitmproxy/srpm/mitmproxy-8.1.1-2.fc37.src.rpm)
Config(fedora-rawhide-x86_64) 0 minutes 34 seconds
INFO: Results and/or logs in:
/home/pemensik/fedora/rawhide/2109939-mitmproxy/results
ERROR: Command failed: 
 # /usr/bin/systemd-nspawn -q -M 9f7bca7d9a74444185960059c1203d86 -D
/var/lib/mock/fedora-rawhide-x86_64-bootstrap/root -a --capability=cap_ipc_lock
--bind=/tmp/mock-resolv.fxon_rzx:/etc/resolv.conf --console=pipe
--setenv=TERM=vt100 --setenv=SHELL=/bin/bash
--setenv=HOME=/var/lib/mock/fedora-rawhide-x86_64/root/installation-homedir
--setenv=HOSTNAME=mock --setenv=PATH=/usr/bin:/bin:/usr/sbin:/sbin
--setenv=PROMPT_COMMAND=printf "\033]0;<mock-chroot>\007"
--setenv=PS1=<mock-chroot> \s-\v$  --setenv=LANG=C.UTF-8
--setenv=LC_MESSAGES=C.UTF-8 --resolv-conf=off /usr/bin/dnf-3 builddep
--installroot /var/lib/mock/fedora-rawhide-x86_64/root/ --releasever 40
--setopt=deltarpm=False --setopt=allow_vendor_change=yes --allowerasing
--disableplugin=local --disableplugin=spacewalk --disableplugin=versionlock
/var/lib/mock/fedora-rawhide-x86_64/root/builddir/build/SRPMS/mitmproxy-8.1.1-2.fc40.buildreqs.nosrc.rpm
--setopt=tsflags=nocontexts
No matches found for the following disable plugin patterns: local, spacewalk,
versionlock
fedora                                           67 kB/s | 8.2 kB     00:00    
Package python3-sortedcontainers-2.4.0-13.fc39.noarch is already installed.
Package glibc-langpack-en-2.38.9000-12.fc40.x86_64 is already installed.
Package pyproject-rpm-macros-1.10.0-1.fc40.noarch is already installed.
Package python3-devel-3.12.0-1.fc40.x86_64 is already installed.
Package python3-devel-3.12.0-1.fc40.x86_64 is already installed.
Package python3-setuptools-68.2.2-1.fc40.noarch is already installed.
Package python3-hypothesis-6.82.0-2.fc40.noarch is already installed.
Package python3-packaging-23.1-5.fc40.noarch is already installed.
Package python3-parver-0.4-1.fc40.noarch is already installed.
Package python3-pip-23.2.1-1.fc39.noarch is already installed.
Package python3-pytest-7.4.2-1.fc40.noarch is already installed.
Package python3-pytest-asyncio-0.21.0-5.fc39.noarch is already installed.
Package python3-pytest-xdist-3.3.1-3.fc39.noarch is already installed.
Package python3-setuptools-68.2.2-1.fc40.noarch is already installed.
Package python3-wheel-1:0.40.0-4.fc39.noarch is already installed.
Error: 
 Problem 1: nothing provides requested (python3dist(asgiref) < 3.6~~ with
python3dist(asgiref) >= 3.2.10)
 Problem 2: nothing provides requested (python3dist(blinker) < 1.6~~ with
python3dist(blinker) >= 1.4)
 Problem 3: nothing provides requested (python3dist(brotli) < 1.1~~ with
python3dist(brotli) >= 1)
 Problem 4: nothing provides requested (python3dist(cryptography) < 38~~ with
python3dist(cryptography) >= 36)
 Problem 5: nothing provides requested (python3dist(h11) < 0.14~~ with
python3dist(h11) >= 0.11)
 Problem 6: nothing provides requested (python3dist(pyopenssl) < 22.1~~ with
python3dist(pyopenssl) >= 21)
 Problem 7: nothing provides requested (python3dist(urwid) < 2.2~~ with
python3dist(urwid) >= 2.1.1)
 Problem 8: nothing provides requested (python3dist(zstandard) < 0.20~~ with
python3dist(zstandard) >= 0.11)
(try to add '--skip-broken' to skip uninstallable packages or '--nobest' to use
not only best candidate packages)

I expect another version rebase might fix it. At least
python3-pyOpenSSL-0:23.2.0-1.fc40.noarch is now in rawhide. But it seems moving
quite fast a breaking dependencies often.

needinfo canceled: [Bug 2109939] Review Request: mitmproxy - Interactive SSL-capable intercepting HTTP proxy

Product: Fedora
Version: rawhide
Component: Package Review

Dominik 'Rathann' Mierzejewski  has canceled Package
Review 's request for Dominik 'Rathann'
Mierzejewski 's needinfo:
Bug 2109939: Review Request: mitmproxy - Interactive SSL-capable intercepting
HTTP proxy
https://bugzilla.redhat.com/show_bug.cgi?id=2109939

--- Comment #9 from Dominik 'Rathann' Mierzejewski  ---
I'm still interested in packaging this. I'll post a new working SRPM soon.

[Bug 2109939] Review Request: mitmproxy - Interactive SSL-capable intercepting HTTP proxy

https://bugzilla.redhat.com/show_bug.cgi?id=2109939

Dominik 'Rathann' Mierzejewski  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|needinfo?(dominik@greysecto |
                   |r.net)                      |

--- Comment #9 from Dominik 'Rathann' Mierzejewski  ---
I'm still interested in packaging this. I'll post a new working SRPM soon.

[Bug 2109939] Review Request: mitmproxy - Interactive SSL-capable intercepting HTTP proxy

https://bugzilla.redhat.com/show_bug.cgi?id=2109939

Dominik 'Rathann' Mierzejewski  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|needinfo?(dominik@greysecto |
                   |r.net)                      |

--- Comment #11 from Dominik 'Rathann' Mierzejewski  ---
Yep, still interested.

needinfo canceled: [Bug 2109939] Review Request: mitmproxy - Interactive SSL-capable intercepting HTTP proxy

Product: Fedora
Version: rawhide
Component: Package Review

Dominik 'Rathann' Mierzejewski  has canceled Package
Review 's request for Dominik 'Rathann'
Mierzejewski 's needinfo:
Bug 2109939: Review Request: mitmproxy - Interactive SSL-capable intercepting
HTTP proxy
https://bugzilla.redhat.com/show_bug.cgi?id=2109939

--- Comment #11 from Dominik 'Rathann' Mierzejewski 
---
Yep, still interested.