[Bug 2167067] New: Review Request: python-uswid - Python module for working with Firmware SBoMs

https://bugzilla.redhat.com/show_bug.cgi?id=2167067

Bug ID: 2167067
           Summary: Review Request: python-uswid - Python module for
                    working with Firmware SBoMs
           Product: Fedora
           Version: rawhide
          Hardware: All
                OS: Linux
            Status: NEW
         Component: Package Review
          Severity: medium
          Priority: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]
  Target Milestone: ---
    Classification: Fedora

Spec URL: https://people.freedesktop.org/~hughsient/temp/python-uswid.spec
SRPM URL:
https://people.freedesktop.org/~hughsient/temp/python-uswid-0.4.1-1.fc37.src...
KOJI URL: https://koji.fedoraproject.org/koji/taskinfo?taskID=97087821
Description:

Software Identification (SWID) tags provide an extensible XML-based structure
to
identify and describe individual software components, patches, and installation
bundles. XML SWID tag representations can be too large for devices with network
and storage constraints.

Fedora Account System Username: rhughes

[Bug 2167067] Review Request: python-uswid - Python module for working with Firmware SBoMs

https://bugzilla.redhat.com/show_bug.cgi?id=2167067

--- Comment #1 from Richard Hughes  ---
rpmlint output:

python-uswid.spec:44: W: macro-in-comment %{python3}

[Bug 2167067] Review Request: python-uswid - Python module for working with Firmware SBoMs

https://bugzilla.redhat.com/show_bug.cgi?id=2167067

--- Comment #2 from Jakub Kadlčík  ---
Copr build:
https://copr.fedorainfracloud.org/coprs/build/5447736
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

[Bug 2167067] Review Request: python-uswid - Python module for working with Firmware SBoMs

https://bugzilla.redhat.com/show_bug.cgi?id=2167067

--- Comment #3 from Richard Hughes  ---
[!]: Reviewer should test that the package builds in mock.
[!]: Sources can be downloaded from URI in Source: tag
     Note: Could not download Source0:
     https://files.pythonhosted.org/packages/source/u/uswid/uswid-0.4.1.tar.gz
     See: https://docs.fedoraproject.org/en-US/packaging-
     guidelines/SourceURL/

Blah! I've made sure the source archive exists now -- sorry about that.

[Bug 2167067] Review Request: python-uswid - Python module for working with Firmware SBoMs

https://bugzilla.redhat.com/show_bug.cgi?id=2167067

Neal Gompa  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|[e-mail]    |[e-mail]
             Status|NEW                         |POST
                 CC|                            |[e-mail]
              Flags|                            |fedora-review+

--- Comment #4 from Neal Gompa  ---
Review notes:

* Package is named appropriately
* Package follows Fedora Python packaging guidelines
* Package builds and installs
* No serious issues from rpmlint

Looks good to me, so...

PACKAGE APPROVED.

[Bug 2167067] Review Request: python-uswid - Python module for working with Firmware SBoMs

https://bugzilla.redhat.com/show_bug.cgi?id=2167067

--- Comment #5 from Fedora Admin user for bugzilla script actions  ---
The Pagure repository was created at
https://src.fedoraproject.org/rpms/python-uswid

[Bug 2167067] Review Request: python-uswid - Python module for working with Firmware SBoMs

https://bugzilla.redhat.com/show_bug.cgi?id=2167067

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|POST                        |MODIFIED

--- Comment #6 from Fedora Update System  ---
FEDORA-2023-05712b14de has been submitted as an update to Fedora 38.
https://bodhi.fedoraproject.org/updates/FEDORA-2023-05712b14de

[Bug 2167067] Review Request: python-uswid - Python module for working with Firmware SBoMs

https://bugzilla.redhat.com/show_bug.cgi?id=2167067

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|MODIFIED                    |CLOSED
         Resolution|---                         |ERRATA
        Last Closed|                            |2023-02-04 15:42:19

--- Comment #7 from Fedora Update System  ---
FEDORA-2023-05712b14de has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.

[Bug 2167067] Review Request: python-uswid - Python module for working with Firmware SBoMs

https://bugzilla.redhat.com/show_bug.cgi?id=2167067

--- Comment #8 from Richard Hughes  ---
Thanks again Neal, much appreciated for the speedy review.