[Bug 2293880] New: Review Request: golang-cloud-google-auth - Google Cloud Client Libraries for Go for module auth
https://bugzilla.redhat.com/show_bug.cgi?id=2293880
Bug ID: 2293880 Summary: Review Request: golang-cloud-google-auth - Google Cloud Client Libraries for Go for module auth Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nobody@fedoraproject.org Reporter: zebob.m@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://eclipseo.fedorapeople.org/for-review/golang-cloud-google-auth.spec SRPM URL: https://eclipseo.fedorapeople.org/for-review/golang-cloud-google-auth-0.5.1-...
Description: Google Cloud Client Libraries for Go for module auth.
Fedora Account System Username: eclipseo
https://bugzilla.redhat.com/show_bug.cgi?id=2293880
Robert-André Mauchin 🐧 zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Doc Type|--- |If docs needed, set a value
--- Comment #1 from Robert-André Mauchin 🐧 zebob.m@gmail.com --- Copr build: https://copr.fedorainfracloud.org/coprs/eclipseo/gotests/build/7656593/ (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/eclipseo/gotests/fedora-r...
Please take a look if any issues were found.
https://bugzilla.redhat.com/show_bug.cgi?id=2293880
--- Comment #2 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/7656948 (failed)
Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please make sure the package builds successfully at least for Fedora Rawhide.
- If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2293880
Mikel Olasagasti Uranga mikel@olasagasti.info changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |mikel@olasagasti.info Assignee|nobody@fedoraproject.org |mikel@olasagasti.info Flags| |fedora-review+
--- Comment #3 from Mikel Olasagasti Uranga mikel@olasagasti.info --- Do you plan to take care of bumping the rest of requried packages? golang-cloud-google-compute-metadata-devel and others.
This package was generated using go2rpm, which simplifies the review.
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
- [x] The latest version is packaged or packaging an earlier version is justified. - [x] The License tag reflects the package contents and uses the correct identifiers. - [x] The package builds successfully in mock. - [x] Package is installable (checked by fedora-review). - [x] There are no relevant rpmlint errors. - [x] The package runs tests in %check. - [x] `%goipath` is set correctly. - [-] The package's binaries don't conflict with binaries already in the distribution. (Some Go projects include utility binaries with very generic names) - [-] There are no `%{_bindir}/*` wildcards in %files. (go2rpm includes these by default) - [x] The package does not use `%gometa -f` if it has dependents that still build for %ix86. - [x] The package complies with the Golang and general Packaging Guidelines.
Package approved! On import, don't forget to do the following:
- [ ] Add the package to release-monitoring.org - [ ] Give go-sig privileges (at least commit) on the package - [ ] Close the review bug by referencing its ID in the rpm changelog and the Bodhi ticket. - [ ] Consider configuring Packit service to help with maintenance
Thanks!
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com