[Bug 226022] New: Merge Review: libgpod

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226022

Summary: Merge Review: libgpod
           Product: Fedora Extras
           Version: devel
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: normal
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail]

Fedora Merge Review: libgpod

http://cvs.fedora.redhat.com/viewcvs/devel/libgpod/
Initial Owner: [e-mail]

[Bug 226022] Merge Review: libgpod

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: libgpod

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226022

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
               Flag|                            |fedora-review?

------- Additional Comments From [e-mail]  2007-02-02 12:49 EST -------
I'll review this.

[Bug 226022] Merge Review: libgpod

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: libgpod

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226022

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|[e-mail]    |[e-mail]
                 CC|                            |[e-mail]
               Flag|fedora-review?              |fedora-review+

------- Additional Comments From [e-mail]  2007-02-02 14:50 EST -------
MUST items verified

* rpmlint runs without errors on the srpm (just a minor warning, output below)
* Adheres to naming guidelines
* Specfile name matches package name
* Meets packaging guidelines (except for %makeinstall usage, see below)
* License meets open-source requirements
* License included in %doc
* License field matches the upstream license
* Specfile is in American English
* Specfile is legible
* Source matches upstream (sha1: b2aece62a206a5b703c50e6625b173217f1d67a6)
* Builds, installs, and works (tested on FC6, i386)
* Owns directories that it creates
* Does not own files or directories of other packages
* File list has no duplicates
* File perms are sane
* Specfile includes %clean section
* Macros used consistently
* Package contains code or permissible content
* Headers are in -devel subpackage
* Devel package properly requires pkgconfig and the base libgpod package
* Libtool archives and static archives are excluded

SHOULD items verified

* Builds in mock against fedora-{5,6,development}-i386-core targets
* Scriplets are sane
* Package functions correctly (tested on FC6)

$ rpmlint libgpod-0.4.2-1.fc7.src.rpm 
W: libgpod setup-not-quiet

This warning is very minor and easily silenced with the addition of -q to
%setup. It's not a blocker as far as I know.

Another very a minor point, the preferred value for the BuildRoot tag is
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
This is not a blocker.

The one thing that should be fixed is to change %makeinstall to
%{__make} DESTDIR=%{buildroot} install as per the packaging guidelines.

APPROVED

[Bug 226022] Merge Review: libgpod

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: libgpod

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226022

------- Additional Comments From [e-mail]  2007-02-02 14:53 EST -------
It should probably also be noted here for future reference that this package
does not contain the python module that is shipped with libgpod.  This is only
due to the requirement of that module on the python-eyed3 package which is only
available in Extras.  Once the merge is completed and libgpod can safely require
python-eyed3, then the python-gpod package from extras should be rolled into
this package.

I'd also like to volunteer to co-maintain this package.  I have upstream commit
privileges* and follow the development closely.  I'm also the maintainer of the
python-gpod package currently in Extras.

* not because I'm much of a coder, but because I've helped with automake and
documentation issues

[Bug 226022] Merge Review: libgpod

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: libgpod

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226022

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|[e-mail]            |[e-mail]

[Bug 226022] Merge Review: libgpod

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: libgpod

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226022

------- Additional Comments From [e-mail]  2007-02-03 22:09 EST -------
Its probably best to file a separate bug for the python bindings, and put it on
FC7Tracker.

[Bug 226022] Merge Review: libgpod

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: libgpod

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226022

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|[e-mail]               |[e-mail]

[Bug 226022] Merge Review: libgpod

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: libgpod

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226022

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|[e-mail]    |[e-mail]

------- Additional Comments From [e-mail]  2007-02-04 01:16 EST -------
Thanks Matthias, I'll look to do that after the review process.  I simply wanted
to make a note of why the functionality was disabled in this review so that
anyone wondering will know it was intentional and necessary.

I'm reassigning this to myself as the reviewer of the package, as per my
understanding of how the merge reviews are to be handled.  As I understand it,
the bug should be assigned to the reviewer for the review and then reassigned to
the maintainer afterward.  If you feel I am in error for doing so, please let me
know why.

[Bug 226022] Merge Review: libgpod

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: libgpod

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226022

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |medium
           Priority|normal                      |medium

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |RAWHIDE

------- Additional Comments From [e-mail]  2007-05-30 10:39 EST -------
Approved, so closing now. Todd has commit rights.

[Bug 226022] Merge Review: libgpod

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: libgpod

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226022

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Product|Fedora Extras               |Fedora

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|[e-mail]            |[e-mail]
               Flag|                            |fedora-cvs?

------- Additional Comments From [e-mail]  2007-08-03 11:13 EST -------
Package Change Request
======================
Package Name: libgpod
Updated Fedora Owners: [e-mail],[e-mail]

(This might need an explicit ACK from Bastien, so the CVS admins don't think I'm
trying to pull one over. :)

[Bug 226022] Merge Review: libgpod

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: libgpod

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226022

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

------- Additional Comments From [e-mail]  2007-08-03 12:54 EST -------
Yes, Bastien: Can you ack this change here?

[Bug 226022] Merge Review: libgpod

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: libgpod

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226022

------- Additional Comments From [e-mail]  2007-08-03 18:35 EST -------
Yep, Todd's the one doing the work :)

[Bug 226022] Merge Review: libgpod

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: libgpod

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226022

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-cvs?                 |fedora-cvs+

------- Additional Comments From [e-mail]  2007-08-04 02:08 EST -------
thanks. cvs done.