[Bug 570842] New: Review Request: sugar-labyrinth - A lightweight mind-mapping activity for Sugar
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: sugar-labyrinth - A lightweight mind-mapping activity for Sugar
https://bugzilla.redhat.com/show_bug.cgi?id=570842
Summary: Review Request: sugar-labyrinth - A lightweight mind-mapping activity for Sugar Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: sebastian@when.com QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora
Spec URL: http://sdz.fedorapeople.org/rpmbuild/sugar-labyrinth.spec SRPM URL: http://sdz.fedorapeople.org/rpmbuild/sugar-labyrinth-8-1.fc12.src.rpm
Description: This is another requirement for the Sugar packaging effort. Koji Scratch Build: http://koji.fedoraproject.org/koji/taskinfo?taskID=2033420
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=570842
Sebastian Dziallas sebastian@when.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |558617(SOAS-3)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=570842
Peter Robinson pbrobinson@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |pbrobinson@gmail.com AssignedTo|nobody@fedoraproject.org |pbrobinson@gmail.com Flag| |fedora-review?
--- Comment #1 from Peter Robinson pbrobinson@gmail.com 2010-03-14 17:30:30 EDT --- I'll review this one.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=570842
Peter Robinson pbrobinson@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
--- Comment #2 from Peter Robinson pbrobinson@gmail.com 2010-04-02 08:05:10 EDT --- All mostly good. A few very minor rpmlint that need to be fixed. Removal of empty file and the tabs issue. Other that that it all looks good. APPROVED!
+ rpmlint output
$ rpmlint sugar-labyrinth.spec sugar-labyrinth-8-1.fc12.src.rpm sugar-labyrinth-8-1.fc12.noarch.rpm sugar-labyrinth.spec:6: W: non-standard-group Sugar/Activities sugar-labyrinth.spec:12: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 12) sugar-labyrinth.src: W: non-standard-group Sugar/Activities sugar-labyrinth.src:12: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 12) sugar-labyrinth.noarch: W: non-standard-group Sugar/Activities sugar-labyrinth.noarch: E: zero-length /usr/share/sugar/activities/Labyrinth.activity/port/TODO 2 packages and 1 specfiles checked; 1 errors, 5 warnings.
+ package name satisfies the packaging naming guidelines + specfile name matches the package base name + package should satisfy packaging guidelines + license meets guidelines and is acceptable to Fedora + license matches the actual package license + latest version packaged
+ %doc includes license file + spec file written in American English + spec file is legible + upstream sources match sources in the srpm 381604d0011554469f1c93884e723878 labyrinth-8.xo + package successfully builds on at least one architecture tested using koji scratch build + BuildRequires list all build dependencies + %find_lang instead of %{_datadir}/locale/* n/a binary RPM with shared library files must call ldconfig in %post and %postun+ does not use Prefix: /usr n/a package owns all directories it creates n/a no duplicate files in %files + Package perserves timestamps on install + %defattr line + %clean contains rm -rf $RPM_BUILD_ROOT + consistent use of macros + package must contain code or permissible content n/a large documentation files should go in -doc subpackage + files marked %doc should not affect package n/a header files should be in -devel n/a static libraries should be in -static n/a packages containing pkgconfig (.pc) files need 'Requires: pkgconfig' n/a libfoo.so must go in -devel n/a devel must require the fully versioned base + packages should not contain libtool .la files n/a packages containing GUI apps must include %{name}.desktop file + packages must not own files or directories owned by other packages + %install must start with rm -rf %{buildroot} etc. + filenames must be valid UTF-8
Optional:
n/a if there is no license file, packager should query upstream n/a translations of description and summary for non-English languages, if available + reviewer should build the package in mock/koji n/a the package should build into binary RPMs on all supported architectures n/a review should test the package functions as described + scriptlets should be sane n/a pkgconfig files should go in -devel + shouldn't have file dependencies outside /etc /bin /sbin /usr/bin or /usr/sbin
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=570842
Sebastian Dziallas sebastian@when.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
--- Comment #3 from Sebastian Dziallas sebastian@when.com 2010-04-03 07:25:37 EDT --- New Package CVS Request ======================= Package Name: sugar-labyrinth Short Description: A lightweight mind-mapping activity for Sugar Owners: sdz pbrobinson Branches: F-13 F-12 F-11
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=570842
--- Comment #4 from Kevin Fenzi kevin@tummy.com 2010-04-03 13:37:40 EDT --- CVS done (by process-cvs-requests.py).
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=570842
Peter Robinson pbrobinson@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |RAWHIDE
--- Comment #5 from Peter Robinson pbrobinson@gmail.com 2010-04-04 11:37:40 EDT --- Built and on its way to rawhide
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla