https://bugzilla.redhat.com/show_bug.cgi?id=2211190
Bug ID: 2211190 Summary: Review Request: rust-dtparse - Dateutil-compatible timestamp parser for Rust Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nobody@fedoraproject.org Reporter: michel@michel-slm.name QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://salimma.fedorapeople.org/rust-dtparse.spec SRPM URL: https://salimma.fedorapeople.org/rust-dtparse-1.4.0-1.fc39.src.rpm
Description: A dateutil-compatible timestamp parser for Rust.
Fedora Account System Username: salimma
https://bugzilla.redhat.com/show_bug.cgi?id=2211190
Michel Alexandre Salim michel@michel-slm.name changed:
What |Removed |Added ---------------------------------------------------------------------------- Alias| |review-rust-dtparse Doc Type|--- |If docs needed, set a value Blocks| |2211172 | |(itp-rust-nu-command)
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2211172 [Bug 2211172] ITP: rust-nu-command
https://bugzilla.redhat.com/show_bug.cgi?id=2211190
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |decathorpe@gmail.com Status|NEW |ASSIGNED Assignee|nobody@fedoraproject.org |decathorpe@gmail.com Flags| |fedora-review?
--- Comment #1 from Fabio Valentini decathorpe@gmail.com --- 1. There's a bunch of files in this crate that we don't need ... or want, for that matter, because they introduce a dependency on /usr/bin/python3 due to their shebangs. Adding something like this to the [package] table in Cargo.toml would be great (can be upstreamed):
exclude = ["/*.py"]
2. There's no actual license text included. The LICENSE file contains only a header, but not the actual Apache-2.0 license text. Please report upstream ...
https://bugzilla.redhat.com/show_bug.cgi?id=2211190
--- Comment #2 from Michel Alexandre Salim michel@michel-slm.name --- https://github.com/bspeice/dtparse/pull/42 for excluding Python files. Working on the license next
https://bugzilla.redhat.com/show_bug.cgi?id=2211190
Michel Alexandre Salim michel@michel-slm.name changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(decathorpe@gmail. | |com)
--- Comment #3 from Michel Alexandre Salim michel@michel-slm.name --- https://github.com/bspeice/dtparse/pull/43 for adding license text
Spec URL: https://salimma.fedorapeople.org/rust-dtparse.spec SRPM URL: https://salimma.fedorapeople.org/rust-dtparse-1.4.0-1.fc39.src.rpm
https://bugzilla.redhat.com/show_bug.cgi?id=2211190
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(decathorpe@gmail. | |com) |
--- Comment #4 from Fabio Valentini decathorpe@gmail.com --- Thanks! Upstream released a new version that contains both your PRs, can you update this package to v1.5.0?
https://bugzilla.redhat.com/show_bug.cgi?id=2211190
--- Comment #5 from Michel Alexandre Salim michel@michel-slm.name --- Certainly, thanks!
Spec URL: https://salimma.fedorapeople.org/rust-dtparse.spec SRPM URL: https://salimma.fedorapeople.org/rust-dtparse-1.5.0-1.fc39.src.rpm
https://bugzilla.redhat.com/show_bug.cgi?id=2211190
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ Status|ASSIGNED |POST
--- Comment #6 from Fabio Valentini decathorpe@gmail.com --- Thanks for the update!
===
Package was generated with rust2rpm, simplifying the review.
- package builds and installs without errors on rawhide - test suite is run and all unit tests pass - latest version of the crate is packaged - license matches upstream specification (Apache-2.0) and is acceptable for Fedora - license file is included with %license in %files - package complies with Rust Packaging Guidelines
Package APPROVED.
===
Recommended post-import rust-sig tasks:
- add @rust-sig with "commit" access as package co-maintainer
- set bugzilla assignee overrides to @rust-sig (optional)
- set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate
- track package in koschei for all built branches
https://bugzilla.redhat.com/show_bug.cgi?id=2211190
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(michel@michel-slm | |.name)
https://bugzilla.redhat.com/show_bug.cgi?id=2211190
Michel Lind michel@michel-slm.name changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(michel@michel-slm | |.name) |
--- Comment #7 from Michel Lind michel@michel-slm.name --- ah, forgot to import
https://bugzilla.redhat.com/show_bug.cgi?id=2211190
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review+
https://bugzilla.redhat.com/show_bug.cgi?id=2211190
--- Comment #8 from Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org --- The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-dtparse
https://bugzilla.redhat.com/show_bug.cgi?id=2211190
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |MODIFIED
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-840cf08157 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2024-840cf08157
https://bugzilla.redhat.com/show_bug.cgi?id=2211190
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-f06b105d34 has been pushed to the Fedora 39 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-f06b105d34 *` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-f06b105d34
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2211190
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-840cf08157 has been pushed to the Fedora 38 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-840cf08157 *` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-840cf08157
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2211190
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |ERRATA Status|ON_QA |CLOSED Last Closed| |2024-01-09 01:46:01
--- Comment #12 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-f06b105d34 has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=2211190
--- Comment #13 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-840cf08157 has been pushed to the Fedora 38 stable repository. If problem still persists, please make note of it in this bug report.
package-review@lists.fedoraproject.org