[Bug 2379923] New: Review Request: gap-pkg-unipot - Unipotent subgroups of Chevalley groups for GAP
https://bugzilla.redhat.com/show_bug.cgi?id=2379923
Bug ID: 2379923 Summary: Review Request: gap-pkg-unipot - Unipotent subgroups of Chevalley groups for GAP Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: loganjerry@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://jjames.fedorapeople.org/gap-pkg-unipot/gap-pkg-unipot.spec SRPM URL: https://jjames.fedorapeople.org/gap-pkg-unipot/gap-pkg-unipot-1.6-1.fc43.src... Fedora Account System Username: jjames Description: The Unipot package provides GAP with the ability to compute with elements of unipotent subgroups of Chevalley groups, and also some properties of such groups.
I willing to swap reviews.
https://bugzilla.redhat.com/show_bug.cgi?id=2379923
Fedora Review Service fedora-review-bot@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- URL| |https://gap-packages.github | |.io/unipot/ Keywords| |AutomationTriaged
--- Comment #1 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/9369257 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2379923
--- Comment #2 from Jerry James loganjerry@gmail.com --- I have updated the spec file to use the new GAP declarative buildsystem. New URLs:
Spec URL: https://jjames.fedorapeople.org/gap-pkg-unipot/gap-pkg-unipot.spec SRPM URL: https://jjames.fedorapeople.org/gap-pkg-unipot/gap-pkg-unipot-1.6-1.fc44.src...
https://bugzilla.redhat.com/show_bug.cgi?id=2379923
--- Comment #3 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Created attachment 2108020 --> https://bugzilla.redhat.com/attachment.cgi?id=2108020&action=edit The .spec file difference from Copr build 9369257 to 9629584
https://bugzilla.redhat.com/show_bug.cgi?id=2379923
Fedora Review Service fedora-review-bot@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords|AutomationTriaged |
--- Comment #4 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/9629584 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2379923
Benson Muite benson_muite@emailplus.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@fedoraproject.org |benson_muite@emailplus.org Flags| |fedora-review+ Status|NEW |POST CC| |benson_muite@emailplus.org
--- Comment #5 from Benson Muite benson_muite@emailplus.org --- Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
===== MUST items =====
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "GNU General Public License, Version 2". 19 files have unknown license. Detailed output of licensecheck in /home/fedora/2379923-gap-pkg-unipot/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 2753 bytes in 2 files. [x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: gap-pkg-unipot-1.6-1.fc44.noarch.rpm gap-pkg-unipot-doc-1.6-1.fc44.noarch.rpm gap-pkg-unipot-1.6-1.fc44.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.7.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpgij69eqg')] checks: 32, packages: 3
gap-pkg-unipot.noarch: E: spelling-error ('Unipotent', 'Summary(en_US) Unipotent -> Uni potent, Uni-potent, Omnipotent') gap-pkg-unipot.noarch: E: spelling-error ('unipotent', '%description -l en_US unipotent -> uni potent, uni-potent, omnipotent') gap-pkg-unipot.src: E: spelling-error ('Unipotent', 'Summary(en_US) Unipotent -> Uni potent, Uni-potent, Omnipotent') gap-pkg-unipot.src: E: spelling-error ('unipotent', '%description -l en_US unipotent -> uni potent, uni-potent, omnipotent') gap-pkg-unipot-doc.noarch: W: no-documentation gap-pkg-unipot.noarch: E: incorrect-fsf-address /usr/share/licenses/gap-pkg-unipot/LICENSE 3 packages and 0 specfiles checked; 5 errors, 1 warnings, 12 filtered, 5 badness; has taken 0.3 s
Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.7.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 2
gap-pkg-unipot.noarch: E: spelling-error ('Unipotent', 'Summary(en_US) Unipotent -> Uni potent, Uni-potent, Omnipotent') gap-pkg-unipot.noarch: E: spelling-error ('unipotent', '%description -l en_US unipotent -> uni potent, uni-potent, omnipotent') gap-pkg-unipot-doc.noarch: W: no-documentation gap-pkg-unipot.noarch: E: incorrect-fsf-address /usr/share/licenses/gap-pkg-unipot/LICENSE 2 packages and 0 specfiles checked; 3 errors, 1 warnings, 8 filtered, 3 badness; has taken 0.1 s
Source checksums ---------------- https://github.com/gap-packages/unipot/archive/v1.6/unipot-1.6.tar.gz : CHECKSUM(SHA256) this package : 492d2fac163c71536f3d961d8a17e5a0859d542dc0f20ff23c2d388b46d08154 CHECKSUM(SHA256) upstream package : 492d2fac163c71536f3d961d8a17e5a0859d542dc0f20ff23c2d388b46d08154
Requires -------- gap-pkg-unipot (rpmlib, GLIBC filtered): gap-core
gap-pkg-unipot-doc (rpmlib, GLIBC filtered): gap-online-help gap-pkg-unipot
Provides -------- gap-pkg-unipot: gap-pkg-unipot
gap-pkg-unipot-doc: gap-pkg-unipot-doc
Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2379923 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api Disabled plugins: Perl, PHP, Ocaml, Java, Haskell, Python, SugarActivity, R, C/C++, fonts Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
Comments: a) Approved.
https://bugzilla.redhat.com/show_bug.cgi?id=2379923
--- Comment #6 from Jerry James loganjerry@gmail.com --- Thank you for the review!
https://bugzilla.redhat.com/show_bug.cgi?id=2379923
Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |RELEASE_PENDING
--- Comment #7 from Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org --- The Pagure repository was created at https://src.fedoraproject.org/rpms/gap-pkg-unipot
https://bugzilla.redhat.com/show_bug.cgi?id=2379923
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RELEASE_PENDING |MODIFIED
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- FEDORA-2025-b5b6e5d28c (gap-pkg-unipot-1.6-1.fc43) has been submitted as an update to Fedora 43. https://bodhi.fedoraproject.org/updates/FEDORA-2025-b5b6e5d28c
https://bugzilla.redhat.com/show_bug.cgi?id=2379923
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- FEDORA-2025-b5b6e5d28c has been pushed to the Fedora 43 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-b5b6e5d28c *` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-b5b6e5d28c
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2379923
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |ERRATA Status|ON_QA |CLOSED Last Closed| |2025-10-25 21:07:59
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- FEDORA-2025-b5b6e5d28c (gap-pkg-unipot-1.6-1.fc43) has been pushed to the Fedora 43 stable repository. If problem still persists, please make note of it in this bug report.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com