[Bug 2284639] New: Review Request: rust-extreme - Extremely boring async function runner
https://bugzilla.redhat.com/show_bug.cgi?id=2284639
Bug ID: 2284639 Summary: Review Request: rust-extreme - Extremely boring async function runner Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nobody@fedoraproject.org Reporter: davide@cavalca.name QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://dcavalca.fedorapeople.org/review/rust-extreme/rust-extreme.spec SRPM URL: https://dcavalca.fedorapeople.org/review/rust-extreme/rust-extreme-666.666.6...
Description: Extremely boring async function runner.
Fedora Account System Username: dcavalca
https://bugzilla.redhat.com/show_bug.cgi?id=2284639
--- Comment #1 from Davide Cavalca davide@cavalca.name --- This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=118521356
https://bugzilla.redhat.com/show_bug.cgi?id=2284639
Davide Cavalca davide@cavalca.name changed:
What |Removed |Added ---------------------------------------------------------------------------- Doc Type|--- |If docs needed, set a value
--- Comment #2 from Davide Cavalca davide@cavalca.name --- $ cat rust2rpm.toml [package] description = "Extremely boring async function runner."
https://bugzilla.redhat.com/show_bug.cgi?id=2284639
Davide Cavalca davide@cavalca.name changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |2284640
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2284640 [Bug 2284640] Review Request: rust-rio - Rust bindings for io_uring
https://bugzilla.redhat.com/show_bug.cgi?id=2284639
Fedora Review Service fedora-review-bot@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- URL| |https://crates.io/crates/ex | |treme
--- Comment #3 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/7525433 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Found issues:
- Not a valid SPDX expression 'GPL-3.0'. Read more: https://fedoraproject.org/wiki/Changes/SPDX_Licenses_Phase_1
Please know that there can be false-positives.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2284639
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |decathorpe@gmail.com Flags| |fedora-review? Assignee|nobody@fedoraproject.org |decathorpe@gmail.com
--- Comment #4 from Fabio Valentini decathorpe@gmail.com --- Version 666.666.666666? Seriously? ...
There's some files that should be excluded from the "-devel" package in some ways: sanitizers.sh and tsan_suppressions.txt For example, the sanitizers.sh file causes RPM to generate a dependency on bash.
https://bugzilla.redhat.com/show_bug.cgi?id=2284639
--- Comment #5 from Fabio Valentini decathorpe@gmail.com --- Additionally, GPL-3.0 is not a valid SPDX identifier in recent versions of SPDX. It should be either GPL-3.0-only or GPL-3.0-or-later. (I assume the intention is GPL-3.0-only. The deprecated equivalent of GPL-3.0-or-later is GPL-3.0+).
https://bugzilla.redhat.com/show_bug.cgi?id=2284639
--- Comment #6 from Davide Cavalca davide@cavalca.name --- Spec URL: https://dcavalca.fedorapeople.org/review/rust-extreme/rust-extreme.spec SRPM URL: https://dcavalca.fedorapeople.org/review/rust-extreme/rust-extreme-666.666.6...
Changelog: - update license tag - drop unnecessary files
https://bugzilla.redhat.com/show_bug.cgi?id=2284639
--- Comment #7 from Davide Cavalca davide@cavalca.name --- $ cat rust2rpm.toml [package] description = "Extremely boring async function runner."
[scripts] # Remove unnecessary scripts prep.pre = ["rm sanitizers.sh tsan_suppressions.txt"]
https://bugzilla.redhat.com/show_bug.cgi?id=2284639
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #8 from Fabio Valentini decathorpe@gmail.com --- You will need to update the license tag in Cargo.toml too, otherwise tooling like the %cargo_license macro will not pick up the change.
Other than that, looks good to me!
===
Package was generated with rust2rpm, simplifying the review.
✅ package contains only permissible content ✅ package builds and installs without errors on rawhide ✅ test suite is run and all unit tests pass ✅ latest version of the crate is packaged ✅ license matches upstream specification and is acceptable for Fedora ✅ license file is included with %license in %files ✅ package complies with Rust Packaging Guidelines
Package APPROVED.
===
Recommended post-import rust-sig tasks:
- set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate
- add @rust-sig with "commit" access as package co-maintainer (should happen automatically)
- set bugzilla assignee overrides to @rust-sig (optional)
- track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer)
https://bugzilla.redhat.com/show_bug.cgi?id=2284639
Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST
--- Comment #9 from Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org --- The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-extreme
https://bugzilla.redhat.com/show_bug.cgi?id=2284639
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |MODIFIED
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-b78058c802 (rust-extreme-666.666.666666-1.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2024-b78058c802
https://bugzilla.redhat.com/show_bug.cgi?id=2284639
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |CLOSED Resolution|--- |ERRATA Last Closed| |2024-07-06 00:20:40
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-b78058c802 (rust-extreme-666.666.666666-1.fc41) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=2284639
--- Comment #12 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-95bdcfdd91 (rust-extreme-666.666.666666-1.fc40) has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2024-95bdcfdd91
https://bugzilla.redhat.com/show_bug.cgi?id=2284639
--- Comment #13 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-3ede179598 (rust-extreme-666.666.666666-1.fc39) has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2024-3ede179598
https://bugzilla.redhat.com/show_bug.cgi?id=2284639
--- Comment #14 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-3ede179598 (rust-extreme-666.666.666666-1.fc39) has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=2284639
--- Comment #15 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-95bdcfdd91 (rust-extreme-666.666.666666-1.fc40) has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com