[Bug 1635578] New: Review Request: js-jquery-jqplot - Pure JavaScript plotting plugin for jQuery
https://bugzilla.redhat.com/show_bug.cgi?id=1635578
Bug ID: 1635578 Summary: Review Request: js-jquery-jqplot - Pure JavaScript plotting plugin for jQuery Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: xavier@bachelot.org QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://www.bachelot.org/fedora/SPECS/js-jquery-jqplot.spec SRPM URL: https://www.bachelot.org/fedora/SRPMS/js-jquery-jqplot-1.0.9-1.fc28.src.rpm Description: jqPlot is a plotting and charting plugin for the jQuery Javascript framework. jqPlot produces beautiful line, bar and pie charts with many features: - Numerous chart style options. - Date axes with customizable formatting. - Up to 9 Y axes. - Rotated axis text. - Automatic trend line computation. - Tooltips and data point highlighting. - Sensible defaults for ease of use. Fedora Account System Username: xavierb
https://bugzilla.redhat.com/show_bug.cgi?id=1635578
--- Comment #1 from Xavier Bachelot xavier@bachelot.org --- It does build on F27 and F29, but doesn't on F28 due to https://bugzilla.redhat.com/show_bug.cgi?id=1635576
https://bugzilla.redhat.com/show_bug.cgi?id=1635578
Robert-André Mauchin zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST CC| |zebob.m@gmail.com Assignee|nobody@fedoraproject.org |zebob.m@gmail.com Flags| |fedora-review+
--- Comment #2 from Robert-André Mauchin zebob.m@gmail.com --- warning: bogus date in %changelog: Tue Oct 13 2018 Xavier Bachelot xavier@bachelot.org - 1.0.9-1
The date is in the future and has incorrect day, it should be:
Wed Oct 03 2018 Xavier Bachelot xavier@bachelot.org - 1.0.9-1
Package approved. Fix the date before import.
Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
===== MUST items =====
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: js-jquery-jqplot-1.0.9-1.fc30.noarch.rpm js-jquery-jqplot-1.0.9-1.fc30.src.rpm js-jquery-jqplot.noarch: E: changelog-time-in-future 2018-10-13 js-jquery-jqplot.src: E: changelog-time-in-future 2018-10-13 js-jquery-jqplot.src: E: specfile-error warning: bogus date in %changelog: Tue Oct 13 2018 Xavier Bachelot xavier@bachelot.org - 1.0.9-1 2 packages and 0 specfiles checked; 3 errors, 0 warnings.
https://bugzilla.redhat.com/show_bug.cgi?id=1635578
--- Comment #3 from Xavier Bachelot xavier@bachelot.org --- Thanks for the review and sorry about the stupid typo I introduced in the changelog when updating the date before submission for review... I have requested the repo and will fix before import.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com