https://bugzilla.redhat.com/show_bug.cgi?id=1049116
Bug ID: 1049116 Summary: Review Request: ns2 - The Network Simulator Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: moceap@hotmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: http://ojuba.org/oji/SPECS/ns2.spec SRPM URL: http://ojuba.org/oji/SRPMS/ns2-2.35-1.oji.fc19.src.rpm Description: Ns is a discrete event simulator targeted at networking research. Ns provides substantial support for simulation of TCP, routing, and multicast protocols over wired and wireless (local and satellite) networks.
Fedora Account System Username: moceap
https://bugzilla.redhat.com/show_bug.cgi?id=1049116
Mosaab Alzoubi moceap@hotmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1047497 (OTcl), 1047702 | |(TCLCL) Alias| |ns2
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1047497 [Bug 1047497] Review Request: otcl - MIT Object Tcl https://bugzilla.redhat.com/show_bug.cgi?id=1047702 [Bug 1047702] Review Request: tclcl - Tcl/C++ interface
https://bugzilla.redhat.com/show_bug.cgi?id=1049116
Mosaab Alzoubi moceap@hotmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On|1047497 (OTcl) |
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1047497 [Bug 1047497] Review Request: otcl - MIT Object Tcl
https://bugzilla.redhat.com/show_bug.cgi?id=1049116
Mosaab Alzoubi moceap@hotmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1047497 (OTcl)
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1047497 [Bug 1047497] Review Request: otcl - MIT Object Tcl
https://bugzilla.redhat.com/show_bug.cgi?id=1049116
Mosaab Alzoubi moceap@hotmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |cickumqt@gmail.com
--- Comment #1 from Mosaab Alzoubi moceap@hotmail.com --- Rebuild on F20, and re-upload due to failed past upload.
Spec URL: http://ojuba.org/oji/SPECS/ns2.spec SRPM URL: http://ojuba.org/oji/SRPMS/ns2-2.35-1.fc20.src.rpm
https://bugzilla.redhat.com/show_bug.cgi?id=1049116
Seng Jea sengjea@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |sengjea@gmail.com
--- Comment #2 from Seng Jea sengjea@gmail.com --- Created attachment 922542 --> https://bugzilla.redhat.com/attachment.cgi?id=922542&action=edit Patch to allow 64 bit builds
Current ns2.spec file does not successfully build in 64 bit environment because it can't find the libraries. Patch attached fixes this and patch needs to be included in the .spec file:
Patch0: ns-allinone-2.35-otcl.patch
%prep %patch1 -p2
https://bugzilla.redhat.com/show_bug.cgi?id=1049116
--- Comment #3 from Mosaab Alzoubi moceap@hotmail.com --- Thanx Alot Seng.
I'll merege them soon, Patch These too :
https://bugzilla.redhat.com/show_bug.cgi?id=1047497 https://bugzilla.redhat.com/show_bug.cgi?id=1047702
They are requires :)
https://bugzilla.redhat.com/show_bug.cgi?id=1049116
--- Comment #4 from Mosaab Alzoubi moceap@hotmail.com --- (In reply to Mosaab Alzoubi from comment #3)
Thanx Alot Seng.
I'll merege them soon, Patch These too :
https://bugzilla.redhat.com/show_bug.cgi?id=1047497 https://bugzilla.redhat.com/show_bug.cgi?id=1047702
They are requires :)
No need ^_^
https://bugzilla.redhat.com/show_bug.cgi?id=1049116
--- Comment #5 from Mosaab Alzoubi moceap@hotmail.com --- - Support 64Bit by Seng Jea. - Fix configure lines. - General tweaks.
Spec: http://ojuba.org/test/ns2.spec Srpm: http://ojuba.org/test/ns2-2.35-2.oj35.src.rpm
https://bugzilla.redhat.com/show_bug.cgi?id=1049116
Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |zbyszek@in.waw.pl
--- Comment #6 from Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl --- Suggestion: for the MANDEST variable, it might be simpler to simply set it as an argument to make: make MANDEST=%{_mandir}
Suggestion: use 'make -C <dir> ...' instead of pushd, popd everywhere.
New guidelines say that %license has to be used for LICENSES, COPYRIGHTS.
Looks reasonable, but I'll wait until dependencies are resolved before taking further steps.
https://bugzilla.redhat.com/show_bug.cgi?id=1049116
--- Comment #7 from Mosaab Alzoubi moceap@hotmail.com --- What is this (%license) ?? I checked Packaging License wiki ...
Suggestion will be taken .
Thank You .
https://bugzilla.redhat.com/show_bug.cgi?id=1049116
--- Comment #8 from Michael Schwendt (Fedora Packager Sponsors Group) bugs.michael@gmx.net --- https://fedoraproject.org/wiki/Packaging:Guidelines#Licensing -> https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text
You may want to subscribe to some mailing-lists where such things are announced/discussed.
Also FYI: https://lists.fedoraproject.org/pipermail/devel/2015-February/208449.html https://lists.fedoraproject.org/pipermail/devel/2015-February/208451.html
https://bugzilla.redhat.com/show_bug.cgi?id=1049116
--- Comment #9 from Mosaab Alzoubi moceap@hotmail.com --- I'm already in these lists , but I missed this discus.
https://bugzilla.redhat.com/show_bug.cgi?id=1049116
--- Comment #10 from Mosaab Alzoubi moceap@hotmail.com --- - Better way to fix MANDEST - Better way to detect DIRs on make commands - Use %%make_install - Remove Group tag - Use %%license macro
Spec: http://ojuba.org/test/ns2.spec Srpm: http://ojuba.org/test/ns2-2.35-3.oj35.src.rpm
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla