https://bugzilla.redhat.com/show_bug.cgi?id=2185044
Bug ID: 2185044 Summary: Review Request: golang-github-vultr-govultr-3 - Vultr Go API client Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: mhayden@redhat.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://download.copr.fedorainfracloud.org/results/mhayden/vultr/fedora-rawh... SRPM URL: https://download.copr.fedorainfracloud.org/results/mhayden/vultr/fedora-rawh... Description: Vultr Go API client Fedora Account System Username: mhayden
This package came about because golang-github-vultr-govultr-2 needs an upgrade to 3.0.2 (BZ 2180539) to support the latest vultr-cli release (BZ 2183746).
https://bugzilla.redhat.com/show_bug.cgi?id=2185044
Maxwell G maxwell@gtmx.me changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST Flags| |fedora-review+ Assignee|nobody@fedoraproject.org |maxwell@gtmx.me CC| |maxwell@gtmx.me
--- Comment #1 from Maxwell G maxwell@gtmx.me --- This package was generated using go2rpm, which simplifies the review.
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
- [x] The specfile is sane. - [x] The License tag reflects the package contents and uses the correct identifiers. - [x] The package builds successfully in mock. - [x] Package is installable (checked by fedora-review). - [x] There are no relevant rpmlint errors. - [x] The package runs tests in %check. - [x] The latest version is packaged. - [x] `%goipath` is set correctly. - [-] The package's binaries don't conflict with binaries already in the distribution. (Some Go projects include utility binaries with very generic names) - [-] There are no `%{_bindir}/*` wildcards in %files. (go2rpm includes these by default) - [x] The package complies with the Golang and general Packaging Guidelines.
Package approved! On import, don't forget to do the following:
- [ ] Add the package to release-monitoring.org - [ ] Give go-sig privileges (at least commit) on the package - [ ] Close the review bug by referencing its ID in the rpm changelog and the Bodhi ticket.
Thanks!
https://bugzilla.redhat.com/show_bug.cgi?id=2185044
--- Comment #2 from Major Hayden 🤠 mhayden@redhat.com --- Thank you, Maxwell!
https://bugzilla.redhat.com/show_bug.cgi?id=2185044
--- Comment #3 from Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org --- The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-vultr-govultr-3
https://bugzilla.redhat.com/show_bug.cgi?id=2185044
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |MODIFIED
--- Comment #4 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-6085e44fed has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-6085e44fed
https://bugzilla.redhat.com/show_bug.cgi?id=2185044
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |ERRATA Status|MODIFIED |CLOSED Last Closed| |2023-04-06 20:50:58
--- Comment #5 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-6085e44fed has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report.
package-review@lists.fedoraproject.org