[Bug 1662309] New: Review Request: python-ifaddr - Python library that allows you to find all the IP addresses of the computer

https://bugzilla.redhat.com/show_bug.cgi?id=1662309

Bug ID: 1662309
           Summary: Review Request: python-ifaddr - Python library that
                    allows you to find all the IP addresses of the
                    computer
           Product: Fedora
           Version: rawhide
            Status: NEW
         Component: Package Review
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]
  Target Milestone: ---
    Classification: Fedora

Spec URL: https://ignatenkobrain.fedorapeople.org/for-review/python-ifaddr.spec
SRPM URL:
https://ignatenkobrain.fedorapeople.org/for-review/python-ifaddr-0.1.6-1.fc3...
Description:
ifaddr is a small Python library that allows you to find all the IP addresses
of the computer.
Fedora Account System Username: ignatenkobrain

[Bug 1662309] Review Request: python-ifaddr - Python library that allows you to find all the IP addresses of the computer

https://bugzilla.redhat.com/show_bug.cgi?id=1662309

--- Comment #1 from Igor Gnatenko  ---
New Spec URL:
https://ignatenkobrain.fedorapeople.org/for-review/python-ifaddr.spec
New SRPM URL:
https://ignatenkobrain.fedorapeople.org/for-review/python-ifaddr-0.1.6-1.fc3...

[Bug 1662309] Review Request: python-ifaddr - Python library that allows you to find all the IP addresses of the computer

https://bugzilla.redhat.com/show_bug.cgi?id=1662309

Neal Gompa  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
           Assignee|[e-mail]    |[e-mail]
              Flags|                            |fedora-review?

--- Comment #2 from Neal Gompa  ---
Taking this review.

[Bug 1662309] Review Request: python-ifaddr - Python library that allows you to find all the IP addresses of the computer

https://bugzilla.redhat.com/show_bug.cgi?id=1662309

Neal Gompa  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+

--- Comment #3 from Neal Gompa  ---
Review notes:

[x] Package is named properly according to Packaging Guidelines
[x] Package builds and installs properly
[x] Package follows Python packaging guidelines
[!] License file is missing
    * Pull request to include it in sdist submissions to PyPI has been
submitted: https://github.com/pydron/ifaddr/pull/18
      - Please include the license as a second source from the upstream repo
and install it properly before importing

PACKAGE APPROVED

[Bug 1662309] Review Request: python-ifaddr - Python library that allows you to find all the IP addresses of the computer

https://bugzilla.redhat.com/show_bug.cgi?id=1662309

--- Comment #4 from Igor Gnatenko  ---
(fedscm-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/python-ifaddr

[Bug 1662309] Review Request: python-ifaddr - Python library that allows you to find all the IP addresses of the computer

https://bugzilla.redhat.com/show_bug.cgi?id=1662309

Petr Pisar  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |CLOSED
                 CC|                            |[e-mail]
   Fixed In Version|                            |python-ifaddr-0.1.6-1.fc30
         Resolution|---                         |CURRENTRELEASE
        Last Closed|                            |2020-04-28 11:16:37