[Bug 1228106] New: Review Request: openstack-neutron-vpnaas - Openstack Networking VPNaaS plugin
https://bugzilla.redhat.com/show_bug.cgi?id=1228106
Bug ID: 1228106 Summary: Review Request: openstack-neutron-vpnaas - Openstack Networking VPNaaS plugin Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: ihrachys@redhat.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://ihrachyshka.fedorapeople.org/openstack-neutron-vpnaas.spec SRPM URL: https://ihrachyshka.fedorapeople.org/openstack-neutron-vpnaas-2015.1.0-3.fc2... Description: This is a VPNaaS service plugin for Openstack Neutron (Networking) service. Fedora Account System Username: ihrachyshka
https://bugzilla.redhat.com/show_bug.cgi?id=1228106
Alan Pevec apevec@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@fedoraproject.org |apevec@gmail.com Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=1228106
--- Comment #1 from Ihar Hrachyshka ihrachys@redhat.com --- Any updates?..
https://bugzilla.redhat.com/show_bug.cgi?id=1228106
Alan Pevec apevec@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|apevec@gmail.com |nobody@fedoraproject.org Flags|fedora-review? |
https://bugzilla.redhat.com/show_bug.cgi?id=1228106
Miroslav Suchý msuchy@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |msuchy@redhat.com Assignee|nobody@fedoraproject.org |msuchy@redhat.com Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=1228106
--- Comment #2 from Miroslav Suchý msuchy@redhat.com --- - Package uses either %{buildroot} or $RPM_BUILD_ROOT Note: Using both %{buildroot} and $RPM_BUILD_ROOT See: http://fedoraproject.org/wiki/Packaging/Guidelines#macros
Package requires other packages for directories it uses. Note: No known owner of /usr/share/neutron/server, /usr/share/neutron/l3_agent
openstack-neutron-vpnaas.noarch: W: no-manual-page-for-binary neutron-vpn-netns-wrapper openstack-neutron-vpnaas.noarch: W: no-manual-page-for-binary neutron-vpn-agent It would be nice to provide man page for this binaries.
python-neutron-vpnaas-tests.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/neutron_vpnaas/tests/contrib/post_test_hook.sh 644 /bin/bash python-neutron-vpnaas-tests.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/neutron_vpnaas/tests/contrib/gate_hook.sh 644 /bin/bash Either add executable flag or remove shebang from first line.
https://bugzilla.redhat.com/show_bug.cgi?id=1228106
--- Comment #3 from Ihar Hrachyshka ihrachys@redhat.com --- /usr/share/neutron/server, /usr/share/neutron/l3_agent are owned by openstack-neutron dependency that we have for the package.
As discussed before, it's not realistic to expect that upstream will provide manual pages for all tools, so I won't ship them either.
For the scripts permissions, I will send a patch to upstream to fix it: https://review.openstack.org/222655
https://bugzilla.redhat.com/show_bug.cgi?id=1228106
--- Comment #4 from Ihar Hrachyshka ihrachys@redhat.com --- Updated the spec for %{buildroot} issue. For other notes, I believe the fix belongs to upstream, or the concerns are not valid. Please comment.
https://bugzilla.redhat.com/show_bug.cgi?id=1228106
--- Comment #5 from Miroslav Suchý msuchy@redhat.com --- (In reply to Ihar Hrachyshka from comment #3)
/usr/share/neutron/server, /usr/share/neutron/l3_agent are owned by openstack-neutron dependency that we have for the package.
Indeed. This is false negative of fedora-review. So this is fine.
As discussed before, it's not realistic to expect that upstream will provide manual pages for all tools, so I won't ship them either.
Why? You are playing packager role here, and you follow distribution guidelines and best practices. It is very best practice to provide man page for every binary. So you should trying persuade upstream to provide such binary. Whether you just file bug report and leaving it as is, or you write that man page and you contribute it to upstream -- that is up to you and up to your standards. However you should *not* simply waive it out. Can you please *at least* report it to upstream?
For the scripts permissions, I will send a patch to upstream to fix it: https://review.openstack.org/222655
In the mean time you should workaround it in spec. This review took 10 days and then some time to release new version probably. This can be sometime too long in distribution life (and you may wait to pass this review until you provide rebased package). So best practice is to put in spec: %install # reported to upstream: https://review.openstack.org/222655 chmod a+x %{python2_sitelib}/%{modulename}/tests/contrib/post_test_hook.sh
Updated the spec for %{buildroot} issue.
Every time you change spec you should bump up release. This small amount of work will save you from a trouble in future.
https://bugzilla.redhat.com/show_bug.cgi?id=1228106
--- Comment #6 from Upstream Release Monitoring upstream-release-monitoring@fedoraproject.org --- social's scratch build of openstack-puppet-modules?#db4e135626252ebf0b23b8a0e6e98ce0dcf2f9e6 for git://pkgs.fedoraproject.org/openstack-puppet-modules?#db4e135626252ebf0b23b8a0e6e98ce0dcf2f9e6 and rawhide completed http://koji.fedoraproject.org/koji/taskinfo?taskID=11426591
https://bugzilla.redhat.com/show_bug.cgi?id=1228106
Miroslav Suchý msuchy@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW Assignee|msuchy@redhat.com |nobody@fedoraproject.org
https://bugzilla.redhat.com/show_bug.cgi?id=1228106
Miroslav Suchý msuchy@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |
https://bugzilla.redhat.com/show_bug.cgi?id=1228106
Haïkel Guémar karlthered@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |karlthered@gmail.com Component|Package Review |Package Review Version|rawhide |trunk Blocks| |1329341 (RDO-NEWTON) Product|Fedora |RDO
--- Comment #7 from Haïkel Guémar karlthered@gmail.com --- Wait this is not a Fedora Review but a RDO review
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1329341 [Bug 1329341] Tracker: Blockers and Review requests for new RDO Newton packages
https://bugzilla.redhat.com/show_bug.cgi?id=1228106
Haïkel Guémar karlthered@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |ihrachys@redhat.com Assignee|nobody@fedoraproject.org |karlthered@gmail.com Flags| |needinfo?(ihrachys@redhat.c | |om) rdo-review?
--- Comment #8 from Haïkel Guémar karlthered@gmail.com --- Missing Restart=on-failure in service otherwise good.
https://bugzilla.redhat.com/show_bug.cgi?id=1228106
Haïkel Guémar karlthered@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |CURRENTRELEASE Flags|needinfo?(ihrachys@redhat.c | |om) | Last Closed| |2016-09-01 11:13:47
--- Comment #9 from Haïkel Guémar karlthered@gmail.com --- Except minor point above, it's good, approved
Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
===== MUST items =====
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Apache (v2.0)", "Unknown or generated", "*No copyright* Apache (v2.0)". 20 files have unknown license. Detailed output of licensecheck in /home/haikel/1228106-openstack-neutron- vpnaas/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package requires other packages for directories it uses. Note: No known owner of /usr/share/neutron, /usr/share/neutron/server, /etc/neutron, /usr/share/neutron/l3_agent, /usr/share/neutron/rootwrap [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/neutron, /usr/share/neutron/rootwrap, /usr/share/neutron/server, /usr/lib/systemd/system, /etc/neutron, /usr/lib/systemd, /usr/share/neutron/l3_agent [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 3 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep
===== SHOULD items =====
Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python- neutron-vpnaas , python-neutron-vpnaas-tests [x]: Package functions as described. [x]: Latest version is packaged. [-]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment).
Rpmlint ------- Checking: openstack-neutron-vpnaas-2015.1.0-3.el7.noarch.rpm python-neutron-vpnaas-2015.1.0-3.el7.noarch.rpm python-neutron-vpnaas-tests-2015.1.0-3.el7.noarch.rpm openstack-neutron-vpnaas-2015.1.0-3.el7.src.rpm openstack-neutron-vpnaas.noarch: W: invalid-url URL: http://launchpad.net/neutron/ HTTP Error 503: Service Temporarily Unavailable openstack-neutron-vpnaas.noarch: W: non-standard-gid /etc/neutron/vpn_agent.ini neutron openstack-neutron-vpnaas.noarch: E: non-readable /etc/neutron/vpn_agent.ini 640 openstack-neutron-vpnaas.noarch: W: non-standard-gid /etc/neutron/neutron_vpnaas.conf neutron openstack-neutron-vpnaas.noarch: E: non-readable /etc/neutron/neutron_vpnaas.conf 640 openstack-neutron-vpnaas.noarch: W: no-manual-page-for-binary neutron-vpn-agent openstack-neutron-vpnaas.noarch: W: no-manual-page-for-binary neutron-vpn-netns-wrapper python-neutron-vpnaas.noarch: W: invalid-url URL: http://launchpad.net/neutron/ The read operation timed out python-neutron-vpnaas.noarch: W: no-documentation python-neutron-vpnaas-tests.noarch: W: invalid-url URL: http://launchpad.net/neutron/ HTTP Error 503: Service Temporarily Unavailable python-neutron-vpnaas-tests.noarch: W: no-documentation python-neutron-vpnaas-tests.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/neutron_vpnaas/tests/contrib/gate_hook.sh 644 /bin/bash python-neutron-vpnaas-tests.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/neutron_vpnaas/tests/contrib/post_test_hook.sh 644 /bin/bash openstack-neutron-vpnaas.src: W: invalid-url URL: http://launchpad.net/neutron/ HTTP Error 503: Service Temporarily Unavailable openstack-neutron-vpnaas.src: W: invalid-url Source0: http://launchpad.net/neutron/kilo/2015.1.0/+download/neutron-vpnaas-2015.1.0... The read operation timed out 4 packages and 0 specfiles checked; 4 errors, 11 warnings.
Rpmlint (installed packages) ---------------------------- python-neutron-vpnaas.noarch: W: invalid-url URL: http://launchpad.net/neutron/ <urlopen error [Errno -2] Name or service not known> python-neutron-vpnaas.noarch: W: no-documentation openstack-neutron-vpnaas.noarch: W: invalid-url URL: http://launchpad.net/neutron/ <urlopen error [Errno -2] Name or service not known> openstack-neutron-vpnaas.noarch: W: only-non-binary-in-usr-lib openstack-neutron-vpnaas.noarch: W: non-standard-gid /etc/neutron/vpn_agent.ini neutron openstack-neutron-vpnaas.noarch: E: non-readable /etc/neutron/vpn_agent.ini 0640L openstack-neutron-vpnaas.noarch: W: non-standard-gid /etc/neutron/neutron_vpnaas.conf neutron openstack-neutron-vpnaas.noarch: E: non-readable /etc/neutron/neutron_vpnaas.conf 0640L openstack-neutron-vpnaas.noarch: W: no-manual-page-for-binary neutron-vpn-netns-wrapper openstack-neutron-vpnaas.noarch: W: no-manual-page-for-binary neutron-vpn-agent python-neutron-vpnaas-tests.noarch: W: invalid-url URL: http://launchpad.net/neutron/ <urlopen error [Errno -2] Name or service not known> python-neutron-vpnaas-tests.noarch: W: no-documentation python-neutron-vpnaas-tests.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/neutron_vpnaas/tests/contrib/gate_hook.sh 0644L /bin/bash python-neutron-vpnaas-tests.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/neutron_vpnaas/tests/contrib/post_test_hook.sh 0644L /bin/bash 3 packages and 0 specfiles checked; 4 errors, 10 warnings.
Diff spec file in url and in SRPM --------------------------------- --- /home/haikel/1228106-openstack-neutron-vpnaas/srpm/openstack-neutron-vpnaas.spec 2016-09-01 15:35:57.835618357 +0200 +++ /home/haikel/1228106-openstack-neutron-vpnaas/srpm-unpacked/openstack-neutron-vpnaas.spec 2015-06-04 13:53:48.000000000 +0200 @@ -87,5 +87,5 @@ export PBR_VERSION=%{version} export SKIP_PIP_INSTALL=1 -%{__python2} setup.py install -O1 --skip-build --root %{buildroot} +%{__python2} setup.py install -O1 --skip-build --root $RPM_BUILD_ROOT
# Move rootwrap files to proper location
Requires -------- python-neutron-vpnaas (rpmlib, GLIBC filtered): python(abi) python-alembic python-jinja2 python-netaddr python-neutron python-oslo-config python-oslo-db python-oslo-log python-oslo-messaging python-oslo-serialization python-oslo-utils python-pbr python-requests python-six python-sqlalchemy
openstack-neutron-vpnaas (rpmlib, GLIBC filtered): /bin/sh /usr/bin/python2 config(openstack-neutron-vpnaas) openstack-neutron python-neutron-vpnaas
python-neutron-vpnaas-tests (rpmlib, GLIBC filtered): python(abi) python-neutron-vpnaas
Provides -------- python-neutron-vpnaas: python-neutron-vpnaas
openstack-neutron-vpnaas: config(openstack-neutron-vpnaas) openstack-neutron-vpn-agent openstack-neutron-vpnaas
python-neutron-vpnaas-tests: python-neutron-vpnaas-tests
Source checksums ---------------- http://launchpad.net/neutron/kilo/2015.1.0/+download/neutron-vpnaas-2015.1.0... : CHECKSUM(SHA256) this package : 20750cd8eb4e48a0eaa98262c5d7e3c1e55de2cfc93039a9ad1fa6d4c14cb566 CHECKSUM(SHA256) upstream package : 20750cd8eb4e48a0eaa98262c5d7e3c1e55de2cfc93039a9ad1fa6d4c14cb566
Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -b 1228106 -m rdo-mitaka-el7 Buildroot used: cloud7-openstack-mitaka-el7-build Active plugins: Python, Generic, Shell-api Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
https://bugzilla.redhat.com/show_bug.cgi?id=1228106
Haïkel Guémar karlthered@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|rdo-review? |rdo-review+
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla