[Bug 1354113] New: Review Request: python-pytest-catchlog - py.test plugin to catch log messages ( fork of pytest-capturelog) - package-review

List overview All Threads
Download

newer

[Bug 1354113] New: Review Request: python-pytest-catchlog - py.test plugin to catch log messages ( fork of pytest-capturelog)

older

[Bug 1348162] New: Review Request:...

[Bug 505154] Tracker: Review...

Red Hat Bugzilla

9 Jul 2016 9 Jul '16

12:21 p.m.

https://bugzilla.redhat.com/show_bug.cgi?id=1354113

Bug ID: 1354113 Summary: Review Request: python-pytest-catchlog - py.test plugin to catch log messages (fork of pytest-capturelog) Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: denis@fateyev.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org

Spec URL: http://www.fateyev.com/RPMS/Fedora24/python-pytest-catchlog.spec SRPM URL: http://www.fateyev.com/RPMS/Fedora24/python-pytest-catchlog-1.2.2-1.fc25.src... Description: py.test plugin to catch log messages. This is a fork of pytest-capturelog. Fedora Account System Username: dfateyev

Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=14834763 (Rawhide) http://koji.fedoraproject.org/koji/taskinfo?taskID=14834812 (Fedora 24) http://koji.fedoraproject.org/koji/taskinfo?taskID=14834716 (EPEL 7)

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Show replies by thread

Red Hat Bugzilla

25 Jul 25 Jul

5:39 p.m.

New subject: [Bug 1354113] Review Request: python-pytest-catchlog - py.test plugin to catch log messages ( fork of pytest-capturelog)

https://bugzilla.redhat.com/show_bug.cgi?id=1354113

Orion Poplawski orion@cora.nwra.com changed:

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

5:44 p.m.

New subject: [Bug 1354113] Review Request: python-pytest-catchlog - py.test plugin to catch log messages ( fork of pytest-capturelog)

https://bugzilla.redhat.com/show_bug.cgi?id=1354113

--- Comment #1 from Orion Poplawski orion@cora.nwra.com --- Package Review ==============

Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed

[!]: %check is present and all tests pass.

===== MUST items =====

Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 3 files have unknown license. Detailed output of licensecheck in /export/home/orion/redhat/python-pytest- catchlog-1.2.2/1354113-python-pytest-catchlog/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package requires other packages for directories it uses. Note: No known owner of /usr/share/licenses [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/licenses [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 40960 bytes in 4 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local

Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM.

Rpmlint ------- Checking: python2-pytest-catchlog-1.2.2-1.el7.noarch.rpm python34-pytest-catchlog-1.2.2-1.el7.noarch.rpm python-pytest-catchlog-1.2.2-1.el7.src.rpm python2-pytest-catchlog.noarch: W: summary-not-capitalized C py.test plugin to catch log messages (fork of pytest-capturelog) python34-pytest-catchlog.noarch: W: summary-not-capitalized C py.test plugin to catch log messages (fork of pytest-capturelog) python-pytest-catchlog.src: W: summary-not-capitalized C py.test plugin to catch log messages (fork of pytest-capturelog) 3 packages and 0 specfiles checked; 2 errors, 3 warnings.

Rpmlint (installed packages) ---------------------------- python34-pytest-catchlog.noarch: W: summary-not-capitalized C py.test plugin to catch log messages (fork of pytest-capturelog) python2-pytest-catchlog.noarch: W: summary-not-capitalized C py.test plugin to catch log messages (fork of pytest-capturelog) 2 packages and 0 specfiles checked; 2 errors, 2 warnings.

Requires -------- python34-pytest-catchlog (rpmlib, GLIBC filtered): python(abi)

python2-pytest-catchlog (rpmlib, GLIBC filtered): python(abi)

Provides -------- python34-pytest-catchlog: python34-pytest-catchlog

python2-pytest-catchlog: python-pytest-catchlog python2-pytest-catchlog

Source checksums ---------------- https://files.pythonhosted.org/packages/source/p/pytest-catchlog/pytest-catc... : CHECKSUM(SHA256) this package : 4be15dc5ac1750f83960897f591453040dff044b5966fe24a91c2f7d04ecfcf0 CHECKSUM(SHA256) upstream package : 4be15dc5ac1750f83960897f591453040dff044b5966fe24a91c2f7d04ecfcf0

Generated by fedora-review 0.5.3 (bcf15e3) last change: 2015-05-04 Command line :/usr/bin/fedora-review -b 1354113 Buildroot used: epel-7-x86_64 Active plugins: Python, Generic, Shell-api Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

5 Aug 5 Aug

2:47 p.m.

New subject: [Bug 1354113] Review Request: python-pytest-catchlog - py.test plugin to catch log messages ( fork of pytest-capturelog)

https://bugzilla.redhat.com/show_bug.cgi?id=1354113

--- Comment #2 from Denis Fateyev denis@fateyev.com --- Sorry for the delay. Added test suite to the spec.

Spec URL: http://www.fateyev.com/RPMS/Fedora24/python-pytest-catchlog.spec SRPM URL: http://www.fateyev.com/RPMS/Fedora24/python-pytest-catchlog-1.2.2-2.fc26.src...

Koji scratch builds: http://koji.fedoraproject.org/koji/taskinfo?taskID=15146390 (Rawhide) http://koji.fedoraproject.org/koji/taskinfo?taskID=15146430 (Fedora 25) http://koji.fedoraproject.org/koji/taskinfo?taskID=15146383 (EPEL 7)

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

4 Sep 4 Sep

10:11 a.m.

New subject: [Bug 1354113] Review Request: python-pytest-catchlog - py.test plugin to catch log messages ( fork of pytest-capturelog)

https://bugzilla.redhat.com/show_bug.cgi?id=1354113

Denis Fateyev denis@fateyev.com changed:

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

12 Sep 12 Sep

11:48 a.m.

New subject: [Bug 1354113] Review Request: python-pytest-catchlog - py.test plugin to catch log messages ( fork of pytest-capturelog)

https://bugzilla.redhat.com/show_bug.cgi?id=1354113

Orion Poplawski orion@cora.nwra.com changed:

--- Comment #3 from Orion Poplawski orion@cora.nwra.com --- Sorry for the delay, approved.

Please remove the %python3_pkgversion conditional definition - it's not needed anymore.

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

17 Sep 17 Sep

11:15 a.m.

New subject: [Bug 1354113] Review Request: python-pytest-catchlog - py.test plugin to catch log messages ( fork of pytest-capturelog)

https://bugzilla.redhat.com/show_bug.cgi?id=1354113

Denis Fateyev denis@fateyev.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo+ |fedora-review?

--- Comment #4 from Denis Fateyev denis@fateyev.com --- Indeed, Fedora 23 also got '%python3_pkgversion' support, I'll remove it during import. Could you approve the request?

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

18 Sep 18 Sep

11:36 a.m.

New subject: [Bug 1354113] Review Request: python-pytest-catchlog - py.test plugin to catch log messages ( fork of pytest-capturelog)

https://bugzilla.redhat.com/show_bug.cgi?id=1354113

Orion Poplawski orion@cora.nwra.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+

--- Comment #5 from Orion Poplawski orion@cora.nwra.com --- Ah, looks like I set the wrong flag. Done.

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

19 Sep 19 Sep

7:48 a.m.

New subject: [Bug 1354113] Review Request: python-pytest-catchlog - py.test plugin to catch log messages ( fork of pytest-capturelog)

https://bugzilla.redhat.com/show_bug.cgi?id=1354113

--- Comment #6 from Jon Ciesla limburgher@gmail.com --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/python-pytest-catchlog

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

9:46 a.m.

New subject: [Bug 1354113] Review Request: python-pytest-catchlog - py.test plugin to catch log messages ( fork of pytest-capturelog)

https://bugzilla.redhat.com/show_bug.cgi?id=1354113

--- Comment #7 from Fedora Update System updates@fedoraproject.org --- python-pytest-catchlog-1.2.2-2.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-a3e3bff7b1

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

9:46 a.m.

New subject: [Bug 1354113] Review Request: python-pytest-catchlog - py.test plugin to catch log messages ( fork of pytest-capturelog)

https://bugzilla.redhat.com/show_bug.cgi?id=1354113

Fedora Update System updates@fedoraproject.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

9:46 a.m.

New subject: [Bug 1354113] Review Request: python-pytest-catchlog - py.test plugin to catch log messages ( fork of pytest-capturelog)

https://bugzilla.redhat.com/show_bug.cgi?id=1354113

--- Comment #8 from Fedora Update System updates@fedoraproject.org --- python-pytest-catchlog-1.2.2-2.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-e1602d69d6

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

9:46 a.m.

New subject: [Bug 1354113] Review Request: python-pytest-catchlog - py.test plugin to catch log messages ( fork of pytest-capturelog)

https://bugzilla.redhat.com/show_bug.cgi?id=1354113

--- Comment #9 from Fedora Update System updates@fedoraproject.org --- python-pytest-catchlog-1.2.2-2.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2016-42f09d7ea7

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

9:46 a.m.

New subject: [Bug 1354113] Review Request: python-pytest-catchlog - py.test plugin to catch log messages ( fork of pytest-capturelog)

https://bugzilla.redhat.com/show_bug.cgi?id=1354113

--- Comment #10 from Fedora Update System updates@fedoraproject.org --- python-pytest-catchlog-1.2.2-2.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-5ae36859d6

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

20 Sep 20 Sep

2:57 p.m.

New subject: [Bug 1354113] Review Request: python-pytest-catchlog - py.test plugin to catch log messages ( fork of pytest-capturelog)

https://bugzilla.redhat.com/show_bug.cgi?id=1354113

Fedora Update System updates@fedoraproject.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA

--- Comment #11 from Fedora Update System updates@fedoraproject.org --- python-pytest-catchlog-1.2.2-2.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-42f09d7ea7

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

21 Sep 21 Sep

8:18 p.m.

New subject: [Bug 1354113] Review Request: python-pytest-catchlog - py.test plugin to catch log messages ( fork of pytest-capturelog)

https://bugzilla.redhat.com/show_bug.cgi?id=1354113

--- Comment #12 from Fedora Update System updates@fedoraproject.org --- python-pytest-catchlog-1.2.2-2.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-5ae36859d6

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

8:25 p.m.

New subject: [Bug 1354113] Review Request: python-pytest-catchlog - py.test plugin to catch log messages ( fork of pytest-capturelog)

https://bugzilla.redhat.com/show_bug.cgi?id=1354113

--- Comment #13 from Fedora Update System updates@fedoraproject.org --- python-pytest-catchlog-1.2.2-2.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-a3e3bff7b1

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

8:26 p.m.

New subject: [Bug 1354113] Review Request: python-pytest-catchlog - py.test plugin to catch log messages ( fork of pytest-capturelog)

https://bugzilla.redhat.com/show_bug.cgi?id=1354113

--- Comment #14 from Fedora Update System updates@fedoraproject.org --- python-pytest-catchlog-1.2.2-2.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-e1602d69d6

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

26 Sep 26 Sep

7:37 p.m.

New subject: [Bug 1354113] Review Request: python-pytest-catchlog - py.test plugin to catch log messages ( fork of pytest-capturelog)

https://bugzilla.redhat.com/show_bug.cgi?id=1354113

Fedora Update System updates@fedoraproject.org changed:

--- Comment #15 from Fedora Update System updates@fedoraproject.org --- python-pytest-catchlog-1.2.2-2.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

29 Sep 29 Sep

5:51 p.m.

New subject: [Bug 1354113] Review Request: python-pytest-catchlog - py.test plugin to catch log messages ( fork of pytest-capturelog)

https://bugzilla.redhat.com/show_bug.cgi?id=1354113

--- Comment #16 from Fedora Update System updates@fedoraproject.org --- python-pytest-catchlog-1.2.2-2.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

30 Sep 30 Sep

10:52 a.m.

New subject: [Bug 1354113] Review Request: python-pytest-catchlog - py.test plugin to catch log messages ( fork of pytest-capturelog)

https://bugzilla.redhat.com/show_bug.cgi?id=1354113

--- Comment #17 from Fedora Update System updates@fedoraproject.org --- python-pytest-catchlog-1.2.2-2.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

6 Oct 6 Oct

3:21 p.m.

New subject: [Bug 1354113] Review Request: python-pytest-catchlog - py.test plugin to catch log messages ( fork of pytest-capturelog)

https://bugzilla.redhat.com/show_bug.cgi?id=1354113

--- Comment #18 from Fedora Update System updates@fedoraproject.org --- python-pytest-catchlog-1.2.2-2.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

3211

Age (days ago)

3300

Last active (days ago)

package-review@lists.fedoraproject.org

21 comments

1 participants

tags (0)

participants (1)

Red Hat Bugzilla