[Bug 825495] New: Review Request: redmine - A flexible project management web application written in Ruby
https://bugzilla.redhat.com/show_bug.cgi?id=825495
Bug ID: 825495 QA Contact: extras-qa@fedoraproject.org Severity: medium Version: rawhide Priority: medium CC: notting@redhat.com, package-review@lists.fedoraproject.org Assignee: nobody@fedoraproject.org Summary: Review Request: redmine - A flexible project management web application written in Ruby Regression: --- Story Points: --- Classification: Fedora OS: Linux Reporter: codehotter@gmail.com Type: --- Documentation: --- Hardware: All Mount Type: --- Status: NEW Component: Package Review Product: Fedora
Spec URL: http://xls01.freecult.org/pkg/?p=pkg.git;a=blob_plain;f=SPECS/redmine.spec;h... SRPM URL: http://xls01.freecult.org/pkg/?p=pkg.git;a=blob_plain;f=SRPMS/redmine-2.0.0-... Description: http://www.redmine.org Fedora Account System Username: codehotter
Rpmlints: http://xls01.freecult.org/pkg/?p=pkg.git;a=blob_plain;f=LINTS/redmine-2.0.0-... http://xls01.freecult.org/pkg/?p=pkg.git;a=blob_plain;f=LINTS/redmine-2.0.0-... http://xls01.freecult.org/pkg/?p=pkg.git;a=blob_plain;f=LINTS/redmine-rmagic... http://xls01.freecult.org/pkg/?p=pkg.git;a=blob_plain;f=LINTS/redmine-setup-...
Changelog: http://xls01.freecult.org/pkg/?p=pkg.git;a=shortlog;h=refs/heads/redmine
Tree: http://xls01.freecult.org/pkg/?p=pkg.git;a=tree;hb=redmine
Redmine has been submitted for review previously https://bugzilla.redhat.com/show_bug.cgi?id=499959 That review has been abandoned.
At the time of writing, while package builds in mock and does work, this package is really not ready for inclusion in Fedora. I want to submit it anyway to hopefully get some comments and some help. These are currently the main issues:
- Fedora 18 does not yet have rubygem-rails 3.2.3 which redmine requires. - Redmine bundles 3rd party code
acts_as_activity_provider acts_as_attachable acts_as_customizable acts_as_event acts_as_list acts_as_searchable acts_as_tree acts_as_versioned acts_as_watchable awesome_nested_set classic_pagination gravatar prototype_legacy_helper rfpdf
- rpmlint is far from silent. I really have no idea what is safe for me to fix and what isn't, and frankly I'm a bit overwhelmed by the amount of errors.
- Redmine needs an application server to run under, the most common of which is passenger. At the time of writing, rubygem-passenger is still under review for Fedora: https://bugzilla.redhat.com/show_bug.cgi?id=470696
If you have ideas to fix some of the rpmlint errors and unbundle the 3rd party software redmine bundles, I could use your help.
I have written a README.fedora and a redmine-setup script to help new users install redmine on fedora. I would much appreciate it if you could look these over and see if they are OK. This is first time I've written a readme or an installation script for Fedora.
Of course I will keep working on this. As I update the git repo, the links in this post should stay current. They link to the latest version.
The rubygem-rails-3.2.3 rpms that you can find by clicking on the 'tree' link are fake - completely not compliant with packaging guidelines. I have used those rpms as a stopgap solution to continue working on redmine until rails 3.2.3 is in Fedora 18.
Thank you for your time.
https://bugzilla.redhat.com/show_bug.cgi?id=825495
Emanuel Rietveld codehotter@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |825493, 825492 Whiteboard| |NotReady
https://bugzilla.redhat.com/show_bug.cgi?id=825495
Jan Klepek jan.klepek@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |jan.klepek@gmail.com
--- Comment #1 from Jan Klepek jan.klepek@gmail.com --- when I worked on separation of 3rd party code outside, i have noticed that some of that is no longer supported by upstream (for example rfpdf, last commit in 2006, upstream web site no longer exists, etc..) also classic_pagination was deprecated by upstream 2 years ago in this cases, you would need to act as upstream when you will split those libraries into separate package. i suggest that you consider packaging ChiliProject (fork of redmine) due to wider development support (you are more likely to convince them to abandon classsic_pagination and replace it with will_paginate, or other necessary code changes)
https://bugzilla.redhat.com/show_bug.cgi?id=825495
Peter Lemenkov lemenkov@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |david.hannequin@gmail.com
--- Comment #2 from Peter Lemenkov lemenkov@gmail.com --- *** Bug 499959 has been marked as a duplicate of this bug. ***
https://bugzilla.redhat.com/show_bug.cgi?id=825495
Bohuslav "Slavek" Kabrda bkabrda@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |bkabrda@redhat.com
--- Comment #3 from Bohuslav "Slavek" Kabrda bkabrda@redhat.com --- Emanuel, I'm not sure we want redmine in Fedora. It would make us always have its specified version of rails. I don't think we want to have our hands tied with that. What if we want to get rails 4 (when they get released) into Fedora and redmine still relies on 3.2.3? This would limit us greatly, I have to say I am against that.
A solution to your problem might be creating a software collection [1], [2], which would be independent on system Gems versions. Unfortunately, software collections are not allowed into Fedora [3] - but I believe that if enough users would want to use them for projects like this, FPC would allow them. Redmine is a great candidate for a software collection, I think.
[1] http://docs.fedoraproject.org/en-US/Fedora_Contributor_Documentation/1/html/... [2] https://fedorahosted.org/SoftwareCollections/ [3] https://fedoraproject.org/wiki/Packaging:Guidelines#Software_Collection_Macr...
https://bugzilla.redhat.com/show_bug.cgi?id=825495
Bug 825495 depends on bug 825492, which changed state.
Bug 825492 Summary: RFE: update to 3.2.3 please https://bugzilla.redhat.com/show_bug.cgi?id=825492
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |RAWHIDE
https://bugzilla.redhat.com/show_bug.cgi?id=825495
Adam Tkac vonsch@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |vonsch@gmail.com
--- Comment #4 from Adam Tkac vonsch@gmail.com --- (In reply to Bohuslav "Slavek" Kabrda from comment #3)
Emanuel, I'm not sure we want redmine in Fedora. It would make us always have its specified version of rails. I don't think we want to have our hands tied with that. What if we want to get rails 4 (when they get released) into Fedora and redmine still relies on 3.2.3? This would limit us greatly, I have to say I am against that.
A solution to your problem might be creating a software collection [1], [2], which would be independent on system Gems versions. Unfortunately, software collections are not allowed into Fedora [3] - but I believe that if enough users would want to use them for projects like this, FPC would allow them. Redmine is a great candidate for a software collection, I think.
I don't think it's right decision to ban redmine from Fedora because it's upstream doesn't port it to the latest rails immediately after it gets released. I'm not ruby/rails expert but in my opinion situation when redmine (or other rails project) depends on older rails and you want new rails in distro before redmine gets ported, you can create rails-compat package with old rails and update the main rails pkg. There are many examples of this approach in distro (gtk2/gtk3, qt3/qt and various .*compat.* packages with their latest counterparts). Or is not possible to have two packages of rails same time in Fedora without package collections?
https://bugzilla.redhat.com/show_bug.cgi?id=825495
--- Comment #5 from Vít Ondruch vondruch@redhat.com --- Nobody bans Redmine. We only lack the menpower. We are speaking here about up to 50+- packages which needs to be maintained.
https://bugzilla.redhat.com/show_bug.cgi?id=825495
--- Comment #6 from Adam Tkac vonsch@gmail.com --- (In reply to Vít Ondruch from comment #5)
Nobody bans Redmine. We only lack the menpower. We are speaking here about up to 50+- packages which needs to be maintained.
If I understand correctly, maintaining two versions of rails simultaneously means maintaining rails and additional 49 compat packages? Or you meant that redmine will require additional 50+- packages in distro?
https://bugzilla.redhat.com/show_bug.cgi?id=825495
--- Comment #7 from Vít Ondruch vondruch@redhat.com --- The core of RoR consist of 8 packages. However, these packages has another dependencies and enforces their specific versions. You can start with RDoc, continue with minitest, sprockets, etc.
https://bugzilla.redhat.com/show_bug.cgi?id=825495
Murray McAllister mmcallis@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mmcallis@redhat.com
--- Comment #8 from Murray McAllister mmcallis@redhat.com --- Hello, a security flaw in redmine was reported:
http://seclists.org/oss-sec/2014/q2/18
If redmine is released in Fedora, could that fix please be included?
Thanks,
-- Murray McAllister / Red Hat Security Response Team
https://bugzilla.redhat.com/show_bug.cgi?id=825495
David Hannequin david.hannequin@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution|--- |WONTFIX Last Closed| |2015-08-17 05:52:47
--- Comment #9 from David Hannequin david.hannequin@gmail.com --- Hi,
Redmine isn't release in Fedora.
Best regard
https://bugzilla.redhat.com/show_bug.cgi?id=825495
Peter Lemenkov lemenkov@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|CLOSED |NEW Resolution|WONTFIX |--- Whiteboard|NotReady |NotReady, FutureFeature Keywords| |Reopened
https://bugzilla.redhat.com/show_bug.cgi?id=825495
David Hannequin david.hannequin@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution|--- |WONTFIX Last Closed|2015-08-17 05:52:47 |2016-10-25 12:58:45
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla