https://bugzilla.redhat.com/show_bug.cgi?id=1737580
Bug ID: 1737580 Summary: Review Request: umoci - umoci modifies open container images Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: jogas@lanl.gov QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://copr-be.cloud.fedoraproject.org/results/jogas/umoci/fedora-rawhide-x... SRPM URL: https://copr-be.cloud.fedoraproject.org/results/jogas/umoci/fedora-rawhide-x...
Description: simple package for umoci (umoci modifies Open Container images). FAS: jogas@lanl.gov Sponsor: Orion Poplawski
rpmlint output: $ rpmlint umoci 1 packages and 0 specfiles checked; 0 errors, 0 warnings
Note: Mock builds fail unless you enable internet access (e.g., 'rmpbuild_networking' = True). I'm not sure if this is normal or acceptable for go packages. Please advise.
Note: When you build umoci via `go build`, as the spec file does, it downloads from the following go packages:
github.com/opencontainers/go-digest v1.0.0-rc1 github.com/opencontainers/runtime-spec v1.0.0 github.com/mattn/go-colorable v0.0.9 github.com/mattn/go-isatty v0.0.3 github.com/hashicorp/errwrap v0.0.0-20180715044906-d6c0cd880357 github.com/blang/semver v3.5.1+incompatible github.com/opencontainers/image-spec v1.0.0 github.com/vbatts/go-mtree v0.4.3 github.com/fatih/color v1.7.0 github.com/xeipuuv/gojsonschema v0.0.0-20180719132039-b84684d0e066 github.com/cyphar/filepath-securejoin v0.2.2 github.com/xeipuuv/gojsonpointer v0.0.0-20180127040702-4e3ac2762d5f github.com/sirupsen/logrus v1.0.6 github.com/opencontainers/runtime-tools v0.7.0 github.com/klauspost/pgzip v0.0.0-20170402124221-0bf5dcad4ada github.com/golang/protobuf v1.2.0 github.com/hashicorp/go-multierror v0.0.0-20180717150148-3d5d8f294aa0 github.com/pkg/errors v0.8.0 github.com/syndtr/gocapability v0.0.0-20180223013746-33e07d32887e github.com/apex/log v1.1.0 github.com/klauspost/compress v1.4.0 github.com/urfave/cli v1.20.0 github.com/rootless-containers/proto v0.1.0 github.com/docker/go-units v0.3.3 github.com/klauspost/cpuid v0.0.0-20170728055534-ae7887de9fa5 github.com/xeipuuv/gojsonreference v0.0.0-20180127040603-bd5ef7bd5415 github.com/klauspost/crc32 v0.0.0-20161016154125-cb6bfca970f6 github.com/mohae/deepcopy v0.0.0-20170603005431-491d3605edfb
It is unclear as how these packages should be referenced e.g., virtual provides, requires, buildrequires, etc. Please advise.
https://bugzilla.redhat.com/show_bug.cgi?id=1737580
Elliott Sales de Andrade quantum.analyst@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |quantum.analyst@gmail.com
--- Comment #1 from Elliott Sales de Andrade quantum.analyst@gmail.com --- You cannot use the network when building packages. All those dependencies will need to be packaged as well (most of them already are, in fact).
You should also follow the guidelines for Go packages: https://docs.fedoraproject.org/en-US/packaging-guidelines/Golang/ Try using go2rpm to automate all this.
https://bugzilla.redhat.com/show_bug.cgi?id=1737580
Robert-André Mauchin zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |zebob.m@gmail.com
--- Comment #2 from Robert-André Mauchin zebob.m@gmail.com --- Use go2rpm github.com/openSUSE/umoci for F31 to use the new macros.
Use go2rpm -p1 github.com/openSUSE/umoci to use on F30/F29 with the old macros.
You'll need to package github.com/mohae/deepcopy and github.com/rootless-containers/proto the same way
https://bugzilla.redhat.com/show_bug.cgi?id=1737580
jogas@lanl.gov changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution|--- |DEFERRED Last Closed| |2020-08-17 14:03:01
--- Comment #4 from jogas@lanl.gov --- I no longer have a need to package umoci. Closing.
Product: Fedora Version: rawhide Component: Package Review
jogas@lanl.gov has denied Package Review package-review@lists.fedoraproject.org's request for jogas@lanl.gov's needinfo: Bug 1737580: Review Request: umoci - umoci modifies open container images https://bugzilla.redhat.com/show_bug.cgi?id=1737580
https://bugzilla.redhat.com/show_bug.cgi?id=1737580
jogas@lanl.gov changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(jogas@lanl.gov) |needinfo-
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com