[Bug 1947088] New: Review Request: rust-oauth2 - Extensible, strongly-typed implementation of OAuth2

https://bugzilla.redhat.com/show_bug.cgi?id=1947088

Bug ID: 1947088
           Summary: Review Request: rust-oauth2 -  Extensible,
                    strongly-typed implementation of OAuth2
           Product: Fedora
           Version: rawhide
          Hardware: All
                OS: Linux
            Status: NEW
         Component: Package Review
          Severity: medium
          Priority: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]
  Target Milestone: ---
    Classification: Fedora

Spec URL: https://dentrassi.de/download/rust-oauth2/rust-oauth2.spec
SRPM URL:
https://dentrassi.de/download/rust-oauth2/rust-oauth2-3.0.0-1.fc35.src.rpm
Description: Extensible, strongly-typed implementation of OAuth2
Fedora Account System Username: ctron

[Bug 1947088] Review Request: rust-oauth2 - Extensible, strongly-typed implementation of OAuth2

https://bugzilla.redhat.com/show_bug.cgi?id=1947088

Robert-André Mauchin 🐧  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |[e-mail]
           Assignee|[e-mail]    |[e-mail]
           Doc Type|---                         |If docs needed, set a value
              Flags|                            |fedora-review?

--- Comment #1 from Robert-André Mauchin 🐧  ---
 - Please add a comment specifying your changes:

# Initial patched metadata
# * Bump sha2 to 0.9
# * Remove dependency on rust-crypto
# * Relax unicode-normalization dep
# * Relax hex dep
# * Set "reqwest-010" as default
Patch0:         oauth2-fix-metadata.diff

- Please use "rust2rpm -p" to generate the fix-metadata file:

--- oauth2-3.0.0/Cargo.toml     2020-06-14T16:44:33+00:00
+++ oauth2-3.0.0/Cargo.toml     2021-04-07T16:54:58.016547+00:00
@@ -78,18 +78,15 @@
 version = "1.0"

[dependencies.sha2]
-version = "0.8"
+version = "0.9"

[dependencies.unicode-normalization]
-version = "=0.1.9"
+version = "0.1.9"

[dependencies.url]
 version = "2.1"
 [dev-dependencies.hex]
-version = "=0.4.0"
-
-[dev-dependencies.rust-crypto]
-version = "0.2.36"
+version = "0.4.0"

[dev-dependencies.tokio]
 version = "0.1"
@@ -99,7 +96,7 @@
 features = ["v4"]

[features]
-default = ["reqwest-09"]
+default = ["reqwest-010"]
 futures-01 = ["futures-0-1"]
 futures-03 = ["futures-0-3", "async-trait"]
 reqwest-010 = ["reqwest-0-10", "http-0-2"]

- Please add any other modification in a separate patch.

- Instead of patching out examples, I'd recommend only testing the library and
doc and not the examples:

%if %{with check}
%check
%cargo_test -- --lib
%cargo_test -- --doc
%endif

- Add examples to devel:

%files          devel
%license LICENSE-MIT LICENSE-APACHE
%doc examples README.md
%{cargo_registry}/%{crate}-%{version_no_tilde}/

- License ok
 - Latest version packaged
 - Builds in mock
 - No rpmlint errors
 - Conforms to Packaging Guidelines

[Bug 1947088] Review Request: rust-oauth2 - Extensible, strongly-typed implementation of OAuth2

https://bugzilla.redhat.com/show_bug.cgi?id=1947088

--- Comment #2 from Jens Reimann  ---
Thanks for your help. I didn't know how "rust2rpm -p" worked, that is great!

I made the changes and re-uploaded the .spec/.rpm to the same location.

[Bug 1947088] Review Request: rust-oauth2 - Extensible, strongly-typed implementation of OAuth2

https://bugzilla.redhat.com/show_bug.cgi?id=1947088

Robert-André Mauchin 🐧  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |POST
              Flags|fedora-review?              |fedora-review+

--- Comment #3 from Robert-André Mauchin 🐧  ---
Package approved.

[Bug 1947088] Review Request: rust-oauth2 - Extensible, strongly-typed implementation of OAuth2

https://bugzilla.redhat.com/show_bug.cgi?id=1947088

--- Comment #4 from Gwyn Ciesla  ---
(fedscm-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/rust-oauth2

[Bug 1947088] Review Request: rust-oauth2 - Extensible, strongly-typed implementation of OAuth2

https://bugzilla.redhat.com/show_bug.cgi?id=1947088

Jens Reimann  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|POST                        |CLOSED
         Resolution|---                         |RAWHIDE
        Last Closed|                            |2021-04-09 08:25:26