https://bugzilla.redhat.com/show_bug.cgi?id=2330941
Bug ID: 2330941 Summary: Review Request: golang-github-chainguard-dev-git-urls - parse git urls Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: mark.e.fuller@gmx.de QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://download.copr.fedorainfracloud.org/results/fuller/go-task/fedora-raw... SRPM URL: https://download.copr.fedorainfracloud.org/results/fuller/go-task/fedora-raw... Description: Golang library for parsing git urls Fedora Account System Username: fuller
https://bugzilla.redhat.com/show_bug.cgi?id=2330941
Mark E. Fuller mark.e.fuller@gmx.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |2330797 Doc Type|--- |If docs needed, set a value
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2330797 [Bug 2330797] golang-github-task-3.40.1 is available
https://bugzilla.redhat.com/show_bug.cgi?id=2330941
Fedora Review Service fedora-review-bot@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |AutomationTriaged
--- Comment #1 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/8353423 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2330941
--- Comment #2 from Mark E. Fuller mark.e.fuller@gmx.de --- Adding OBSOLETES for golang-github-whilp-git-urls
Spec URL: https://download.copr.fedorainfracloud.org/results/fuller/go-task/fedora-raw... SRPM URL: https://download.copr.fedorainfracloud.org/results/fuller/go-task/fedora-raw...
https://bugzilla.redhat.com/show_bug.cgi?id=2330941
--- Comment #3 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Created attachment 2061516 --> https://bugzilla.redhat.com/attachment.cgi?id=2061516&action=edit The .spec file difference from Copr build 8353423 to 8353702
https://bugzilla.redhat.com/show_bug.cgi?id=2330941
--- Comment #4 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/8353702 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2330941
Mikel Olasagasti Uranga mikel@olasagasti.info changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@fedoraproject.org |mikel@olasagasti.info CC| |mikel@olasagasti.info Flags| |fedora-review+
--- Comment #5 from Mikel Olasagasti Uranga mikel@olasagasti.info --- Golang Package Review ==============
This package was generated using go2rpm, which simplifies the review.
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
- [x] The latest version is packaged or packaging an earlier version is justified. - [x] The License tag reflects the package contents and uses the correct identifiers. - [x] The package builds successfully in mock. - [x] Package is installable (checked by fedora-review). - [x] There are no relevant rpmlint errors. - [x] The package runs tests in %check. - [x] `%goipath` is set correctly. - [-] The package's binaries don't conflict with binaries already in the distribution. (Some Go projects include utility binaries with very generic names) - [-] There are no `%{_bindir}/*` wildcards in %files. (go2rpm includes these by default) - [x] The package does not use `%gometa -f` if it has dependents that still build for %ix86. - [x] The package complies with the Golang and general Packaging Guidelines.
Package approved! On import, don't forget to do the following:
- [ ] Add the package to release-monitoring.org - [ ] Give go-sig privileges (at least commit) on the package - [ ] Close the review bug by referencing its ID in the rpm changelog and the Bodhi ticket. - [ ] Consider configuring Packit service to help with maintenance
Thanks!
https://bugzilla.redhat.com/show_bug.cgi?id=2330941
Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RELEASE_PENDING
--- Comment #6 from Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org --- The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-chainguard-dev-git-urls
package-review@lists.fedoraproject.org