https://bugzilla.redhat.com/show_bug.cgi?id=2364275
Bug ID: 2364275 Summary: Review Request: rust-error-code - Error code Product: Fedora Version: rawhide URL: https://crates.io/crates/error-code Status: NEW Component: Package Review Assignee: nobody@fedoraproject.org Reporter: solomoncyj@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://solomoncyj.fedorapeople.org/reviews/rust-error-code/rust-error-code.... SRPM URL: https://solomoncyj.fedorapeople.org/reviews/rust-error-code/rust-error-code-...
Description: Error code.
Fedora Account System Username: solomoncyj
https://bugzilla.redhat.com/show_bug.cgi?id=2364275
Fedora Review Service fedora-review-bot@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |AutomationTriaged
--- Comment #1 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/8999725 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2364275
solomoncyj@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |2364277
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2364277 [Bug 2364277] Review Request: rust-nng-c - High level bindings nng C library
https://bugzilla.redhat.com/show_bug.cgi?id=2364275
Ben Beasley code@musicinmybrain.net changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |code@musicinmybrain.net
--- Comment #2 from Ben Beasley code@musicinmybrain.net --- Could you please update to 3.3.2, which contains your patch https://github.com/DoumanAsh/error-code/commit/80cdefff6552b95750221bd2bb8fa...
https://bugzilla.redhat.com/show_bug.cgi?id=2364275
--- Comment #3 from solomoncyj@gmail.com --- Spec URL: https://solomoncyj.fedorapeople.org/reviews/rust-error-code/rust-error-code.... SRPM URL: https://solomoncyj.fedorapeople.org/reviews/rust-error-code/rust-error-code-...
droped patches and updated crate
https://bugzilla.redhat.com/show_bug.cgi?id=2364275
Ben Beasley code@musicinmybrain.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@fedoraproject.org |code@musicinmybrain.net Flags| |fedora-review? Status|NEW |ASSIGNED
https://bugzilla.redhat.com/show_bug.cgi?id=2364275
Ben Beasley code@musicinmybrain.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ Status|ASSIGNED |POST
--- Comment #4 from Ben Beasley code@musicinmybrain.net --- The package is APPROVED.
Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
The spec file is exactly as generated by rust2rpm (except that rpmautospec macros are expanded), greatly simplifying the review.
Issues: ======= - Package does not contain duplicates in %files. Note: warning: File listed twice: /usr/share/cargo/registry/error- code-3.3.2/LICENSE See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_duplicate_files
Not a serious problem; due to a reasonable rust2rpm design decision.
===== MUST items =====
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* Boost Software License 1.0". 12 files have unknown license. Detailed output of licensecheck in /home/ben/fedora/review/2364275-rust-error-code/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: No rpmlint messages. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in rust- error-code-devel , rust-error-code+default-devel , rust-error- code+std-devel [x]: Package functions as described.
(tests pass)
[x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures.
https://koji.fedoraproject.org/koji/taskinfo?taskID=132827086
[x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [!]: Spec file according to URL is the same as in SRPM. Note: Spec file as given by url is not the same as in SRPM (see attached diff). See: (this test has no URL) [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment).
Rpmlint ------- Checking: rust-error-code-devel-3.3.2-1.fc43.noarch.rpm rust-error-code+default-devel-3.3.2-1.fc43.noarch.rpm rust-error-code+std-devel-3.3.2-1.fc43.noarch.rpm rust-error-code-3.3.2-1.fc43.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.7.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpeyus_ktu')] checks: 32, packages: 4
4 packages and 0 specfiles checked; 0 errors, 0 warnings, 19 filtered, 0 badness; has taken 0.1 s
Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output:
Source checksums ---------------- https://crates.io/api/v1/crates/error-code/3.3.2/download#/error-code-3.3.2.... : CHECKSUM(SHA256) this package : dea2df4cf52843e0452895c455a1a2cfbb842a1e7329671acf418fdc53ed4c59 CHECKSUM(SHA256) upstream package : dea2df4cf52843e0452895c455a1a2cfbb842a1e7329671acf418fdc53ed4c59
Requires -------- rust-error-code-devel (rpmlib, GLIBC filtered): cargo
rust-error-code+default-devel (rpmlib, GLIBC filtered): cargo crate(error-code)
rust-error-code+std-devel (rpmlib, GLIBC filtered): cargo crate(error-code)
Provides -------- rust-error-code-devel: crate(error-code) rust-error-code-devel
rust-error-code+default-devel: crate(error-code/default) rust-error-code+default-devel
rust-error-code+std-devel: crate(error-code/std) rust-error-code+std-devel
Diff spec file in url and in SRPM --------------------------------- --- /home/ben/fedora/review/2364275-rust-error-code/srpm/rust-error-code.spec 2025-05-16 07:26:00.102446139 -0400 +++ /home/ben/fedora/review/2364275-rust-error-code/srpm-unpacked/rust-error-code.spec 2025-05-15 20:00:00.000000000 -0400 @@ -1,2 +1,12 @@ +## START: Set by rpmautospec +## (rpmautospec version 0.8.1) +## RPMAUTOSPEC: autorelease, autochangelog +%define autorelease(e:s:pb:n) %{?-p:0.}%{lua: + release_number = 1; + base_release_number = tonumber(rpm.expand("%{?-b*}%{!?-b:1}")); + print(release_number + base_release_number - 1); +}%{?-e:.%{-e*}}%{?-s:.%{-s*}}%{!?-n:%{?dist}} +## END: Set by rpmautospec + # Generated by rust2rpm 27 %bcond check 1 @@ -78,3 +88,6 @@
%changelog -%autochangelog +## START: Generated by rpmautospec +* Fri May 16 2025 John Doe packager@example.com - 3.3.2-1 +- Uncommitted changes +## END: Generated by rpmautospec
Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2364275 Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic Disabled plugins: C/C++, PHP, fonts, Ocaml, Perl, R, Java, Haskell, Python, SugarActivity Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
https://bugzilla.redhat.com/show_bug.cgi?id=2364275
Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |RELEASE_PENDING
--- Comment #5 from Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org --- The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-error-code
https://bugzilla.redhat.com/show_bug.cgi?id=2364275
solomoncyj@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version| |rust-error-code-3.3.2-1.fc4 | |3 Status|RELEASE_PENDING |MODIFIED
https://bugzilla.redhat.com/show_bug.cgi?id=2364275
--- Comment #6 from Fedora Review Service fedora-review-bot@fedoraproject.org --- There seems to be some problem with the following file. SRPM URL: https://solomoncyj.fedorapeople.org/reviews/rust-error-code/rust-error-code-... Fetching it results in a 404 Not Found error. Please make sure the URL is correct and publicly available.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com