[Bug 781260] New: Review Request: leechcraft - A Free Open Source Cross-Platform Modular Internet-Client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: leechcraft - A Free Open Source Cross-Platform Modular Internet-Client
https://bugzilla.redhat.com/show_bug.cgi?id=781260
Summary: Review Request: leechcraft - A Free Open Source Cross-Platform Modular Internet-Client Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: nlminhtl@gmail.com QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: --- Regression: --- Mount Type: --- Documentation: ---
Spec URL: https://github.com/Ignotus/leechcraft-fedora/blob/e4493277dfe2fa3a7cc57cd193... SRPM URL: https://github.com/Ignotus/leechcraft-fedora/blob/e4493277dfe2fa3a7cc57cd193... Description: LeechCraft is a free modular "Internet client" application.
LeechCraft allows to browse the web, read RSS/Atom feeds, download files via BitTorrent, HTTP, FTP and DC, automatically stream, download or play podcasts and other media files and much more.
Features can be easily added via plugins that can be integrated with each other with no effort while staying abstract from the exact implementation.
This package contains the main LeechCraft executable, which connects all the plugins with each other, routes requests between them, tracks dependencies and performs several other housekeeping tasks.
To build it in koji please add qxmpp-dev-0.3.45.1 by "Buildroot Overrides" in bodhi if it's not already in the stable. ( https://bugzilla.redhat.com/show_bug.cgi?id=753262 )
There is the complete scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=3645191
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=781260
Minh Ngo nlminhtl@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |nlminhtl@gmail.com Blocks| |656997(kde-reviews)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=781260
Minh Ngo nlminhtl@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Alias| |leechcraft
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=781260
Rex Dieter rdieter@math.unl.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |rdieter@math.unl.edu
--- Comment #1 from Rex Dieter rdieter@math.unl.edu 2012-01-13 08:34:51 EST --- Offhand, I see a *lot* of sub-packages for plugins, which greatly adds complexity, for both packager (complicating .spec) and end-user (who's bombarded with an incredible number of choices about which ones to install. I hope you have good reason do want to do it this way?
Wrt buildroot overrides, you can do it yourself via bodhi, https://admin.fedoraproject.org/updates/override/
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=781260
--- Comment #2 from Minh Ngo nlminhtl@gmail.com 2012-01-13 10:29:33 EST --- I'm maintained these packages in openSUSE. And they are not very complexity for supporting.
A end-user can read a description of a package and decide to install it.
Every leechcraft package is a separate plugin that adds some functionality to the program. So they should not be in the single package.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=781260
--- Comment #3 from Minh Ngo nlminhtl@gmail.com 2012-01-13 10:30:21 EST --- s/I'm maintained/I'm maintaining/
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=781260
--- Comment #4 from Kevin Kofler kevin@tigcc.ticalc.org 2012-01-13 10:45:36 EST --- It looks indeed like that application is designed the Emacs way, where almost everything is a plugin…
I think there should be some metapackage dragging in the whole package with all the plugins, like eclipse-platform, netbeans-platform, wine (as opposed to wine-core) etc.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=781260
--- Comment #5 from Minh Ngo nlminhtl@gmail.com 2012-01-13 15:28:30 EST --- 0.4.98 Version with leechcraft-full metapackage
SPEC: https://github.com/Ignotus/leechcraft-fedora/blob/ece5fa08481bc1122cea1d2887... SRPM: https://github.com/Ignotus/leechcraft-fedora/blob/ece5fa08481bc1122cea1d2887...
Build: http://koji.fedoraproject.org/koji/taskinfo?taskID=3660003
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=781260
--- Comment #6 from Minh Ngo nlminhtl@gmail.com 2012-01-15 17:18:00 EST --- 0.4.98-2
SPEC: https://raw.github.com/Ignotus/leechcraft-fedora/2f22b10881f0ad359f8571c25a2...
SRPM: https://github.com/Ignotus/leechcraft-fedora/blob/2f22b10881f0ad359f8571c25a...
Build: http://koji.fedoraproject.org/koji/taskinfo?taskID=3701112
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=781260
--- Comment #7 from Minh Ngo nlminhtl@gmail.com 2012-01-15 17:34:34 EST --- leechcraft-full metapackage fix
SPEC: https://raw.github.com/Ignotus/leechcraft-fedora/f6f532d51edb582e7949a9d7d16...
SRPM: https://github.com/Ignotus/leechcraft-fedora/blob/f6f532d51edb582e7949a9d7d1...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=781260
--- Comment #8 from Minh Ngo nlminhtl@gmail.com 2012-02-07 14:19:52 EST --- 0.4.98-3
Fixing the package leechcraft-acetamide name. Fixing the description for the main package.
SPEC: https://raw.github.com/Ignotus/leechcraft-fedora/c4067c7b838317585ae6f0f063e...
SRPM
https://github.com/Ignotus/leechcraft-fedora/blob/c4067c7b838317585ae6f0f063...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=781260
--- Comment #9 from Minh Ngo nlminhtl@gmail.com 2012-02-07 15:04:32 EST --- 0.4.99
Build: http://koji.fedoraproject.org/koji/taskinfo?taskID=3769978
SPEC: https://raw.github.com/Ignotus/leechcraft-fedora/c12f03d04cdeb1269f962dbbf29...
SRPM: https://github.com/Ignotus/leechcraft-fedora/blob/master/leechcraft-0.4.99-1...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=781260
Rex Dieter rdieter@math.unl.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@fedoraproject.org |rdieter@math.unl.edu Flag| |fedora-review?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=781260
Rex Dieter rdieter@math.unl.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|rdieter@math.unl.edu |nobody@fedoraproject.org Flag|fedora-review? |
--- Comment #10 from Rex Dieter rdieter@math.unl.edu 2012-02-14 13:45:00 EST --- I was about to start review, but will be busy until at least the 20th, so I'll pick it up again then if no one beats me to it.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=781260
--- Comment #11 from Minh Ngo nlminhtl@gmail.com 2012-02-19 09:12:47 EST --- 0.5.0
SPEC: https://raw.github.com/Ignotus/leechcraft-fedora/efdbcc5891646c13aac1b506984...
SRPM: https://github.com/Ignotus/leechcraft-fedora/blob/master/leechcraft-0.5.0-1....
BUILD: http://koji.fedoraproject.org/koji/taskinfo?taskID=3802820
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=781260
Rex Dieter rdieter@math.unl.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@fedoraproject.org |rdieter@math.unl.edu Flag| |fedora-review?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=781260
--- Comment #12 from Rex Dieter rdieter@math.unl.edu 2012-03-06 12:33:05 EST --- OK, sorry for the delay.
1. Naming: mostly ok, but subpkg dependencies SHOULD be fully versioned, for example, instead of: Requires: %{name}-iconset use Requires: %{name}-iconset = %{full_version}
and in -iconset-oxygen subpkg,
Provides: %{name}-iconset = %{full_version}
*unless*, you ever intend to provide alternative iconset's provided elsewhere? If so, then best leave off the versioning.
2. macros. SHOULD remove %if "%{_lib}" == "lib64" -DLIB_SUFFIX=64 \ %endif snippet, default %{cmake} macro already includes that. see /etc/rpm/macros.cmake
3. scriptlets. MUST main pkg, iconset-oxygen, iconset-tango are lacking icon-related scriptlets, see http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache
4. qm translation files SHOULD be marked with %lang(locale) tags, but I'm not sure if that's practical here. if you can figure out a way to do that in an easy way, great. if not, don't worry about it.
Sources: ok 7daefb3130a475f9260eac069942076e leechcraft-0.5.0.tar.xz
Licensing: ok most code is GPLv3+, sprinkled with some LGPLv2+ and GPLv2+, so combined result is indeed GPLv2+
Address items 1-4, and we're looking good.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=781260
--- Comment #13 from Kevin Kofler kevin@tigcc.ticalc.org 2012-03-06 12:51:37 EST --- As I understand the guidelines, proper handling of translations (point 4) is a MUST, not a SHOULD.
You should just need multiple %find_lang --with-qt --without-mo calls at the end of %install. See how I did this in the Qt package itself: http://pkgs.fedoraproject.org/gitweb/?p=qt.git;a=blob;f=qt.spec;h=a90b1ce0f1...
You should also be able to use %find_lang for the eiskaltdcpp translations instead of listing every language by hand. (And by the way, those are gettext translations, why aren't they in /usr/share/locale?)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=781260
--- Comment #14 from Minh Ngo nlminhtl@gmail.com 2012-03-10 17:32:56 EST --- Kevin, translation files are not in the standard directory, so I can't find their with %find_lang macro.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=781260
--- Comment #15 from Minh Ngo nlminhtl@gmail.com 2012-03-10 17:40:16 EST --- I don't know why they aren't in /usr/share/locale, but I can fix with something like: root_dir=`echo ${RPM_BUILD_ROOT} | sed 's,/,\/,g'` find ${RPM_BUILD_ROOT}%{translations_dir} -name libeiskaltdcpp.mo | sed 's/^.*ions/([a-z]*)/LC.*/%lang(\1) \0/g;s/'$root_dir'//g' > libeiskaltdcpp.lang
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=781260
--- Comment #16 from Minh Ngo nlminhtl@gmail.com 2012-03-10 18:56:51 EST --- 0.5.0-2
SPEC: https://raw.github.com/Ignotus/leechcraft-fedora/751542519992278037bca5a42e1...
SRPM: https://github.com/Ignotus/leechcraft-fedora/blob/751542519992278037bca5a42e...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=781260
--- Comment #17 from Minh Ngo nlminhtl@gmail.com 2012-03-11 14:20:11 EDT --- 0.5.0-3
SPEC: https://raw.github.com/Ignotus/leechcraft-fedora/751542519992278037bca5a42e1...
SRPM: https://github.com/Ignotus/leechcraft-fedora/blob/751542519992278037bca5a42e...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=781260
--- Comment #18 from Minh Ngo nlminhtl@gmail.com 2012-03-11 14:23:16 EDT --- I'm sorry. There are incorrect version.
0.5.0-3 SPEC: https://raw.github.com/Ignotus/leechcraft-fedora/29633e695014f4f50800b4e5d1b... SRPM: https://github.com/Ignotus/leechcraft-fedora/blob/master/leechcraft-0.5.0-3....
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=781260
Rex Dieter rdieter@math.unl.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
--- Comment #19 from Rex Dieter rdieter@math.unl.edu 2012-03-11 17:12:09 EDT --- Well, a minor nit... if you aren't shipping alternative iconsets (ie, tango has been remove), why bother splitting out oxygen-iconset at all? think about it. :)
Anyway, my other issues have been resolved, APPROVED.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=781260
Minh Ngo nlminhtl@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
--- Comment #20 from Minh Ngo nlminhtl@gmail.com 2012-03-11 17:20:00 EDT --- New Package SCM Request ======================= Package Name: leechcraft Short Description: LeechCraft internet client Owners: ignotusp Branches: f15 f16 el6 InitialCC:
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=781260
--- Comment #21 from Jon Ciesla limburgher@gmail.com 2012-03-12 08:07:03 EDT --- Git done (by process-git-requests).
Added f17.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=781260
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=781260
--- Comment #22 from Fedora Update System updates@fedoraproject.org 2012-03-12 14:30:40 EDT --- leechcraft-0.5.0-3.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/leechcraft-0.5.0-3.fc16
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=781260
--- Comment #23 from Fedora Update System updates@fedoraproject.org 2012-03-12 14:31:59 EDT --- leechcraft-0.5.0-3.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/leechcraft-0.5.0-3.fc15
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=781260
--- Comment #24 from Fedora Update System updates@fedoraproject.org 2012-03-14 15:46:11 EDT --- leechcraft-0.5.0-4.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/leechcraft-0.5.0-4.fc17
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=781260
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #25 from Fedora Update System updates@fedoraproject.org 2012-03-14 22:22:17 EDT --- leechcraft-0.5.0-3.fc16 has been pushed to the Fedora 16 testing repository.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=781260
--- Comment #26 from Fedora Update System updates@fedoraproject.org 2012-03-18 03:09:55 EDT --- leechcraft-0.5.60-1.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/leechcraft-0.5.60-1.fc17
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=781260
--- Comment #27 from Fedora Update System updates@fedoraproject.org 2012-03-18 04:11:36 EDT --- leechcraft-0.5.60-2.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/leechcraft-0.5.60-2.fc15
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=781260
--- Comment #28 from Fedora Update System updates@fedoraproject.org 2012-03-18 04:12:32 EDT --- leechcraft-0.5.60-2.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/leechcraft-0.5.60-2.fc16
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=781260
--- Comment #29 from Fedora Update System updates@fedoraproject.org 2012-03-18 04:55:53 EDT --- leechcraft-0.5.60-3.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/leechcraft-0.5.60-3.fc16
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=781260
--- Comment #30 from Fedora Update System updates@fedoraproject.org 2012-03-18 04:56:39 EDT --- leechcraft-0.5.60-3.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/leechcraft-0.5.60-3.fc15
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=781260
--- Comment #31 from Fedora Update System updates@fedoraproject.org 2012-03-24 03:02:48 EDT --- leechcraft-0.5.60-5.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/leechcraft-0.5.60-5.fc17
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=781260
--- Comment #32 from Fedora Update System updates@fedoraproject.org 2012-03-24 12:34:23 EDT --- leechcraft-0.5.60-5.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/leechcraft-0.5.60-5.fc15
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=781260
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Fixed In Version| |leechcraft-0.5.60-5.fc15 Resolution| |ERRATA Last Closed| |2012-04-01 18:58:03
--- Comment #33 from Fedora Update System updates@fedoraproject.org 2012-04-01 18:58:03 EDT --- leechcraft-0.5.60-5.fc15 has been pushed to the Fedora 15 stable repository. If problems still persist, please make note of it in this bug report.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=781260
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|leechcraft-0.5.60-5.fc15 |leechcraft-0.5.60-5.fc17
--- Comment #34 from Fedora Update System updates@fedoraproject.org 2012-04-11 22:03:51 EDT --- leechcraft-0.5.60-5.fc17 has been pushed to the Fedora 17 stable repository. If problems still persist, please make note of it in this bug report.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=781260
ilmostro7@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |911765
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=781260
Kevin Kofler kevin@tigcc.ticalc.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On|911765 |
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=781260
--- Comment #35 from Minh Ngo nlminhtl@gmail.com --- Please unretired f17 f18 branches
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=781260
Minh Ngo nlminhtl@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs+ | Flags| |fedora-cvs?
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=781260
--- Comment #36 from Jon Ciesla limburgher@gmail.com --- This requires a re-review.
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla