[Bug 2276462] New: Review Request: rust-state - Library for safe and effortless global and thread-local state management

https://bugzilla.redhat.com/show_bug.cgi?id=2276462

            Bug ID: 2276462
           Summary: Review Request: rust-state - Library for safe and
                    effortless global and thread-local state management
           Product: Fedora
           Version: rawhide
                OS: Linux
            Status: NEW
         Component: Package Review
          Keywords: Desktop
          Severity: medium
          Assignee: nobody(a)fedoraproject.org
          Reporter: lukasz.wojnilowicz(a)gmail.com
        QA Contact: extras-qa(a)fedoraproject.org
                CC: package-review(a)lists.fedoraproject.org
  Target Milestone: ---
    Classification: Fedora



Spec URL:
https://raw.githubusercontent.com/wojnilowicz/rust-state/0.6.0/rust-state...
SRPM URL:
https://github.com/wojnilowicz/rust-state/releases/download/0.6.0/rust-st...
Description:  Library for safe and effortless global and thread-local state
management
Fedora Account System Username: wojnilowicz

I plan on packaging https://github.com/ActivityWatch/aw-server-rust and state
package is in its requirement chain. The chain is as follows rocket->state.

I've requested a sponsor at https://pagure.io/packager-sponsors/issue/640

Reproducible: Always


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2276462

Report this comment as SPAM:
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=rep...

[Bug 2276462] Review Request: rust-state - Library for safe and effortless global and thread-local state management

https://bugzilla.redhat.com/show_bug.cgi?id=2276462

wojnilowicz <lukasz.wojnilowicz(a)gmail.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |177841 (FE-NEEDSPONSOR)





Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2276462

[Bug 2276462] Review Request: rust-state - Library for safe and effortless global and thread-local state management

https://bugzilla.redhat.com/show_bug.cgi?id=2276462

wojnilowicz <lukasz.wojnilowicz(a)gmail.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Comment|0                           |updated



--- Comment #0 has been edited ---

Spec URL:
https://raw.githubusercontent.com/wojnilowicz/rust-state/0.6.0/rust-state...
SRPM URL:
https://github.com/wojnilowicz/rust-state/releases/download/0.6.0/rust-st...
Description:  Library for safe and effortless global and thread-local state
management
Fedora Account System Username: wojnilowicz

I plan on packaging https://github.com/ActivityWatch/aw-server-rust and state
package is in its requirements chain. The chain is as follows rocket->state.

I've requested a sponsor at https://pagure.io/packager-sponsors/issue/640

Reproducible: Always

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2276462

[Bug 2276462] Review Request: rust-state - Library for safe and effortless global and thread-local state management

https://bugzilla.redhat.com/show_bug.cgi?id=2276462

wojnilowicz <lukasz.wojnilowicz(a)gmail.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Comment|0                           |updated



--- Comment #0 has been edited ---

Spec URL:
https://raw.githubusercontent.com/wojnilowicz/rust-state/0.6.0/rust-state...
SRPM URL:
https://github.com/wojnilowicz/rust-state/releases/download/0.6.0/rust-st...
Description:  Library for safe and effortless global and thread-local state
management
Fedora Account System Username: wojnilowicz

I plan on packaging https://github.com/ActivityWatch/aw-server-rust and state
package is in its requirements chain. The chain is as follows: rocket->state.

I've requested a sponsor at https://pagure.io/packager-sponsors/issue/640

Reproducible: Always

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2276462

[Bug 2276462] Review Request: rust-state - Library for safe and effortless global and thread-local state management

https://bugzilla.redhat.com/show_bug.cgi?id=2276462

wojnilowicz <lukasz.wojnilowicz(a)gmail.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Comment|0                           |updated



--- Comment #0 has been edited ---

Spec URL:
https://raw.githubusercontent.com/wojnilowicz/rust-state/0.6.0/rust-state...
SRPM URL:
https://github.com/wojnilowicz/rust-state/releases/download/0.6.0/rust-st...
Description:  Library for safe and effortless global and thread-local state
management
Fedora Account System Username: wojnilowicz

I plan on packaging https://github.com/ActivityWatch/aw-server-rust and state
package is in its requirements chain. The chain is as follows:
aw-server-rust->rocket->state.

I've requested a sponsor at https://pagure.io/packager-sponsors/issue/640

Reproducible: Always

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2276462

[Bug 2276462] Review Request: rust-state - Library for safe and effortless global and thread-local state management

https://bugzilla.redhat.com/show_bug.cgi?id=2276462



--- Comment #1 from wojnilowicz <lukasz.wojnilowicz(a)gmail.com&gt; ---
[fedora-review-service-build]


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2276462

Report this comment as SPAM:
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=rep...

[Bug 2276462] Review Request: rust-state - Library for safe and effortless global and thread-local state management

https://bugzilla.redhat.com/show_bug.cgi?id=2276462

Fedora Review Service <fedora-review-bot(a)fedoraproject.org&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |https://crates.io/crates/st
                   |                            |ate
           Keywords|                            |AutomationTriaged



--- Comment #2 from Fedora Review Service <fedora-review-bot(a)fedoraproject.org&gt; ---
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7429315
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-...

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2276462

Report this comment as SPAM:
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=rep...

[Bug 2276462] Review Request: rust-state - Library for safe and effortless global and thread-local state management

https://bugzilla.redhat.com/show_bug.cgi?id=2276462

Fabio Valentini <decathorpe(a)gmail.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|nobody(a)fedoraproject.org    |decathorpe(a)gmail.com
                 CC|                            |decathorpe(a)gmail.com
             Status|NEW                         |ASSIGNED



--- Comment #3 from Fabio Valentini <decathorpe(a)gmail.com&gt; ---
There's a few small issues:

- Don't override the %description. The generated one is fine.

- Don't "rm" the license files for the bundled thread_local code.

- Don't remove the "%license" file entries for the bundled thread_local
code.

- Add "Provides: bundled(crate(thread_local)) = <version>" to the
"-devel"
subpackage.

I'm not sure why the thread_local code is bundled at all, it doesn't seem to be
documented.
But it *is* bundled, and it needs to be specified in RPM metadata.

Maybe you can find out which version of the thread_local crate is bundled.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2276462

Report this comment as SPAM:
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=rep...

[Bug 2276462] Review Request: rust-state - Library for safe and effortless global and thread-local state management

https://bugzilla.redhat.com/show_bug.cgi?id=2276462



--- Comment #4 from wojnilowicz <lukasz.wojnilowicz(a)gmail.com&gt; ---
(In reply to Fabio Valentini from comment #3)
>  There's a few small issues:
>  
>  - Don't override the %description. The generated one is fine. 
Done.

>  - Don't "rm" the license files for the bundled
> thread_local code. 
Done.

>  - Don't remove the "%license" file entries for the
> bundled thread_local code. 
Done.

>  - Add "Provides: bundled(crate(thread_local)) =
> <version>" to the "-devel"
>  subpackage. 
Done.

>  I'm not sure why the thread_local code is bundled at all, it
> doesn't seem to
>  be documented.
>  But it *is* bundled, and it needs to be specified in RPM metadata.
>  
>  Maybe you can find out which version of the thread_local crate is bundled. 
Indeed. Here are my findings:
1) thread_local imported (on 2020-10-28) with this commit
https://github.com/SergioBenitez/state/commit/9a3f70afb8cf5a4501622066fca...
2) not synchronized with thread_local afterwards
3) thread_local 1.0.1 on crates.io is from 2020-01-11, so it's probable this
was imported
4) thread_local 1.1.0 on crates.io is from 2021-01-07, so it's impossible this
was imported
5) thread_id.rs and unreachable.rs from "state" matches 100% with
"thread_local" 1.1.0
6) mod.rs (9,2 KB) from "state" is a heavily modified version of lib.rs (18,8
KB) from "thread_local"

It seems that "state" forked "thread_local". Are you sure that we
should add
"Provides: bundled(crate(thread_local)) = 1.0.1" then?

Anyway, I've updated my spec and src.rpm file in the first post.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2276462

Report this comment as SPAM:
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=rep...

[Bug 2276462] Review Request: rust-state - Library for safe and effortless global and thread-local state management

https://bugzilla.redhat.com/show_bug.cgi?id=2276462



--- Comment #5 from Fabio Valentini <decathorpe(a)gmail.com&gt; ---
Sorry for the delay - this indeed slipped through the cracks of my TODO list.

Thank you for addressing the issues, I will do the final review now.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2276462

Report this comment as SPAM:
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=rep...

[Bug 2276462] Review Request: rust-state - Library for safe and effortless global and thread-local state management

https://bugzilla.redhat.com/show_bug.cgi?id=2276462

Fabio Valentini <decathorpe(a)gmail.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+



--- Comment #6 from Fabio Valentini <decathorpe(a)gmail.com&gt; ---
Looks good to me now.

I think having the Provides for the bundled thread_local crate is OK for now.
If the code diverges further, we can treat it as an actual fork.
For now it seems to be sufficiently similar to the original for us to treat it
as "bundled, but modified".
This also seems to be upstream's intention, since the original license texts
are still included.

===

Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification and is acceptable for Fedora
- license files are included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2276462

Report this comment as SPAM:
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=rep...

[Bug 2276462] Review Request: rust-state - Library for safe and effortless global and thread-local state management

https://bugzilla.redhat.com/show_bug.cgi?id=2276462

Fedora Admin user for bugzilla script actions
<fedora-admin-xmlrpc(a)fedoraproject.org&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |POST



--- Comment #7 from Fedora Admin user for bugzilla script actions
<fedora-admin-xmlrpc(a)fedoraproject.org&gt; ---
The Pagure repository was created at
https://src.fedoraproject.org/rpms/rust-state


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2276462

Report this comment as SPAM:
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=rep...

[Bug 2276462] Review Request: rust-state - Library for safe and effortless global and thread-local state management

https://bugzilla.redhat.com/show_bug.cgi?id=2276462



--- Comment #8 from wojnilowicz <lukasz.wojnilowicz(a)gmail.com&gt; ---
I'm glad it's moving forward. Thanks.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2276462

Report this comment as SPAM:
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=rep...

[Bug 2276462] Review Request: rust-state - Library for safe and effortless global and thread-local state management

https://bugzilla.redhat.com/show_bug.cgi?id=2276462

Fedora Update System <updates(a)fedoraproject.org&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|POST                        |MODIFIED



--- Comment #9 from Fedora Update System <updates(a)fedoraproject.org&gt; ---
FEDORA-2024-fff3355841 (rust-state-0.6.0-1.fc41) has been submitted as an
update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-fff3355841


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2276462

Report this comment as SPAM:
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=rep...

[Bug 2276462] Review Request: rust-state - Library for safe and effortless global and thread-local state management

https://bugzilla.redhat.com/show_bug.cgi?id=2276462

Fedora Update System <updates(a)fedoraproject.org&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|MODIFIED                    |CLOSED
         Resolution|---                         |ERRATA
        Last Closed|                            |2024-05-27 15:23:20



--- Comment #10 from Fedora Update System <updates(a)fedoraproject.org&gt; ---
FEDORA-2024-fff3355841 (rust-state-0.6.0-1.fc41) has been pushed to the Fedora
41 stable repository.
If problem still persists, please make note of it in this bug report.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2276462

Report this comment as SPAM:
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=rep...