[Bug 215185] New: Review Request: compat-libosip2-2.2.2 - compatability package for libosip2

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=215185

Summary: Review Request: compat-libosip2-2.2.2 - compatability
                    package for libosip2
           Product: Fedora Extras
           Version: devel
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: normal
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]

Spec URL: http://repo.ocjtech.us/misc/fedora/6/SRPMS/compat-libosip2-2.2.2-2.2.2-5.fc6...
SRPM URL: http://repo.ocjtech.us/misc/fedora/6/SRPMS/compat-libosip2-2.2.2-2.2.2-5.fc6...
Description:

oSIP is an implementation of SIP.

SIP stands for the Session Initiation Protocol and is described by the
rfc3261 (wich deprecates rfc2543). This library aims to provide
multimedia and telecom software developers an easy and powerful
interface to initiate and control SIP based sessions in their
applications. SIP is a open standard replacement from IETF for H.323.

linphone requires version 2.2.2 of libosip2 - newer versions of
libosip2 have dropped some functionality that linphone requires.
Until the linphone developers update linphone a compatibility package
will be needed so that libosip2 can be updated to the latest version.

[Bug 215185] Review Request: compat-libosip2-2.2.2 - compatability package for libosip2

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: compat-libosip2-2.2.2 - compatability package for libosip2

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=215185

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|                            |197166
              nThis|                            |

[Bug 215185] Review Request: compat-libosip2-2.2.2 - compatability package for libosip2

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: compat-libosip2-2.2.2 - compatability package for libosip2

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=215185

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|[e-mail]    |[e-mail]
OtherBugsDependingO|163776                      |163778
              nThis|                            |

------- Additional Comments From [e-mail]  2006-11-11 23:08 EST -------
Wanting to help get the broken package report down some, here's a review. ;)

See below - Package meets naming and packaging guidelines
See below - Spec file matches base package name.
OK - Spec has consistant macro usage.
OK - Meets Packaging Guidelines.
OK - License
OK - License field in spec matches
OK - License file included in package
OK - Spec in American English
OK - Spec is legible.
OK - Sources match upstream md5sum:
40ee3ec89030f0d6dfdb2cf6100e6685  libosip2-2.2.2.tar.gz
40ee3ec89030f0d6dfdb2cf6100e6685  libosip2-2.2.2.tar.gz.1
OK - BuildRequires correct
OK - Package has %defattr and permissions on files is good.
OK - Package has a correct %clean section.
OK - Package has correct buildroot
OK - Package is code or permissible content.
OK - Packages %doc files don't affect runtime.

OK - Headers/static libs in -devel subpackage.
OK - Spec has needed ldconfig in post and postun
See below - .pc files in -devel subpackage/requires pkgconfig
OK - .so files in -devel subpackage.
OK - -devel package Requires: %{name} = %{version}-%{release}

OK - Package compiles and builds on at least one arch.
OK - Package has no duplicate files in %files.
OK - Package doesn't own any directories other packages own.
OK - Package owns all the directories it creates.
See below - No rpmlint output.
OK - final provides and requires are sane:

SHOULD Items:

OK - Should build in mock.
OK - Should build on all supported archs
OK - Should have dist tag

Issues:

1. Your naming doesn't seem right to me...

compat-libosip2-2.2.2-2.2.2-5
should be just
compat-libosip2-2.2.2-5

right? ie, the 2.2.2 in the Name should be removed.

2. Shouldn't you 
Provides: libosip2 = %{version}-%{release}

instead of the Conflicts? Then this version will replace the older libosip2
packages and provide the same things for things like linphone?

3. The devel subpackage has a .pc file, so it should
Requires: pkgconfig

4. rpmlint says:

W: compat-libosip2-2.2.2 summary-not-capitalized oSIP is an implementation of SIP

Can be ignored.

W: compat-libosip2-2.2.2 incoherent-version-in-changelog 2.2.2-4 2.2.2-5.fc7

Missing changelog entry for changes to the compat package?

E: compat-libosip2-2.2.2 obsolete-not-provided libosip2

See issue #2?

W: compat-libosip2-2.2.2 summary-not-capitalized oSIP is an implementation of SIP
E: compat-libosip2-2.2.2-devel obsolete-not-provided libosip2-devel

Same thing with the -devel subpackage...

[Bug 215185] Review Request: compat-libosip2 - compatability package for libosip2

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: compat-libosip2 - compatability package for libosip2

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=215185

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Review Request: compat-     |Review Request: compat-
                   |libosip2-2.2.2 -            |libosip2 - compatability
                   |compatability package for   |package for libosip2
                   |libosip2                    |

------- Additional Comments From [e-mail]  2006-11-13 10:53 EST -------
Spec URL:
http://repo.ocjtech.us/misc/fedora/6/SRPMS/compat-libosip2-2.2.2-7.fc6.spec
SRPM URL:
http://repo.ocjtech.us/misc/fedora/6/SRPMS/compat-libosip2-2.2.2-7.fc6.src.r...

* Mon Nov 13 2006 Jeffrey C. Ollie  - 2.2.2-7
- Fix up provides/obsoletes/conflicts
- Fix package name

[Bug 215185] Review Request: compat-libosip2 - compatability package for libosip2

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: compat-libosip2 - compatability package for libosip2

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=215185

------- Additional Comments From [e-mail]  2006-11-13 17:12 EST -------
1. Looks good.

2. I think you also still need to have the Obsoletes: as well as the Provides. 
See: 
http://fedoraproject.org/wiki/Packaging/NamingGuidelines#head-581c3fb3ff1c6e...

3. Looks good.

4. Looks good.

[Bug 215185] Review Request: compat-libosip2 - compatability package for libosip2

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: compat-libosip2 - compatability package for libosip2

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=215185

------- Additional Comments From [e-mail]  2006-11-13 21:05 EST -------
Ah... I knew that the provides/obosletes thing was documented *somewhere*...

Spec URL:
http://repo.ocjtech.us/misc/fedora/6/SRPMS/compat-libosip2-2.2.2-8.fc6.spec
SRPM URL:
http://repo.ocjtech.us/misc/fedora/6/SRPMS/compat-libosip2-2.2.2-8.fc6.src.r...

* Mon Nov 13 2006 Jeffrey C. Ollie  - 2.2.2-8
- Add Obsoletes

[Bug 215185] Review Request: compat-libosip2 - compatability package for libosip2

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: compat-libosip2 - compatability package for libosip2

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=215185

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163778                      |163779
              nThis|                            |

------- Additional Comments From [e-mail]  2006-11-14 15:11 EST -------
ok, that looks good. Thats the last blocker that I see... so this package is
APPROVED.

Please remember to close this NEXTRELEASE once it's been imported and built.

Also consider doing a review on another waiting package to help spread out the
reviewing load.

[Bug 215185] Review Request: compat-libosip2 - compatability package for libosip2

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: compat-libosip2 - compatability package for libosip2

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=215185

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |NEXTRELEASE

------- Additional Comments From [e-mail]  2006-11-15 14:55 EST -------
Ok, imported and built for FC-5, FC-6, and devel