[Bug 706846] New: Review Request: hibernate-jpa-2.0-api - Java Persistence 2.0 (JSR 317) API

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: hibernate-jpa-2.0-api - Java Persistence 2.0 (JSR 317) API

https://bugzilla.redhat.com/show_bug.cgi?id=706846

Summary: Review Request: hibernate-jpa-2.0-api - Java
                    Persistence 2.0 (JSR 317) API
           Product: Fedora
           Version: rawhide
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: medium
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail], [e-mail]
   Estimated Hours: 0.0
    Classification: Fedora
      Story Points: ---

Spec URL:
http://goldmann.fedorapeople.org/package_review/hibernate-jpa-2.0-api.spec
SRPM URL:
http://goldmann.fedorapeople.org/package_review/hibernate-jpa-2.0-api-1.0.0-...
Description:

Hibernate definition of the Java Persistence 2.0 (JSR 317) API.

Koji scratch build:

http://koji.fedoraproject.org/koji/taskinfo?taskID=3086962

[Bug 706846] Review Request: hibernate-jpa-2.0-api - Java Persistence 2.0 (JSR 317) API

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=706846

Marek Goldmann  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |652183(FE-JAVASIG)

[Bug 706846] Review Request: hibernate-jpa-2.0-api - Java Persistence 2.0 (JSR 317) API

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=706846

Alexander Kurtakov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |[e-mail]
         AssignedTo|[e-mail]    |[e-mail]
               Flag|                            |fedora-review?

--- Comment #1 from Alexander Kurtakov  2011-05-26 14:41:43 EDT ---
I would do this one.

[Bug 706846] Review Request: hibernate-jpa-2.0-api - Java Persistence 2.0 (JSR 317) API

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=706846

Alexander Kurtakov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |182235(FE-Legal)

--- Comment #2 from Alexander Kurtakov  2011-05-26 15:09:04 EDT ---
I have big concerns about the license of this package. Most source files are
simply saying Copyright 2004-2209 Sun Microsystem Inc. without any additional
notice about the actual license. The lisense file looks non free to me but I
would ask legal for advise.
Blocking FE-LEGAL.

[Bug 706846] Review Request: hibernate-jpa-2.0-api - Java Persistence 2.0 (JSR 317) API

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=706846

--- Comment #3 from Alexander Kurtakov  2011-05-26 15:19:09 EDT ---
I forgot to mention the license is definitely not LGPLv2+

[Bug 706846] Review Request: hibernate-jpa-2.0-api - Java Persistence 2.0 (JSR 317) API

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=706846

Tom "spot" Callaway  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #4 from Tom "spot" Callaway  2011-07-01 10:47:17 EDT ---
There was a lengthy email thread on how to resolve the licensing issues here,
is there any progress on a new package?

[Bug 706846] Review Request: hibernate-jpa-2.0-api - Java Persistence 2.0 (JSR 317) API

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=706846

--- Comment #5 from Marek Goldmann  2011-07-01 11:01:00 EDT ---
(In reply to comment #4)
> There was a lengthy email thread on how to resolve the licensing issues here,
> is there any progress on a new package?

Tom, this request will be updated with the resolution found in that thread.

Sorry I haven't done it earlier.

[Bug 706846] Review Request: hibernate-jpa-2.0-api - Java Persistence 2.0 (JSR 317) API

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=706846

--- Comment #6 from Marek Goldmann  2011-07-05 03:15:33 EDT ---
Spec URL:
http://goldmann.fedorapeople.org/package_review/hibernate-jpa-2.0-api/2/hibe...
SRPM URL:
http://goldmann.fedorapeople.org/package_review/hibernate-jpa-2.0-api/2/hibe...

Changes: updated to upstream release 1.0.1, fixed license tag.

[Bug 706846] Review Request: hibernate-jpa-2.0-api - Java Persistence 2.0 (JSR 317) API

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=706846

Tom "spot" Callaway  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|182235(FE-Legal)            |

--- Comment #7 from Tom "spot" Callaway  2011-07-05 10:09:28 EDT ---
Thanks Marek. Lifting FE-Legal.

[Bug 706846] Review Request: hibernate-jpa-2.0-api - Java Persistence 2.0 (JSR 317) API

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=706846

--- Comment #8 from Alexander Kurtakov  2011-07-27 08:00:49 EDT ---
Package Review
==============

Key:
- = N/A
x = Check
! = Problem
? = Not evaluated

=== REQUIRED ITEMS ===
[!]  Rpmlint output:
hibernate-jpa-2.0-api-javadoc.noarch: W: spelling-error Summary(en_US) Javadocs
-> Java docs, Java-docs, Avocados
hibernate-jpa-2.0-api-javadoc.noarch: W: invalid-url URL:
http://www.hibernate.org/ HTTP Error 403: Forbidden
False positives.
hibernate-jpa-2.0-api-javadoc.noarch: W: wrong-file-end-of-line-encoding
/usr/share/javadoc/hibernate-jpa-2.0-api/apidocs/jdstyle.css
Please fix.

[x]  Package is named according to the Package Naming Guidelines[1].
[x]  Spec file name must match the base package name, in the format
%{name}.spec.
[x]  Package meets the Packaging Guidelines[2].
[x]  Package successfully compiles and builds into binary rpms.
[x]  Buildroot definition is not present
[x]  Package is licensed with an open-source compatible license and meets other
legal requirements as defined in the legal section of Packaging
Guidelines[3,4].
[!]  License field in the package spec file matches the actual license.
License type: EPL and BSD
[x]  If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package is included in %doc.
[!]  All independent sub-packages have license of their own
[x]  Spec file is legible and written in American English.
[x]  Sources used to build the package matches the upstream source, as provided
in the spec URL.
[x]  All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines[5].
[x]  Package must own all directories that it creates.
[x]  Package requires other packages for directories it uses.
[x]  Package does not contain duplicates in %files.
[x]  File sections do not contain %defattr(-,root,root,-) unless changed with
good reason
[x]  Permissions on files are set properly.
[x]  Package does NOT have a %clean section which contains rm -rf %{buildroot}
(or $RPM_BUILD_ROOT). (not needed anymore)
[x]  Package consistently uses macros (no %{buildroot} and $RPM_BUILD_ROOT
mixing)
[x]  Package contains code, or permissable content.
[x]  Fully versioned dependency in subpackages, if present.
[-]  Package contains a properly installed %{name}.desktop file if it is a GUI
application.
[x]  Package does not own files or directories owned by other packages.
[x]  Javadoc documentation files are generated and included in -javadoc
subpackage
[x]  Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlinks)
[x]  Packages have proper BuildRequires/Requires on jpackage-utils
[x]  Javadoc subpackages have Require: jpackage-utils
[x]  Package uses %global not %define
[x]  If package uses tarball from VCS include comment how to re-create that
tarball (svn export URL, git clone URL, ...)
[x]  If source tarball includes bundled jar/class files these need to be
removed prior to building
[x]  All filenames in rpm packages must be valid UTF-8.
[x]  Jar files are installed to %{_javadir}/%{name}.jar (see [6] for details)
[x]  If package contains pom.xml files install it (including depmaps) even when
building with ant
[!]  pom files has correct add_maven_depmap

=== Maven ===
[x]  Use %{_mavenpomdir} macro for placing pom files instead of
%{_datadir}/maven2/poms
[-]  If package uses "-Dmaven.test.skip=true" explain why it was needed in a
comment
[-]  If package uses custom depmap "-Dmaven.local.depmap.file=*" explain why
it's needed in a comment
[!]  Package DOES NOT use %update_maven_depmap in %post/%postun
[!]  Packages DOES NOT have Requires(post) and Requires(postun) on
jpackage-utils for %update_maven_depmap macro

=== Other suggestions ===
[x]  If possible use upstream build method (maven/ant/javac)
[x]  Avoid having BuildRequires on exact NVR unless necessary
[x]  Package has BuildArch: noarch (if possible)
[x]  Latest version is packaged.

=== Issues ===
1. Fix wrong-file-end-of-line-encoding
2. Fix license field to be EPL and BSD because all the sources are duallicensed
3. Add license file to javadoc subpackage
4. Use add_maven_depmap
5. Remove update_maven_depmap and Requires(post|postun) on jpackage-utils

[Bug 706846] Review Request: hibernate-jpa-2.0-api - Java Persistence 2.0 (JSR 317) API

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=706846

--- Comment #9 from Marek Goldmann  2011-07-27 08:35:08 EDT ---
Issues fixed!

Spec URL:
http://goldmann.fedorapeople.org/package_review/hibernate-jpa-2.0-api/3/hibe...
SRPM URL:
http://goldmann.fedorapeople.org/package_review/hibernate-jpa-2.0-api/3/hibe...

[Bug 706846] Review Request: hibernate-jpa-2.0-api - Java Persistence 2.0 (JSR 317) API

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=706846

Alexander Kurtakov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #10 from Alexander Kurtakov  2011-07-27 09:03:39 EDT ---
Looks good. 
APPROVED

[Bug 706846] Review Request: hibernate-jpa-2.0-api - Java Persistence 2.0 (JSR 317) API

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=706846

Marek Goldmann  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|652183(FE-JAVASIG)          |
               Flag|                            |fedora-cvs?

--- Comment #11 from Marek Goldmann  2011-07-27 09:13:26 EDT ---
Thank you for review!

New Package SCM Request
=======================
Package Name:      hibernate-jpa-2.0-api
Short Description: Java Persistence 2.0 (JSR 317) API
Owners:            goldmann
Branches:          f15

[Bug 706846] Review Request: hibernate-jpa-2.0-api - Java Persistence 2.0 (JSR 317) API

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=706846

--- Comment #12 from Jon Ciesla  2011-07-27 09:36:07 EDT ---
Git done (by process-git-requests).

Added f16 as we just branched.

[Bug 706846] Review Request: hibernate-jpa-2.0-api - Java Persistence 2.0 (JSR 317) API

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=706846

Marek Goldmann  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-cvs+                 |fedora-cvs?

--- Comment #13 from Marek Goldmann  2011-07-27 09:40:27 EDT ---
Thank you very much! I was just going to fix it as I noticed it a few minutes
ago.

[Bug 706846] Review Request: hibernate-jpa-2.0-api - Java Persistence 2.0 (JSR 317) API

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=706846

--- Comment #14 from Jon Ciesla  2011-07-27 09:43:04 EDT ---
I unset the cvs flag.

[Bug 706846] Review Request: hibernate-jpa-2.0-api - Java Persistence 2.0 (JSR 317) API

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=706846

Marek Goldmann  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |RAWHIDE
        Last Closed|                            |2011-07-28 05:00:48

--- Comment #15 from Marek Goldmann  2011-07-28 05:00:48 EDT ---
Thank you, closing.