[Bug 541589] New: Review Request: sqljet - Pure Java SQLite

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: sqljet - Pure Java SQLite

https://bugzilla.redhat.com/show_bug.cgi?id=541589

Summary: Review Request: sqljet - Pure Java SQLite
           Product: Fedora
           Version: rawhide
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: medium
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail], [e-mail]
   Estimated Hours: 0.0
    Classification: Fedora

Spec URL: http://akurtakov.fedorapeople.org/sqljet.spec
SRPM URL: http://akurtakov.fedorapeople.org/sqljet-1.0.1-1.fc12.src.rpm
Description: SQLJet is an independent pure Java implementation of a popular
SQLite database
management system. SQLJet is a software library that provides API that enables
Java application to read and modify SQLite databases.

[Bug 541589] Review Request: sqljet - Pure Java SQLite

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=541589

Lubomir Rintel  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
         AssignedTo|[e-mail]    |[e-mail]
               Flag|                            |fedora-review?

[Bug 541589] Review Request: sqljet - Pure Java SQLite

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=541589

--- Comment #1 from Lubomir Rintel   2009-11-26 15:53:45 EDT ---
0.) The -javadoc subpackage should requires jpackage-utils
...that owns %_javadocdir

1.) Does not build
you probably meant to add junit4 to the classpath

2.) You don't use macros consistently
please use either $RPM_BUILD_ROOT or %{buildroot} macro but not both

The rest is just matter of clean style. Just for your considerations, probably
nothing that would block the review:

You can do this in one shot, without calling rm:
-find -name '*.class' -exec rm -f '{}' ;
-find -name '*.jar' -exec rm -f '{}' ;
+find ( -name '*.class' -o -name '*.jar' ) -delete

[Bug 541589] Review Request: sqljet - Pure Java SQLite

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=541589

Lubomir Rintel  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

--- Comment #2 from Lubomir Rintel   2009-11-26 16:03:32 EDT ---
3.) You do not run the test suite
Please do so, ideally in %check section. Seems like you'd need to add a
dependency on hamcrest.

I'd also suggest replacing Summary with something more descriptive, (i.e.
adding "database library" at the end or something like that).

The rest looks well
* Named and versioned in accordance with guidelines
* License ok, license tag correct, license present in package documentation
* spec file clean and legible
* filelist sane

[Bug 541589] Review Request: sqljet - Pure Java SQLite

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=541589

--- Comment #3 from Alexander Kurtakov   2009-11-30 07:38:51 EDT ---
(In reply to comment #1)
> 0.) The -javadoc subpackage should requires jpackage-utils
> ...that owns %_javadocdir

Fixed.
> 1.) Does not build
> you probably meant to add junit4 to the classpath

Fixed.
> 2.) You don't use macros consistently
> please use either $RPM_BUILD_ROOT or %{buildroot} macro but not both

Fixed.
> The rest is just matter of clean style. Just for your considerations, probably
> nothing that would block the review:
>
> You can do this in one shot, without calling rm:
> -find -name '*.class' -exec rm -f '{}' ;
> -find -name '*.jar' -exec rm -f '{}' ;
> +find ( -name '*.class' -o -name '*.jar' ) -delete

Fixed.

(In reply to comment #2)
> 3.) You do not run the test suite
> Please do so, ideally in %check section. Seems like you'd need to add a
> dependency on hamcrest.

Test suite is failing for me and upstream build is a nightmare. I've submitted
a few issues about that but no response yet. Hopefully this is not a blocker.
> I'd also suggest replacing Summary with something more descriptive, (i.e.
> adding "database library" at the end or something like that).

Hmm, I'm not sure I understand what you want. I picked the first paragraph of
sqljet.com assuming upstream devs will describe their work best.
> The rest looks well
> Named and versioned in accordance with guidelines
> License ok, license tag correct, license present in package documentation
> spec file clean and legible
> filelist sane

New package:
Spec URL: http://akurtakov.fedorapeople.org/sqljet.spec
SRPM URL: http://akurtakov.fedorapeople.org/sqljet-1.0.1-2.fc12.src.rpm

Koji build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=1837449

[Bug 541589] Review Request: sqljet - Pure Java SQLite

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=541589

Lubomir Rintel  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #4 from Lubomir Rintel   2009-11-30 08:02:30 EDT ---
Thanks for the fixes.

(In reply to comment #3)
> (In reply to comment #2)
> > 3.) You do not run the test suite
> > Please do so, ideally in %check section. Seems like you'd need to add a
> > dependency on hamcrest.
>
> Test suite is failing for me and upstream build is a nightmare. I've submitted
> a few issues about that but no response yet. Hopefully this is not a blocker.

Sounds fair.
> > I'd also suggest replacing Summary with something more descriptive, (i.e.
> > adding "database library" at the end or something like that).
>
> Hmm, I'm not sure I understand what you want. I picked the first paragraph of
> sqljet.com assuming upstream devs will describe their work best.

That was just a suggestion, feel free to keep your Summary if you feel it's
better; definitely not a blocker or anything.

APPROVED.

[Bug 541589] Review Request: sqljet - Pure Java SQLite

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=541589

Alexander Kurtakov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?

--- Comment #5 from Alexander Kurtakov   2009-11-30 08:20:36 EDT ---
Thanks for the review.

New Package CVS Request
=======================
Package Name: sqljet
Short Description: Pure Java SQLite
Owners: akurtakov
Branches: 
InitialCC:

[Bug 541589] Review Request: sqljet - Pure Java SQLite

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=541589

Kevin Fenzi  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-cvs?                 |fedora-cvs+

--- Comment #6 from Kevin Fenzi   2009-12-03 01:37:48 EDT ---
cvs done.

[Bug 541589] Review Request: sqljet - Pure Java SQLite

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=541589

Alexander Kurtakov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |NEXTRELEASE

--- Comment #7 from Alexander Kurtakov   2009-12-03 06:09:11 EDT ---
http://koji.fedoraproject.org/koji/buildinfo?buildID=144190