Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: fiwalk - Batch analysis of a disk image
https://bugzilla.redhat.com/show_bug.cgi?id=783657
Summary: Review Request: fiwalk - Batch analysis of a disk image Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: kwizart@gmail.com QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: --- Regression: --- Mount Type: --- Documentation: ---
Spec URL: http://kwizart.fedorapeople.org/review/fiwalk.spec SRPM URL: http://kwizart.fedorapeople.org/review/fiwalk-0.6.16-1.fc17.src.rpm Description: Batch analysis of a disk image
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=783657
Volker Fröhlich volker27@gmx.at changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |volker27@gmx.at
--- Comment #1 from Volker Fröhlich volker27@gmx.at 2012-01-21 19:17:04 EST --- Correct these permissions in the prep section:
fiwalk-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/fiwalk-0.6.16/src/fiwalk.cpp fiwalk-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/fiwalk-0.6.16/src/base64.h fiwalk-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/fiwalk-0.6.16/src/base64.cpp
COPYING states Public Domain.
I think the description could be better. Maybe you can make up something together with http://afflib.org/software/fiwalk?
Consider to install the example Python scripts as documentation. Though I wonder about where the Python module is.
(The stuff I wrote on defattr and EPEL on the aimage review also applies here.)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=783657
--- Comment #2 from Nicolas Chauvet (kwizart) kwizart@gmail.com 2012-01-23 18:21:50 EST --- Spec URL: http://kwizart.fedorapeople.org/review/fiwalk.spec SRPM URL: http://kwizart.fedorapeople.org/review/fiwalk-0.6.16-2.fc17.src.rpm Description: Batch analysis of a disk image
Changelog: - Update description - Fix spurious exec permission - Correct license field to Public Domain - Install python examples in doc
Thx for the reviews
https://bugzilla.redhat.com/show_bug.cgi?id=783657
Fabian Affolter mail@fabian-affolter.ch changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mail@fabian-affolter.ch Blocks| |563471
https://bugzilla.redhat.com/show_bug.cgi?id=783657
Fabian Affolter mail@fabian-affolter.ch changed:
What |Removed |Added ---------------------------------------------------------------------------- Alias| |fiwalk
https://bugzilla.redhat.com/show_bug.cgi?id=783657
Michal Ambroz rebus@seznam.cz changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@fedoraproject.org |rebus@seznam.cz
--- Comment #3 from Michal Ambroz rebus@seznam.cz --- Hello, I will take review of this package. Michal Ambroz
https://bugzilla.redhat.com/show_bug.cgi?id=783657
Nicolas Chauvet (kwizart) kwizart@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution|--- |WONTFIX Last Closed| |2012-07-04 04:30:20
--- Comment #4 from Nicolas Chauvet (kwizart) kwizart@gmail.com --- Hi,
Thx for the attempt to review, but this package will be merged in the next version of sleuthkit (already in fedora).
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla