[Bug 909887] New: Review Request: gnome-connection-manager - A tabbed ssh connection manager for gtk+ environments
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=909887
Bug ID: 909887 Summary: Review Request: gnome-connection-manager - A tabbed ssh connection manager for gtk+ environments Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Reporter: fedora@matbooth.co.uk
Spec URL: http://mbooth.fedorapeople.org/reviews/gnome-connection-manager.spec SRPM URL: http://mbooth.fedorapeople.org/reviews/gnome-connection-manager-1.1.0-1.fc18... Description: Gnome Connection Manager is a tabbed ssh connection manager for gtk+ environments. Fedora Account System Username: mbooth Koji Scratch Build: http://koji.fedoraproject.org/koji/taskinfo?taskID=4949423
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=909887
--- Comment #1 from Mat Booth fedora@matbooth.co.uk --- Spec URL: http://mbooth.fedorapeople.org/reviews/gnome-connection-manager.spec SRPM URL: http://mbooth.fedorapeople.org/reviews/gnome-connection-manager-1.1.0-2.fc18...
Update licence tag and include expect script.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=909887
--- Comment #2 from Mat Booth fedora@matbooth.co.uk --- New Koji Scratch Build: http://koji.fedoraproject.org/koji/taskinfo?taskID=4950113
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=909887
Mat Booth fedora@matbooth.co.uk changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|Review Request: |Review Request: |gnome-connection-manager - |gnome-connection-manager - |A tabbed ssh connection |A tabbed ssh connection |manager for gtk+ |manager for gtk+ |environments |environments (Python | |Application)
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=909887
--- Comment #3 from Mat Booth fedora@matbooth.co.uk --- Spec URL: http://mbooth.fedorapeople.org/reviews/gnome-connection-manager.spec SRPM URL: http://mbooth.fedorapeople.org/reviews/gnome-connection-manager-1.1.0-3.fc18...
Add BR/R on vte.
https://bugzilla.redhat.com/show_bug.cgi?id=909887
Pranav Kant pranav913@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |pranav913@gmail.com
--- Comment #4 from Pranav Kant pranav913@gmail.com --- This is an unofficial review only.
[x]: rpmlint must be run on the source rpm and all binary rpms the build produces.
Rpmlint on SRPM: gnome-connection-manager.src: W: invalid-url URL: http://kuthulu.com/gcm/ <urlopen error [Errno -2] Name or service not known> gnome-connection-manager.src: W: invalid-url Source0: http://kuthulu.com/gcm/gnome-connection-manager_1.1.0_all.tgz <urlopen error [Errno -2] Name or service not known> 1 packages and 0 specfiles checked; 0 errors, 2 warnings.
Rpmlint on RPM: gnome-connection-manager.noarch: W: invalid-url URL: http://kuthulu.com/gcm/ <urlopen error [Errno -2] Name or service not known> gnome-connection-manager.noarch: W: no-manual-page-for-binary gnome-connection-manager gnome-connection-manager.noarch: W: file-not-in-%lang /usr/share/gnome-connection-manager/lang/de/LC_MESSAGES/gcm-lang.mo gnome-connection-manager.noarch: W: file-not-in-%lang /usr/share/gnome-connection-manager/lang/en/LC_MESSAGES/gcm-lang.mo gnome-connection-manager.noarch: W: file-not-in-%lang /usr/share/gnome-connection-manager/lang/fr/LC_MESSAGES/gcm-lang.mo gnome-connection-manager.noarch: W: file-not-in-%lang /usr/share/gnome-connection-manager/lang/it/LC_MESSAGES/gcm-lang.mo gnome-connection-manager.noarch: W: file-not-in-%lang /usr/share/gnome-connection-manager/lang/ko/LC_MESSAGES/gcm-lang.mo gnome-connection-manager.noarch: W: file-not-in-%lang /usr/share/gnome-connection-manager/lang/pl/LC_MESSAGES/gcm-lang.mo gnome-connection-manager.noarch: W: file-not-in-%lang /usr/share/gnome-connection-manager/lang/pt/LC_MESSAGES/gcm-lang.mo gnome-connection-manager.noarch: W: file-not-in-%lang /usr/share/gnome-connection-manager/lang/ru/LC_MESSAGES/gcm-lang.mo 1 packages and 0 specfiles checked; 0 errors, 10 warnings.
[x] The package must be named according to the Package Naming Guidelines [x] The spec file name must match the base package %{name}, in the format %{name}.spec unless your package has an exemption. [x] The package must meet the Packaging Guidelines [x] The package must be licensed with a Fedora approved license and meet the Licensing Guidelines [x] The License field in the package spec file must match the actual license. Note: pyAES.py contains an expired link to the MIT license file.
[x] If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %doc
[x] The spec file must be written in American English. [x] The spec file for the package MUST be legible. [x] The sources used to build the package must match the upstream source, as provided in the spec URL. Reviewers should use sha256sum for this task as it is used by the sources file once imported into git
Source checksums ---------------- http://kuthulu.com/gcm/gnome-connection-manager_1.1.0_all.tgz : CHECKSUM(SHA256) this package : 71a128676d16153c735499cec9f0a1af1e2dc1107ed5c57cea1994eadc120c4c CHECKSUM(SHA256) upstream package : 71a128676d16153c735499cec9f0a1af1e2dc1107ed5c57cea1994eadc120c4c
[x] The package MUST successfully compile and build into binary rpms on at least one primary architecture -- Tested on x86_64. [-] If the package does not successfully compile, build or work on an architecture, then those architectures should be listed in the spec in ExcludeArch.
[x] All build dependencies must be listed in BuildRequires
[!] The spec file MUST handle locales properly. This is done by using the %find_lang macro. This needs to be fixed.
[-] Every binary RPM package (or subpackage) which stores shared library files (not just symlinks) in any of the dynamic linker's default paths, must call ldconfig in %post and %postun. [x] Packages must NOT bundle copies of system libraries. [!] A package must own all directories that it creates. pyAES.py, ssh.expect, donate.gif, icon.png, lang/ should be listed in %files.
[x] A Fedora package must not list a file more than once in the spec file's %files listings.
[x] Permissions on files must be set properly. Executables should be set with executable permissions, for example
[x] Each package must consistently use macros. [x] The package must contain code, or permissible content. [-] Large documentation files must go in a -doc subpackage. [-] If a package includes something as %doc, it must not affect the runtime of the application. To summarize: If it is in %doc, the program must run properly if it is not present [-] Static libraries must be in a -static package [-] Development files must be in a -devel package. [x] Packages must NOT contain any .la libtool archives, these must be removed in the spec if they are built [x] Packages containing GUI applications must include a %{name}.desktop file. [x] Packages must not own files or directories already owned by other packages. [x] All filenames in rpm packages must be valid UTF-8 [x] If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x] The description and summary sections in the package spec file should contain translations for supported Non-English languages, if available. [-] The reviewer should test that the package builds in mock. [!] your package should contain man pages for binaries/scripts. If it doesn't, work with upstream to add them where they make sense. [X]: Latest version is packaged.
https://bugzilla.redhat.com/show_bug.cgi?id=909887
--- Comment #5 from Pranav Kant pranav913@gmail.com --- Also, the package doesn't run on my system. It ends with following message :
Gtk-Message: Failed to load module "canberra-gtk-module" Invalid entry in configuration file: No section: 'options' Attempt to unlock mutex that was not locked Aborted
However, it builds and installs successfully.
https://bugzilla.redhat.com/show_bug.cgi?id=909887
--- Comment #6 from Mat Booth mat.booth@redhat.com --- Spec URL: https://fedorapeople.org/~mbooth/reviews/gnome-connection-manager.spec SRPM URL: https://fedorapeople.org/~mbooth/reviews/gnome-connection-manager-1.1.0-4.fc...
- Add appstream appdata. - Install locales correctly (this fixes most of the rpmlint warnings)
I don't think it makes sense to include a man page since this is a graphical application only.
It builds and runs correctly on Fedora 21. Here is a scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=8053849
https://bugzilla.redhat.com/show_bug.cgi?id=909887
Mat Booth mat.booth@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution|--- |WONTFIX Last Closed| |2015-07-02 07:06:15
--- Comment #7 from Mat Booth mat.booth@redhat.com --- Closing, I am no longer interested in maintaining this package.
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla