Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: <main package name here> - Plasma applet for managing your Telepathy account presence
https://bugzilla.redhat.com/show_bug.cgi?id=740562
Summary: Review Request: <main package name here> - Plasma applet for managing your Telepathy account presence Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: rdieter@math.unl.edu QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: ---
Spec URL: http://rdieter.fedorapeople.org/rpms/telepathy-kde/telepathy-kde-presence-ap... SRPM URL: http://rdieter.fedorapeople.org/rpms/telepathy-kde/telepathy-kde-presence-ap... Description: Plasma applet for managing your Telepathy account presence
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=740562
Rex Dieter rdieter@math.unl.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |656997(kde-reviews) Depends on| |740561, | |723123(telepathy-qt4)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=740562
Rex Dieter rdieter@math.unl.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|Review Request: <main |Review Request: |package name here> - Plasma |telepathy-kde-presence-appl |applet for managing your |et - Plasma applet for |Telepathy account presence |managing your Telepathy | |account presence
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=740562
Radek Novacek rnovacek@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |rnovacek@redhat.com AssignedTo|nobody@fedoraproject.org |rnovacek@redhat.com Flag| |fedora-review?
--- Comment #1 from Radek Novacek rnovacek@redhat.com 2011-09-23 03:45:25 EDT --- Name: ok License: ok Source: wrong, should be http://download.kde.org/unstable/telepathy-kde/%%7Bversion%7D/src/%%7Bname%7... instead of http://download.kde.org/unstable/unstable/telepathy-kde/%%7Bversion%7D/src/%... BRs/Reqs: ok Macros used consistently: ok ldconfig: NA Desktop file validations: NA Locales: NA Docs: ok Devel: NA Files: ok Build: ok rpmlint: please fix ./telepathy-kde-presence-applet.spec:4: W: mixed-use-of-spaces-and-tabs (spaces: line 2, tab: line 4)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=740562
--- Comment #2 from Rex Dieter rdieter@math.unl.edu 2011-09-23 11:24:24 EDT --- Spec URL: http://rdieter.fedorapeople.org/rpms/telepathy-kde/telepathy-kde-presence-ap... SRPM URL: http://rdieter.fedorapeople.org/rpms/telepathy-kde/telepathy-kde-presence-ap...
%changelog * Fri Sep 23 2011 Rex Dieter rdieter@fedoraproject.org 0.1.0-2 - fix Source0 URL - fix spaces/tabs
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=740562
--- Comment #3 from Kevin Kofler kevin@tigcc.ticalc.org 2011-09-25 17:54:54 EDT --- *** Bug 730328 has been marked as a duplicate of this bug. ***
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=740562
Radek Novacek rnovacek@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
--- Comment #4 from Radek Novacek rnovacek@redhat.com 2011-09-26 02:42:01 EDT --- Thanks for fixing the issues, setting fedora-review+.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=740562
Rex Dieter rdieter@math.unl.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
--- Comment #5 from Rex Dieter rdieter@math.unl.edu 2011-09-26 09:03:41 EDT --- New Package SCM Request ======================= Package Name: telepathy-kde-presence-applet Short Description: Plasma applet for managing your Telepathy account presence Owners: jreznik rdieter Branches: f15 f16
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=740562
--- Comment #6 from Jon Ciesla limb@jcomserv.net 2011-09-26 10:18:01 EDT --- Git done (by process-git-requests).
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=740562
Bug 740562 depends on bug 740561, which changed state.
Bug 740561 Summary: Review Request: telepathy-kde-presence-dataengine - Plasma dataengine for managing Telepathy account presence https://bugzilla.redhat.com/show_bug.cgi?id=740561
What |Old Value |New Value ---------------------------------------------------------------------------- Resolution| |RAWHIDE Status|ASSIGNED |CLOSED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=740562
Rex Dieter rdieter@math.unl.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |RAWHIDE Last Closed| |2011-09-26 10:37:15
--- Comment #7 from Rex Dieter rdieter@math.unl.edu 2011-09-26 10:37:15 EDT --- imported
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=740562
Kevin Kofler kevin@tigcc.ticalc.org changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |kevin@tigcc.ticalc.org
--- Comment #8 from Kevin Kofler kevin@tigcc.ticalc.org 2011-09-26 19:34:11 EDT --- This requires a script engine which isn't in Fedora yet: plasma4(scriptengine-declarativeapplet) as found by my automatic dependency extractor.
The whole applet is written in QML, it won't work at all without a script engine for QML.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=740562
--- Comment #9 from Kevin Kofler kevin@tigcc.ticalc.org 2011-09-26 19:44:42 EDT --- What 4.7 has lists these properties instead: X-EngineName=declarativeappletscript X-Plasma-API=declarativeappletscript X-KDE-PluginInfo-Name=qmlscript
Now I do think the depextractor does the wrong thing there (it prefers the X-KDE-PluginInfo-Name, but it should be using the X-Plasma-API here; that said, I think it's also broken for those properties to say different things), but still, neither of those match "declarativeapplet" which this is asking for.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=740562
--- Comment #10 from Kevin Kofler kevin@tigcc.ticalc.org 2011-09-26 20:54:16 EDT --- So it turns out that I got confused because the dependency was incorrectly hand-typed into IRC. The dependency as listed by http://koji.fedoraproject.org/koji/rpminfo?rpmID=2716469 is on plasma4(scriptengine-declarativeappletscript), which is correct. The problem is that the autoprov script gets confused because the .desktop file for the script engine has a name != the API for some stupid reason.
I need to fix the autoprov script to ignore the name and only pick the API for script engines.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=740562
--- Comment #11 from Kevin Kofler kevin@tigcc.ticalc.org 2011-09-26 21:23:29 EDT --- This chain build should fix the autoprov: http://koji.fedoraproject.org/koji/taskinfo?taskID=3380164
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=740562
--- Comment #12 from Kevin Kofler kevin@tigcc.ticalc.org 2011-09-26 21:25:31 EDT --- FYI, this is the relevant kde-settings commit: https://fedorahosted.org/kde-settings/changeset/294
package-review@lists.fedoraproject.org