[Bug 2358792] New: Review Request: wget - A utility for retrieving files using the HTTP or FTP protocols

https://bugzilla.redhat.com/show_bug.cgi?id=2358792

Bug ID: 2358792
           Summary: Review Request: wget -  A utility for retrieving files
                    using the HTTP or FTP protocols
           Product: Fedora
           Version: rawhide
          Hardware: All
                OS: Linux
            Status: NEW
         Component: Package Review
          Severity: medium
          Priority: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]
  Target Milestone: ---
    Classification: Fedora

Spec URL:
https://download.copr.fedorainfracloud.org/results/mruprich/wget/fedora-rawh...

SRPM URL:
https://download.copr.fedorainfracloud.org/results/mruprich/wget/fedora-rawh...

Description: Adding the original wget package back to Fedora. wget2 did not
meet expectations and is not ready for the distribution.

Fedora Account System Username: mruprich

[Bug 2358792] Review Request: wget - A utility for retrieving files using the HTTP or FTP protocols

https://bugzilla.redhat.com/show_bug.cgi?id=2358792

Fedora Review Service  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |http://www.gnu.org/software
                   |                            |/wget/

--- Comment #1 from Fedora Review Service  ---
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8885673
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...

Found issues:

- License file COPYING is not marked as %license
  Read more:
https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuideline...
- A package with this name already exists. Please check
https://src.fedoraproject.org/rpms/wget,
https://src.fedoraproject.org/tests/wget
  Read more:
https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicti...

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

[Bug 2358792] Review Request: wget - A utility for retrieving files using the HTTP or FTP protocols

https://bugzilla.redhat.com/show_bug.cgi?id=2358792

Benson Muite  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #2 from Benson Muite  ---
How will conflicts with the wget subpackage of wget2 be managed?

[Bug 2358792] Review Request: wget - A utility for retrieving files using the HTTP or FTP protocols

https://bugzilla.redhat.com/show_bug.cgi?id=2358792

--- Comment #3 from Michal Ruprich  ---
I will create a PR for wget2 to remove the wget2-wget package. This way wget
will provide webclient and wget2 will be a separate package.

[Bug 2358792] Review Request: wget - A utility for retrieving files using the HTTP or FTP protocols

https://bugzilla.redhat.com/show_bug.cgi?id=2358792

Neal Gompa  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #4 from Neal Gompa  ---
Please call this wget1 instead. And instead add a wget1-wget subpackage for
those who want to switch the default.

[Bug 2358792] Review Request: wget - A utility for retrieving files using the HTTP or FTP protocols

https://bugzilla.redhat.com/show_bug.cgi?id=2358792

Neal Gompa  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|[e-mail]    |[e-mail]
              Flags|                            |fedora-review?

[Bug 2358792] Review Request: wget - A utility for retrieving files using the HTTP or FTP protocols

https://bugzilla.redhat.com/show_bug.cgi?id=2358792

--- Comment #5 from Michal Ruprich  ---
Hi Neal, I still don't get why it should be renamed to wget1. We could just
un-retire the package as per the Package Retirement Process, no need to rename
it to something else -
https://docs.fedoraproject.org/en-US/package-maintainers/Package_Retirement_...

This way we can un-retire it in not just rawhide but also older branches.

[Bug 2358792] Review Request: wget - A utility for retrieving files using the HTTP or FTP protocols

https://bugzilla.redhat.com/show_bug.cgi?id=2358792

--- Comment #6 from Neal Gompa  ---
Renaming it doesn't stop you from putting it in other branches. In fact, my
suggestion *specifically* makes it possible for people to use wget1 as the wget
provider, because all we have to do is drop the Obsoletes and people would be
able to choose to switch to it on their systems.

[Bug 2358792] Review Request: wget - A utility for retrieving files using the HTTP or FTP protocols

https://bugzilla.redhat.com/show_bug.cgi?id=2358792

--- Comment #7 from Michal Ruprich  ---
Hi Neal,

sorry for the delay, long Public Holiday here. So just to be sure how you mean
it. Both packages will have Conflicts: and the only way to install one or the
other will be with --allowerasing? Or am I missing some details here?

[Bug 2358792] Review Request: wget - A utility for retrieving files using the HTTP or FTP protocols

https://bugzilla.redhat.com/show_bug.cgi?id=2358792

--- Comment #8 from Neal Gompa  ---
Basically, the base package will be wget1, then a subpackage wget1-wget will
exist that Provides+Conflicts: wget, and users can opt into wget1 by doing "dnf
swap wget2-wget wget1-wget" or "dnf install --allowerasing wget1-wget" to
switch.

[Bug 2358792] Review Request: wget - A utility for retrieving files using the HTTP or FTP protocols

https://bugzilla.redhat.com/show_bug.cgi?id=2358792

--- Comment #9 from Michal Ruprich  ---
Alright, got it. New build below:

Spec URL:
https://download.copr.fedorainfracloud.org/results/mruprich/wget/fedora-rawh...

SRPM URL:
https://download.copr.fedorainfracloud.org/results/mruprich/wget/fedora-rawh...

[Bug 2358792] Review Request: wget - A utility for retrieving files using the HTTP or FTP protocols

https://bugzilla.redhat.com/show_bug.cgi?id=2358792

--- Comment #10 from Neal Gompa  ---
Created attachment 2087600
  --> https://bugzilla.redhat.com/attachment.cgi?id=2087600&action=edit
Fixes for the wget1.spec file

There's a few more changes you need to make, including renaming the spec file
to wget1.spec.

I've attached a diff you can apply to resolve the rest of the issues.

[Bug 2358792] Review Request: wget - A utility for retrieving files using the HTTP or FTP protocols

https://bugzilla.redhat.com/show_bug.cgi?id=2358792

--- Comment #11 from Michal Ruprich  ---
Thanks, latest files below:

Spec URL:
https://download.copr.fedorainfracloud.org/results/mruprich/wget/fedora-rawh...

SRPM URL:
https://download.copr.fedorainfracloud.org/results/mruprich/wget/fedora-rawh...

[Bug 2358792] Review Request: wget - A utility for retrieving files using the HTTP or FTP protocols

https://bugzilla.redhat.com/show_bug.cgi?id=2358792

--- Comment #12 from Michal Ruprich  ---
I've seen a couple of issues with the fedora-review tool, I will run it again
and upload the results manually.

[Bug 2358792] Review Request: wget - A utility for retrieving files using the HTTP or FTP protocols

https://bugzilla.redhat.com/show_bug.cgi?id=2358792

--- Comment #13 from Michal Ruprich  ---
Created attachment 2087729
  --> https://bugzilla.redhat.com/attachment.cgi?id=2087729&action=edit
Review

[Bug 2358792] Review Request: wget1 - A utility for retrieving files using the HTTP or FTP protocols

https://bugzilla.redhat.com/show_bug.cgi?id=2358792

Neal Gompa  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Review Request: wget -  A   |Review Request: wget1 -  A
                   |utility for retrieving      |utility for retrieving
                   |files using the HTTP or FTP |files using the HTTP or FTP
                   |protocols                   |protocols

[Bug 2358792] Review Request: wget1 - A utility for retrieving files using the HTTP or FTP protocols

https://bugzilla.redhat.com/show_bug.cgi?id=2358792

--- Comment #14 from Neal Gompa  ---
> %doc AUTHORS MAILING-LIST NEWS README COPYING doc/sample.wgetrc

This needs to be changed to:
> %license AUTHORS COPYING
> %doc MAILING-LIST NEWS README doc/sample.wgetrc

[Bug 2358792] Review Request: wget1 - A utility for retrieving files using the HTTP or FTP protocols

https://bugzilla.redhat.com/show_bug.cgi?id=2358792

--- Comment #15 from Michal Ruprich  ---
Phew, this could work:

Spec URL:
https://download.copr.fedorainfracloud.org/results/mruprich/wget/fedora-rawh...

SRPM URL:
https://download.copr.fedorainfracloud.org/results/mruprich/wget/fedora-rawh...

Sorry, doing multiple things at once did not turn out great for me here...

[Bug 2358792] Review Request: wget1 - A utility for retrieving files using the HTTP or FTP protocols

https://bugzilla.redhat.com/show_bug.cgi?id=2358792

Michal Ruprich  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Attachment|0                           |1
        #2087729 is|                            |
           obsolete|                            |

[Bug 2358792] Review Request: wget1 - A utility for retrieving files using the HTTP or FTP protocols

https://bugzilla.redhat.com/show_bug.cgi?id=2358792

Michal Ruprich  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
     Comment #16 is|1                           |0
            private|                            |

[Bug 2358792] Review Request: wget1 - A utility for retrieving files using the HTTP or FTP protocols

https://bugzilla.redhat.com/show_bug.cgi?id=2358792

Neal Gompa  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

--- Comment #17 from Neal Gompa  ---
This is missing a changelog entry for the update to 1.25.0 and the rename to
wget1.

* Mon May 05 2025 Michal Ruprich <mruprich at redhat> - 1.25.0
- Update to 1.25.0
- Rename package to wget1
- Add wget1-wget subpackage to allow usage as wget

[Bug 2358792] Review Request: wget1 - A utility for retrieving files using the HTTP or FTP protocols

https://bugzilla.redhat.com/show_bug.cgi?id=2358792

--- Comment #18 from Neal Gompa  ---
Blech, this is more or less what it should be (obviously fix the email address
part of the author):

* Mon May 05 2025 Michal Ruprich <mruprich at redhat> - 1.25.0-1
- Update to 1.25.0
- Rename package to wget1
- Add wget1-wget subpackage to allow usage as wget

[Bug 2358792] Review Request: wget1 - A utility for retrieving files using the HTTP or FTP protocols

https://bugzilla.redhat.com/show_bug.cgi?id=2358792

--- Comment #19 from Michal Ruprich  ---
Spec URL:
https://download.copr.fedorainfracloud.org/results/mruprich/wget/fedora-rawh...

SRPM URL:
https://download.copr.fedorainfracloud.org/results/mruprich/wget/fedora-rawh...

[Bug 2358792] Review Request: wget1 - A utility for retrieving files using the HTTP or FTP protocols

https://bugzilla.redhat.com/show_bug.cgi?id=2358792

Fedora Review Service  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |AutomationTriaged

--- Comment #20 from Fedora Review Service  ---
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8997532
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

[Bug 2358792] Review Request: wget1 - A utility for retrieving files using the HTTP or FTP protocols

https://bugzilla.redhat.com/show_bug.cgi?id=2358792

Neal Gompa  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+
             Status|ASSIGNED                    |POST

--- Comment #21 from Neal Gompa  ---
Review notes:

* Package follows Fedora Packaging Guidelines
* Package builds and installs
* Package licensing is correct and license files are captured properly
* No serious issues from rpmlint

PACKAGE APPROVED.

[Bug 2358792] Review Request: wget1 - A utility for retrieving files using the HTTP or FTP protocols

https://bugzilla.redhat.com/show_bug.cgi?id=2358792

Michal Ruprich  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|AutomationTriaged           |

[Bug 2358792] Review Request: wget1 - A utility for retrieving files using the HTTP or FTP protocols

https://bugzilla.redhat.com/show_bug.cgi?id=2358792

--- Comment #22 from Michal Ruprich  ---
Now that I think of it, this is not technically an unretirement since the
package is now renamed to wget1 so even the repository should be different and
renamed. Removing the unretirement from the Whiteboard and proceeding with the
regular process.

[Bug 2358792] Review Request: wget1 - A utility for retrieving files using the HTTP or FTP protocols

https://bugzilla.redhat.com/show_bug.cgi?id=2358792

Fedora Admin user for bugzilla script actions  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|POST                        |RELEASE_PENDING

--- Comment #23 from Fedora Admin user for bugzilla script actions  ---
The Pagure repository was created at https://src.fedoraproject.org/rpms/wget1

[Bug 2358792] Review Request: wget1 - A utility for retrieving files using the HTTP or FTP protocols

https://bugzilla.redhat.com/show_bug.cgi?id=2358792

--- Comment #24 from Michal Ruprich  ---
Stuck on a failing unit test on aarch64:

https://koji.fedoraproject.org/koji/buildinfo?buildID=2710743

I am debugging the issue.