Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: ovirt-viewer - A vnc viewer for oVirt managed vms
https://bugzilla.redhat.com/show_bug.cgi?id=513497
Summary: Review Request: ovirt-viewer - A vnc viewer for oVirt managed vms Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: mmorsi@redhat.com QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Target Release: ---
Spec URL: http://mohammed.morsi.org/blog/files/ovirt-viewer.spec SRPM URL: http://mohammed.morsi.org/blog/files/ovirt-viewer-1.0.0-5.fc10.src_.rpm
Description: ovirt-viewer is a vnc viewer which integrates nicely into the ovirt framework. When running the program, the user is prompted for the ovirt server url and login credentials, after which a list of accessible vms is retrieved, any of which the user may connect to via vnc. ovirt-viewer manages all connections on the backend and allows the users to seamlessly switch between managed vms via ui.
Latest Koji Build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1496325
This is intended to be used in conjunction with https://bugzilla.redhat.com/show_bug.cgi?id=513069
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=513497
Fabian Affolter fabian@bernewireless.net changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |fabian@bernewireless.net
--- Comment #1 from Fabian Affolter fabian@bernewireless.net 2009-07-24 11:19:56 EDT --- Just some comments after a quick look at your spec file:
- You are mixing '%{buildroot}' and '$RPM_BUILD_ROOT'
https://fedoraproject.org/wiki/Packaging:Guidelines#Using_.25.7Bbuildroot.7D... Please take a look at https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag
- The man pages are automatically compressed by RPM
- README and COPYING must be added to the %files section. https://fedoraproject.org/wiki/How_to_create_an_RPM_package#.25files_prefixe...
- Isn't %configure instead of ./configure working? https://fedoraproject.org/wiki/How_to_create_an_RPM_package#.25build_section
- Aren't gtk2, gtk-vnc, and gnutls automatically picked up by RPM?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=513497
--- Comment #2 from Fabian Affolter fabian@bernewireless.net 2009-12-23 07:39:35 EDT --- ping?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=513497
Fabian Affolter fabian@bernewireless.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |needinfo?(mmorsi@redhat.com | |)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=513497
Mohammed Morsi mmorsi@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution| |WONTFIX Flag|needinfo?(mmorsi@redhat.com | |) |
--- Comment #3 from Mohammed Morsi mmorsi@redhat.com 2010-01-05 11:50:33 EDT --- Sorry for the belated followup. Priorities shifted and didn't/don't have time to work on this, thus am closing. If anyone wants to resume work on the viewer itself or packaging it for Fedora, feel free to ping me w/ any questions you may have.
package-review@lists.fedoraproject.org