Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: grantlee - Qt string template engine based on the Django template system
https://bugzilla.redhat.com/show_bug.cgi?id=583058
Summary: Review Request: grantlee - Qt string template engine based on the Django template system Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: thomasj@fedoraproject.org QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora
Spec URL: http://thomasj.fedorapeople.org/reviews/grantlee.spec SRPM URL: http://thomasj.fedorapeople.org/reviews/grantlee-0.1.0-1.fc12.src.rpm Description: Grantlee is a plug-in based String Template system written using the Qt framework. The goals of the project are to make it easier for application developers to separate the structure of documents from the data they contain, opening the door for themeing.
The syntax is intended to follow the syntax of the Django template system, and the design of Django is reused in Grantlee. Django is covered by a BSD style license.
Part of the design of both is that application developers can extend the syntax by implementing their own tags and filters. For details of how to do that, see the API documentation.
For template authors, different applications using Grantlee will present the same interface and core syntax for creating new themes. For details of how to write templates, see the documentation.
http://koji.fedoraproject.org/koji/taskinfo?taskID=2118862
[thomas@tusdell SPECS]$ rpmlint grantlee.spec ../SRPMS/grantlee-0.1.0-1.fc12.src.rpm ../RPMS/x86_64/grantlee-* grantlee.src: W: spelling-error %description -l en_US themeing -> theme, thematic, therein grantlee.src: W: spelling-error %description -l en_US Django -> Fandango, Quango, Bangor grantlee.x86_64: W: spelling-error %description -l en_US themeing -> theme, thematic, therein grantlee.x86_64: W: spelling-error %description -l en_US Django -> Fandango, Quango, Bangor grantlee-devel.x86_64: W: no-documentation 4 packages and 1 specfiles checked; 0 errors, 5 warnings.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=583058
Jaroslav Reznik jreznik@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@fedoraproject.org |jreznik@redhat.com Flag| |fedora-review?
--- Comment #1 from Jaroslav Reznik jreznik@redhat.com 2010-04-19 08:15:21 EDT --- Rpmlint: ok (spelling warnings) Package and SPEC name: ok License: ok Upstream source code: ok (3ec14214f30cc86d10c3cab2d062ff3e grantlee-v0.1.0.tar.gz) Package builds: ok, see scratch build + tested locally ldconfig: ok BuildRequires: ok Devel split: ok No libtools archives: ok
Group should be "System Environment/Libraries". I see doxygen and documentation commented out - what's the problem there? I think it should be shipped together.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=583058
--- Comment #2 from Thomas Janssen thomasj@fedoraproject.org 2010-05-09 14:29:37 EDT --- Spec URL: http://thomasj.fedorapeople.org/reviews/grantlee.spec SRPM URL: http://thomasj.fedorapeople.org/reviews/grantlee-0.1.1-1.fc12.src.rpm
- fixed Group - grantlee-0.1.1
You said in IRC you wanted to test the doxygen part out, some progress?
Rpmlint are still some strange spelling warnings, else clean.
http://koji.fedoraproject.org/koji/taskinfo?taskID=2175805
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=583058
--- Comment #3 from Jaroslav Reznik jreznik@redhat.com 2010-05-11 06:46:36 EDT --- Looking on it right now.
For spelling error s/themeing/theming.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=583058
--- Comment #4 from Jaroslav Reznik jreznik@redhat.com 2010-05-11 09:25:38 EDT --- Created an attachment (id=413136) --> (https://bugzilla.redhat.com/attachment.cgi?id=413136) Adds apidocs
I'm not sure this patch is correct - location for apidocs?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=583058
--- Comment #5 from Jaroslav Reznik jreznik@redhat.com 2010-05-11 11:28:23 EDT --- Correct location for apidocs has been discussed on KDE SIG meeting, decision postponed to next meeting.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=583058
--- Comment #6 from Chen Lei supercyper1@gmail.com 2010-05-13 06:22:55 EDT --- %{_docdir}/HTML/en/grantlee-apidocs still seems a bit strange, maybe %{_docdir}/HTML/grantlee-apidocs/en is more appropriate if we consider the fedora-release-notes package.
ls /usr/share/doc/HTML/fedora-release-notes/
cs-CZ es-ES index.html nl-NL pt-PT uk-UA en-US fr-FR it-IT pl-PL sv-SE zh-CN
The installation path and subpackage name for html documentation is really a mess in fedora and need further consideration.
The guideline only has one line about this - if there's a lot of documentation, consider putting it into a subpackage.
http://fedoraproject.org/wiki/PackagingGuidelines#Documentation
Actually, we now have several subpackage name for html documention. E.g -doc -docs -devel-doc -devel-docs -apidocs -manual
We also have several installation path for those html files(normally built by docbook or doxygen).
%{_docdir}/%{name}-%{version} %{_docdir}/%{name}-[subpackagename]-%{version} %{_docdir}/%{name} %{_docdir}/HTML/%{name} %{_docdir}/HTML/[locale]/%{name} %{_datadir}/gtk-doc/html/%{name}
In java package guideline,we have %{_datadir}/javadoc/%{name}-%{version} for -javadoc subpackage %{_docdir}/%{name}-[subpackagename]-%{version} for -manual subpackage
I think add a fixed installation path for html apidocs or enduser manuals like man or info will benefit all of us a lot .
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=583058
--- Comment #7 from Jaroslav Reznik jreznik@redhat.com 2010-05-18 11:12:10 EDT --- For KDE libraries we agreed on /usr/share/doc/HTML/en/%{name}-apidocs as kdelibs and kdepimlibs already uses this location and these two are most important for us.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=583058
--- Comment #8 from Jaroslav Reznik jreznik@redhat.com 2010-05-18 11:21:15 EDT --- (In reply to comment #6)
%{_docdir}/HTML/en/grantlee-apidocs still seems a bit strange, maybe %{_docdir}/HTML/grantlee-apidocs/en is more appropriate if we consider the fedora-release-notes package.
ls /usr/share/doc/HTML/fedora-release-notes/
cs-CZ es-ES index.html nl-NL pt-PT uk-UA en-US fr-FR it-IT pl-PL sv-SE zh-CN
The installation path and subpackage name for html documentation is really a mess in fedora and need further consideration.
The guideline only has one line about this - if there's a lot of documentation, consider putting it into a subpackage.
http://fedoraproject.org/wiki/PackagingGuidelines#Documentation
Actually, we now have several subpackage name for html documention. E.g -doc -docs -devel-doc -devel-docs -apidocs -manual
We also have several installation path for those html files(normally built by docbook or doxygen).
%{_docdir}/%{name}-%{version} %{_docdir}/%{name}-[subpackagename]-%{version} %{_docdir}/%{name} %{_docdir}/HTML/%{name} %{_docdir}/HTML/[locale]/%{name} %{_datadir}/gtk-doc/html/%{name}
In java package guideline,we have %{_datadir}/javadoc/%{name}-%{version} for -javadoc subpackage %{_docdir}/%{name}-[subpackagename]-%{version} for -manual subpackage
I think add a fixed installation path for html apidocs or enduser manuals like man or info will benefit all of us a lot .
Indeed it's a mess, so we are trying to fix it at least on our KDE side. But sistribution wide solution would be really very nice.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=583058
--- Comment #9 from Chen Lei supercyper1@gmail.com 2010-05-18 11:28:43 EDT --- (In reply to comment #7)
For KDE libraries we agreed on /usr/share/doc/HTML/en/%{name}-apidocs as kdelibs and kdepimlibs already uses this location and these two are most important for us.
Can KDE-SIG talk with fedora-release-notes group?
I installed F13 KDE spin, and found a bit inconsistence of using /usr/share/doc/HTML between kde-filesystem and fedora-release-notes, both packages are the default components of KDE spin.
As I said before, fedora-release-notes installs their files to /usr/share/doc/HTML/fedora-release-notes/, it contains an index.html and some diretories with different locale names, which conflicts with the using of /usr/share/doc/HTML in kde-filesystem.
Note:
Currently, in fedora repo kde-filesystem and fedora-release-notes own /usr/share/doc/HTML.
/usr/share/doc/HTML/en/%{name}-apidocs is the search PATH of kdedevelop.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=583058
--- Comment #10 from Jaroslav Reznik jreznik@redhat.com 2010-05-18 11:44:14 EDT --- (In reply to comment #9)
(In reply to comment #7)
For KDE libraries we agreed on /usr/share/doc/HTML/en/%{name}-apidocs as kdelibs and kdepimlibs already uses this location and these two are most important for us.
Can KDE-SIG talk with fedora-release-notes group?
I installed F13 KDE spin, and found a bit inconsistence of using /usr/share/doc/HTML between kde-filesystem and fedora-release-notes, both packages are the default components of KDE spin.
As I said before, fedora-release-notes installs their files to /usr/share/doc/HTML/fedora-release-notes/, it contains an index.html and some diretories with different locale names, which conflicts with the using of /usr/share/doc/HTML in kde-filesystem.
Note:
Currently, in fedora repo kde-filesystem and fedora-release-notes own /usr/share/doc/HTML.
/usr/share/doc/HTML/en/%{name}-apidocs is the search PATH of kdedevelop.
It's default KDE upstream installation schema...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=583058
Jaroslav Reznik jreznik@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
--- Comment #11 from Jaroslav Reznik jreznik@redhat.com 2010-05-18 11:46:24 EDT --- Thomas, seems like we still don't have proper solution for apidocs - but we need Grantlee. I'm not going to block this review more - for now, not shipping apidocs would be best solution (just set apidocs to 0) and add comment somewhere in SPEC file.
APPROVED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=583058
--- Comment #12 from Thomas Janssen thomasj@fedoraproject.org 2010-05-18 15:33:32 EDT --- Disabled apidocs until we agree on a standard path.
Spec URL: http://thomasj.fedorapeople.org/reviews/grantlee.spec SRPM URL: http://thomasj.fedorapeople.org/reviews/grantlee-0.1.0-3.fc12.src.rpm
Thanks for the review Jaroslav.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=583058
Thomas Janssen thomasj@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
--- Comment #13 from Thomas Janssen thomasj@fedoraproject.org 2010-05-18 15:36:23 EDT --- New Package CVS Request ======================= Package Name: grantlee Short Description: Qt string template engine based on the Django template system Owners: thomasj Branches: F-12 F-13 InitialCC: than
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=583058
Dennis Gilmore dennis@ausil.us changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
--- Comment #14 from Dennis Gilmore dennis@ausil.us 2010-05-18 16:47:10 EDT --- CVS Done
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=583058
--- Comment #15 from Fedora Update System updates@fedoraproject.org 2010-05-19 06:51:35 EDT --- grantlee-0.1.1-3.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/grantlee-0.1.1-3.fc13
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=583058
--- Comment #16 from Fedora Update System updates@fedoraproject.org 2010-05-19 06:51:41 EDT --- grantlee-0.1.1-3.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/grantlee-0.1.1-3.fc12
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=583058
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |ON_QA
--- Comment #17 from Fedora Update System updates@fedoraproject.org 2010-05-19 15:11:21 EDT --- grantlee-0.1.1-3.fc13 has been pushed to the Fedora 13 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update grantlee'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/grantlee-0.1.1-3.fc13
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=583058
--- Comment #18 from Fedora Update System updates@fedoraproject.org 2010-05-19 15:20:13 EDT --- grantlee-0.1.1-3.fc12 has been pushed to the Fedora 12 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update grantlee'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/grantlee-0.1.1-3.fc12
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=583058
--- Comment #19 from Fedora Update System updates@fedoraproject.org 2010-06-04 14:48:21 EDT --- grantlee-0.1.1-3.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=583058
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Fixed In Version| |grantlee-0.1.1-3.fc12 Resolution| |ERRATA
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=583058
--- Comment #20 from Fedora Update System updates@fedoraproject.org 2010-06-04 14:55:59 EDT --- grantlee-0.1.1-3.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=583058
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|grantlee-0.1.1-3.fc12 |grantlee-0.1.1-3.fc13
package-review@lists.fedoraproject.org