https://bugzilla.redhat.com/show_bug.cgi?id=847712
Bug ID: 847712 QA Contact: extras-qa@fedoraproject.org Severity: unspecified Version: rawhide Priority: unspecified CC: notting@redhat.com, package-review@lists.fedoraproject.org Assignee: nobody@fedoraproject.org Summary: Review Request: mate-menus - Displays menus for MATE Desktop Regression: --- Story Points: --- Classification: Fedora OS: Unspecified Reporter: dan.mashal@gmail.com Type: Bug Documentation: --- Hardware: Unspecified Mount Type: --- Status: NEW Component: Package Review Product: Fedora
Spec URL: http://vicodan.fedorapeople.org/matespec/mate-menus.spec SRPM URL: http://vicodan.fedorapeople.org/materpms/srpms/mate-menus-1.4.0-1.fc17.src.r... Description: Displays menus for MATE Desktop
https://bugzilla.redhat.com/show_bug.cgi?id=847712
Dan Mashal dan.mashal@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |rdieter@math.unl.edu Blocks| |840149 (MATE-DE-tracker) Alias| |mate-menus
https://bugzilla.redhat.com/show_bug.cgi?id=847712
leigh scott leigh123linux@googlemail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |leigh123linux@googlemail.co | |m
--- Comment #1 from leigh scott leigh123linux@googlemail.com --- Ok there is a ownership issue, change this
%files -f %{name}.lang %doc AUTHORS COPYING README %config(noreplace) %{_sysconfdir}/xdg/menus/mate-applications.menu %config(noreplace) %{_sysconfdir}/xdg/menus/mate-settings.menu %{_datadir}/mate-menus/examples/mate-menus-ls.py %{_datadir}/mate-menus/examples/mate-menus-ls.pyc %{_datadir}/mate-menus/examples/mate-menus-ls.pyo %{_datadir}/mate/desktop-directories/
to (mate-menus owns %{_datadir}/mate-menus/ )
%files -f %{name}.lang %doc AUTHORS COPYING README %config(noreplace) %{_sysconfdir}/xdg/menus/mate-applications.menu %config(noreplace) %{_sysconfdir}/xdg/menus/mate-settings.menu %{_datadir}/mate-menus/ %{_datadir}/mate/desktop-directories/
https://bugzilla.redhat.com/show_bug.cgi?id=847712
--- Comment #2 from Dan Mashal dan.mashal@gmail.com --- Done.
Spec URL: http://vicodan.fedorapeople.org/matespec/mate-menus.spec SRPM URL: http://vicodan.fedorapeople.org/materpms/srpms/mate-menus-1.4.0-2.fc17.src.r... Description: Displays menus for MATE Desktop
https://bugzilla.redhat.com/show_bug.cgi?id=847712
--- Comment #3 from leigh scott leigh123linux@googlemail.com --- please change this
%package devel Summary: Development files for mate-menus Requires: %{name}%{?_isa} = %{version}-%{release} Requires: %{name}-libs%{?_isa} = %{version}-%{release}
to
%package devel Summary: Development files for mate-menus Requires: %{name}-libs%{?_isa} = %{version}-%{release}
as the -libs package already requires it.
https://bugzilla.redhat.com/show_bug.cgi?id=847712
--- Comment #4 from Dan Mashal dan.mashal@gmail.com --- Done.
Spec URL: http://vicodan.fedorapeople.org/matespec/mate-menus.spec SRPM URL: http://vicodan.fedorapeople.org/materpms/srpms/mate-menus-1.4.0-3.fc17.src.r... Description: Displays menus for MATE Desktop
https://bugzilla.redhat.com/show_bug.cgi?id=847712
Rex Dieter rdieter@math.unl.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@fedoraproject.org |rdieter@math.unl.edu Flags| |fedora-review?
--- Comment #5 from Rex Dieter rdieter@math.unl.edu --- I'll review this today
https://bugzilla.redhat.com/show_bug.cgi?id=847712
Rex Dieter rdieter@math.unl.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #6 from Rex Dieter rdieter@math.unl.edu --- 1. So, looking at the main package, there's little risk of multilib conflicts (no binaries in particular), so I'm tempted to suggest dropping the -libs subpkg, and just fold all it's content (and scriptlets) into the main pkg (that's how gnome-menus is packaged, fwiw).
2. SHOULD move NOCONFIGURE=1 ./autogen.sh to %prep section
3. SHOULD: noticed /usr/share/mate dir is unowned, will leave to you to decide where in the mate stack would best own this. checking /usr/share/gnome $ rpm -q -f /usr/share/gnome filesystem-3-2.fc17.x86_64 not helpful here. :(
4. SHOULD investigate if we need Requires: redhat-menus here somewhere. (ie, test running this and mate without redhat-menus installed, to see if there's any regressions or oddities)
otherwise,
naming: ok
macros: ok
scriptlets: ok
sources: ok
$ md5sum *.xz 540af0f76e2a28821cf4d32832c784d2 mate-menus-1.4.0.tar.xz
licensing: ok
items 1-4 aren't strictly blockers, but please do comment on or address them prior to doing any builds.
APPROVED.
https://bugzilla.redhat.com/show_bug.cgi?id=847712
--- Comment #7 from leigh scott leigh123linux@googlemail.com --- (In reply to comment #6)
- SHOULD: noticed /usr/share/mate dir is unowned, will leave to you to
decide where in the mate stack would best own this. checking /usr/share/gnome $ rpm -q -f /usr/share/gnome filesystem-3-2.fc17.x86_64 not helpful here. :(
It seems mate-dialogs currently owns /usr/share/mate
yum --enablerepo updates-t* whatprovides /usr/share/mate Loaded plugins: fastestmirror, langpacks, presto, refresh-packagekit, remove-with-leaves, show-leaves Loading mirror speeds from cached hostfile * fedora: mirror01.th.ifl.net * rpmfusion-free: mirror01.th.ifl.net * rpmfusion-free-updates: mirror01.th.ifl.net * rpmfusion-nonfree: mirror01.th.ifl.net * rpmfusion-nonfree-updates: mirror01.th.ifl.net * updates: mirror01.th.ifl.net * updates-testing: mirror01.th.ifl.net * updates-testing-debuginfo: mirror01.th.ifl.net * updates-testing-source: mirror01.th.ifl.net mate-dialogs-1.4.0-2.fc17.x86_64 : Displays dialog boxes from shell scripts Repo : updates-testing Matched from: Filename : /usr/share/mate
https://bugzilla.redhat.com/show_bug.cgi?id=847712
--- Comment #8 from leigh scott leigh123linux@googlemail.com --- (In reply to comment #7)
(In reply to comment #6)
- SHOULD: noticed /usr/share/mate dir is unowned, will leave to you to
decide where in the mate stack would best own this. checking /usr/share/gnome $ rpm -q -f /usr/share/gnome filesystem-3-2.fc17.x86_64 not helpful here. :(
It seems mate-dialogs currently owns /usr/share/mate
yum --enablerepo updates-t* whatprovides /usr/share/mate Loaded plugins: fastestmirror, langpacks, presto, refresh-packagekit, remove-with-leaves, show-leaves Loading mirror speeds from cached hostfile
- fedora: mirror01.th.ifl.net
- rpmfusion-free: mirror01.th.ifl.net
- rpmfusion-free-updates: mirror01.th.ifl.net
- rpmfusion-nonfree: mirror01.th.ifl.net
- rpmfusion-nonfree-updates: mirror01.th.ifl.net
- updates: mirror01.th.ifl.net
- updates-testing: mirror01.th.ifl.net
- updates-testing-debuginfo: mirror01.th.ifl.net
- updates-testing-source: mirror01.th.ifl.net
mate-dialogs-1.4.0-2.fc17.x86_64 : Displays dialog boxes from shell scripts Repo : updates-testing Matched from: Filename : /usr/share/mate
I believe the best solution here is to give mate-session ownership of /usr/share/mate
https://bugzilla.redhat.com/show_bug.cgi?id=847712
Mario Blättermann mario.blaettermann@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |849709 | |(mate-control-center)
https://bugzilla.redhat.com/show_bug.cgi?id=847712
Dan Mashal dan.mashal@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?
--- Comment #9 from Dan Mashal dan.mashal@gmail.com --- New Package SCM Request ======================= Package Name: mate-menus Short Description: Displays menus for MATE Desktop Owners: vicodan raveit65 rdieter Branches: f16 f17 f18 InitialCC:
https://bugzilla.redhat.com/show_bug.cgi?id=847712
--- Comment #10 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).
https://bugzilla.redhat.com/show_bug.cgi?id=847712
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
https://bugzilla.redhat.com/show_bug.cgi?id=847712
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- mate-menus-1.4.0-3.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/mate-menus-1.4.0-3.fc18
https://bugzilla.redhat.com/show_bug.cgi?id=847712
--- Comment #12 from Fedora Update System updates@fedoraproject.org --- mate-menus-1.4.0-3.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/mate-menus-1.4.0-3.fc17
https://bugzilla.redhat.com/show_bug.cgi?id=847712
--- Comment #13 from Fedora Update System updates@fedoraproject.org --- mate-menus-1.4.0-3.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/mate-menus-1.4.0-3.fc16
https://bugzilla.redhat.com/show_bug.cgi?id=847712
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #14 from Fedora Update System updates@fedoraproject.org --- mate-menus-1.4.0-3.fc18 has been pushed to the Fedora 18 testing repository.
https://bugzilla.redhat.com/show_bug.cgi?id=847712
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed| |2012-08-22 16:59:29
--- Comment #15 from Fedora Update System updates@fedoraproject.org --- mate-menus-1.4.0-3.fc17 has been pushed to the Fedora 17 stable repository.
https://bugzilla.redhat.com/show_bug.cgi?id=847712
Dan Mashal dan.mashal@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks|849709 | |(mate-control-center) |
https://bugzilla.redhat.com/show_bug.cgi?id=847712
--- Comment #16 from Fedora Update System updates@fedoraproject.org --- mate-menus-1.4.0-3.fc18 has been pushed to the Fedora 18 stable repository.
https://bugzilla.redhat.com/show_bug.cgi?id=847712
Dan McPherson dmcphers@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |kwoodson@redhat.com
--- Comment #17 from Dan McPherson dmcphers@redhat.com --- *** Bug 874722 has been marked as a duplicate of this bug. ***
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=847712
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|ERRATA |CURRENTRELEASE
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=847712
--- Comment #18 from Fedora Update System updates@fedoraproject.org --- mate-menus-1.4.0-3.fc16 has been pushed to the Fedora 16 stable repository.
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla