https://bugzilla.redhat.com/show_bug.cgi?id=2327746
Bug ID: 2327746 Summary: Review Request: rust-derive-where - Deriving with custom trait bounds Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nobody@fedoraproject.org Reporter: alebastr89@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://alebastr.fedorapeople.org/review/rust-derive-where.spec SRPM URL: https://alebastr.fedorapeople.org/review/rust-derive-where-1.2.7-1.fc41.src....
Description: Deriving with custom trait bounds.
Fedora Account System Username: alebastr
https://bugzilla.redhat.com/show_bug.cgi?id=2327746
--- Comment #1 from Aleksei Bavshin alebastr89@gmail.com --- This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=126074467
https://bugzilla.redhat.com/show_bug.cgi?id=2327746
Aleksei Bavshin alebastr89@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |2315803 Doc Type|--- |If docs needed, set a value
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2315803 [Bug 2315803] rust-just-1.37.0 is available
https://bugzilla.redhat.com/show_bug.cgi?id=2327746
Fedora Review Service fedora-review-bot@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |AutomationTriaged URL| |https://crates.io/crates/de | |rive-where
--- Comment #2 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/8295432 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2327746
Aleksei Bavshin alebastr89@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |2329735
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2329735 [Bug 2329735] rust-just: derivative is unmaintained
https://bugzilla.redhat.com/show_bug.cgi?id=2327746
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |decathorpe@gmail.com Assignee|nobody@fedoraproject.org |decathorpe@gmail.com Status|NEW |POST Flags| |fedora-review+
--- Comment #3 from Fabio Valentini decathorpe@gmail.com --- Can you please submit the fix for the executable files to upstream? The package itself looks good to me, though.
===
Package was generated with rust2rpm, simplifying the review.
✅ package contains only permissible content ✅ package builds and installs without errors on rawhide ✅ test suite is run and all unit tests pass ✅ latest version of the crate is packaged ✅ license matches upstream specification and is acceptable for Fedora ✅ license files are included with %license in %files ✅ package complies with Rust Packaging Guidelines
Package APPROVED.
===
Recommended post-import rust-sig tasks:
- set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version (*NOT* pre-release) filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate
- add @rust-sig with "commit" access as package co-maintainer (should happen automatically)
- set bugzilla assignee overrides to @rust-sig (optional)
- track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer)
https://bugzilla.redhat.com/show_bug.cgi?id=2327746
--- Comment #4 from Aleksei Bavshin alebastr89@gmail.com --- (In reply to Fabio Valentini from comment #3)
Can you please submit the fix for the executable files to upstream? The package itself looks good to me, though.
Thanks a lot for the review! Submitted https://github.com/ModProg/derive-where/pull/102
https://bugzilla.redhat.com/show_bug.cgi?id=2327746
Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |RELEASE_PENDING
--- Comment #5 from Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org --- The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-derive-where
https://bugzilla.redhat.com/show_bug.cgi?id=2327746
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RELEASE_PENDING |MODIFIED
--- Comment #6 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-46cbbcd9f4 (rust-derive-where-1.2.7-1.fc42) has been submitted as an update to Fedora 42. https://bodhi.fedoraproject.org/updates/FEDORA-2024-46cbbcd9f4
https://bugzilla.redhat.com/show_bug.cgi?id=2327746
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |CLOSED Resolution|--- |ERRATA Last Closed| |2024-12-01 21:57:21
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-46cbbcd9f4 (rust-derive-where-1.2.7-1.fc42) has been pushed to the Fedora 42 stable repository. If problem still persists, please make note of it in this bug report.
package-review@lists.fedoraproject.org