[Bug 2265716] New: Review Request: golang-github-edoardottt-lit-bb-hack-tools - Little Bug Bounty & Hacking Tools⚔️

https://bugzilla.redhat.com/show_bug.cgi?id=2265716

Bug ID: 2265716
           Summary: Review Request:
                    golang-github-edoardottt-lit-bb-hack-tools - Little
                    Bug Bounty & Hacking Tools⚔️
           Product: Fedora
           Version: rawhide
          Hardware: All
                OS: Linux
            Status: NEW
         Component: Package Review
          Severity: medium
          Priority: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]
  Target Milestone: ---
    Classification: Fedora

Spec URL:
https://download.copr.fedorainfracloud.org/results/semeijn/lab/fedora-rawhid...
SRPM URL:
https://download.copr.fedorainfracloud.org/results/semeijn/lab/fedora-rawhid...
Description: Command Line tools useful during Bug Bounty / Penetration testing.
Focused on Web targets.
Fedora Account System Username: semeijn

[Bug 2265716] Review Request: golang-github-edoardottt-lit-bb-hack-tools - Little Bug Bounty & Hacking Tools⚔️

https://bugzilla.redhat.com/show_bug.cgi?id=2265716

Tim Semeijn  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends On|                            |2265679

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=2265679
[Bug 2265679] Review Request: golang-github-edoardottt-golazy - Golang module
exporting general purpose functions

[Bug 2265716] Review Request: golang-github-edoardottt-lit-bb-hack-tools - Little Bug Bounty & Hacking Tools⚔️

https://bugzilla.redhat.com/show_bug.cgi?id=2265716

--- Comment #1 from Fedora Review Service  ---
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7053551
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

[Bug 2265716] Review Request: golang-github-edoardottt-lit-bb-hack-tools - Little Bug Bounty & Hacking Tools⚔️

https://bugzilla.redhat.com/show_bug.cgi?id=2265716

Mikel Olasagasti Uranga  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
           Doc Type|---                         |If docs needed, set a value

--- Comment #2 from Mikel Olasagasti Uranga  ---
> common_description
> Summary

Remove the emoji
> %global godocs          README.md bbscope/README.md bbtargets/README.md\\
>                         chainredir/README.md checkbypass/README.md\\
>                         cleanpath/README.md doomxss/README.md eae/README.md\\
>                         eah/README.md eap/README.md eaparam/README.md\\
>                         eapath/README.md earh/README.md eefjsf/README.md\\
>                         genscope/README.md gitdump/README.md\\
>                         heacoll/README.md knoxssme/README.md\\
>                         kubemetrics/README.md nrp/README.md rapwp/README.md\\
>                         removehost/README.md removepro/README.md\\
>                         robotstxt/README.md rpfu/README.md subtake/README.md\\
>                         tahm/README.md
> (...)
> %doc README.md bbscope/README.md bbtargets/README.md chainredir/README.md
> %doc checkbypass/README.md cleanpath/README.md doomxss/README.md eae/README.md
> %doc eah/README.md eap/README.md eaparam/README.md eapath/README.md
> %doc earh/README.md eefjsf/README.md genscope/README.md gitdump/README.md
> %doc heacoll/README.md knoxssme/README.md kubemetrics/README.md nrp/README.md
> %doc rapwp/README.md removehost/README.md removepro/README.md
> %doc robotstxt/README.md rpfu/README.md subtake/README.md tahm/README.md

You need to rename the README files during the %prep phase. This is an example
in another package:

https://src.fedoraproject.org/rpms/golang-github-jcmturner-gokrb5/blob/rawhi...
> %gopkginstall
> %gopkgfiles

This creates the golang-github-edoardottt-lit-bb-hack-tools-devel header
package that I don't think is required by any other package, so it shouldn't be
created.

[Bug 2265716] Review Request: golang-github-edoardottt-lit-bb-hack-tools - Little Bug Bounty & Hacking Tools⚔️

https://bugzilla.redhat.com/show_bug.cgi?id=2265716
Bug 2265716 depends on bug 2265679, which changed state.

Bug 2265679 Summary: Review Request: golang-github-edoardottt-golazy - Golang module exporting general purpose functions
https://bugzilla.redhat.com/show_bug.cgi?id=2265679

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|MODIFIED                    |CLOSED
         Resolution|---                         |ERRATA

[Bug 2265716] Review Request: golang-github-edoardottt-lit-bb-hack-tools - Little Bug Bounty & Hacking Tools⚔️

https://bugzilla.redhat.com/show_bug.cgi?id=2265716

--- Comment #3 from Tim Semeijn  ---
Spec URL:
https://semeijn.fedorapeople.org/review/golang-github-edoardottt-lit-bb-hack...
SRPM URL:
https://semeijn.fedorapeople.org/review/golang-github-edoardottt-lit-bb-hack...

[Bug 2265716] Review Request: golang-github-edoardottt-lit-bb-hack-tools - Little Bug Bounty & Hacking Tools

https://bugzilla.redhat.com/show_bug.cgi?id=2265716

--- Comment #4 from Fedora Review Service  ---
Created attachment 2020358
  --> https://bugzilla.redhat.com/attachment.cgi?id=2020358&action=edit
The .spec file difference from Copr build 7053551 to 7112353

[Bug 2265716] Review Request: golang-github-edoardottt-lit-bb-hack-tools - Little Bug Bounty & Hacking Tools

https://bugzilla.redhat.com/show_bug.cgi?id=2265716

--- Comment #5 from Fedora Review Service  ---
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7112353
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

[Bug 2265716] Review Request: golang-github-edoardottt-lit-bb-hack-tools - Little Bug Bounty & Hacking Tools

https://bugzilla.redhat.com/show_bug.cgi?id=2265716

Mikel Olasagasti Uranga  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |fedora-review+
           Assignee|[e-mail]    |[e-mail]
             Status|NEW                         |ASSIGNED

--- Comment #6 from Mikel Olasagasti Uranga  ---
I am not going to go through the whole fedora-review template, as this package
uses go2rpm.

- [x] The specfile is sane.
- [x] License is correct
- [x] Builds successfully in mock
- [x] Package is installable (checked by fedora-review)
- [x] No relevant rpmlint errors
- [x] %check section passes
- [x] The latest version is packaged
- [x] `%goipath` is set correctly
- [x] Binaries don't conflict with binaries already in the distribution.
Checked with `dnf whatprovides /usr/bin/$cmd`
- [x] The package complies with the Packaging Guidelines.

Package approved! On import, don't forget to do the following:

- [ ] Add package to release-monitoring.org
- [ ] Give go-sig privileges on package
- [ ] Close the review bug by referencing it in the rpm changelog and the Bodhi
ticket.

[Bug 2265716] Review Request: golang-github-edoardottt-lit-bb-hack-tools - Little Bug Bounty & Hacking Tools

https://bugzilla.redhat.com/show_bug.cgi?id=2265716

--- Comment #7 from Tim Semeijn  ---
Thanks for the review Mikel!

[Bug 2265716] Review Request: golang-github-edoardottt-lit-bb-hack-tools - Little Bug Bounty & Hacking Tools

https://bugzilla.redhat.com/show_bug.cgi?id=2265716

Fedora Admin user for bugzilla script actions  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |POST

--- Comment #8 from Fedora Admin user for bugzilla script actions  ---
The Pagure repository was created at
https://src.fedoraproject.org/rpms/golang-github-edoardottt-lit-bb-hack-tool...

[Bug 2265716] Review Request: golang-github-edoardottt-lit-bb-hack-tools - Little Bug Bounty & Hacking Tools

https://bugzilla.redhat.com/show_bug.cgi?id=2265716

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|POST                        |MODIFIED

--- Comment #9 from Fedora Update System  ---
FEDORA-2024-6fb8e0fce6
(golang-github-edoardottt-lit-bb-hack-tools-1.3.5-1.fc41) has been submitted as
an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-6fb8e0fce6

[Bug 2265716] Review Request: golang-github-edoardottt-lit-bb-hack-tools - Little Bug Bounty & Hacking Tools

https://bugzilla.redhat.com/show_bug.cgi?id=2265716

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|MODIFIED                    |CLOSED
         Resolution|---                         |ERRATA
        Last Closed|                            |2024-03-08 00:17:27

--- Comment #10 from Fedora Update System  ---
FEDORA-2024-6fb8e0fce6
(golang-github-edoardottt-lit-bb-hack-tools-1.3.5-1.fc41) has been pushed to
the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.