[Bug 1941896] New: Review Request: rust-rudo - rudo is a small equivalent of sudo writen in rust
https://bugzilla.redhat.com/show_bug.cgi?id=1941896
Bug ID: 1941896 Summary: Review Request: rust-rudo - rudo is a small equivalent of sudo writen in rust Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Assignee: nobody@fedoraproject.org Reporter: remilauzier@protonmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://github.com/remilauzier/rudo/blob/main/rust-rudo.spec SRPM URL: https://github.com/remilauzier/rudo/releases/download/0.4.0/rust-rudo-0.4.0-... Description: Rudo use pam to give privilege access to a authorized user and send log to journald to keep trace of it Fedora Account System Username:
https://bugzilla.redhat.com/show_bug.cgi?id=1941896
--- Comment #1 from Rémi Lauzier remilauzier@protonmail.com --- If you need any modification of the .spec or something else you can contact me.
https://bugzilla.redhat.com/show_bug.cgi?id=1941896
Rémi Lauzier remilauzier@protonmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |177841 (FE-NEEDSPONSOR)
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor
https://bugzilla.redhat.com/show_bug.cgi?id=1941896
Robert-André Mauchin 🐧 zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |zebob.m@gmail.com Doc Type|--- |If docs needed, set a value
--- Comment #2 from Robert-André Mauchin 🐧 zebob.m@gmail.com --- - The LICENSE file must be installed with %license in %files
%files -n %{crate} %doc README.md %license LICENSE %{_bindir}/rudo %endif
[…]
%files devel %doc README.md %license LICENSE %{cargo_registry}/%{crate}-%{version_no_tilde}/
- The configuration files are not installed? You need to BuildRequires: pam-devel and install the pam file conf/rudo to %{buildroot}%{_sysconfdir}/pam.d/rudo
%config(noreplace) %{_sysconfdir}/pam.d/rudo
A default configuration file should probably be installed with wheel permission enabled. If this is auto generated at startup, I'd still recommend to add %ghost directive so the file is taken care of when uninstalling.
%ghost %{_sysconfdir}/rudo.conf
- You should set suid in %files:
%attr(4755,root,root) %{_bindir}/rudo
- The documentation for the config file is not very clear. Consider writing a man page.
https://bugzilla.redhat.com/show_bug.cgi?id=1941896
--- Comment #3 from Rémi Lauzier remilauzier@protonmail.com --- Thanks for the help! I am not sure i have fully understand where i should have put the lines after the BuildRequires: pam. I hope i put them in the right place.
I have made a default configuration for rudo but will have to change it soon to have multiple option per user. I will try to make a man page after that and put comment in the file if yaml permit it.
For now i have try to make a copr repository but failed. https://copr.fedorainfracloud.org/coprs/remilauzier/rudo
Pam-sys has update but i have to wait for pam-client to follow since it doesn't compile for now.
Thanks again for your time!
https://bugzilla.redhat.com/show_bug.cgi?id=1941896
--- Comment #4 from Robert-André Mauchin 🐧 zebob.m@gmail.com --- - You can do:
%generate_buildrequires %cargo_generate_buildrequires echo "pam-devel"
- You need to open review requests for you dependencies too. Also you may need to patch some Cargo.toml to build the packages. For example, in your pam-sys build you have: No matching package to install: 'crate(bindgen/default) = 0.53.2' But Fedora is at rust-bindgen 0.56.0. So you need to use 'rust2rpm -p' to patch the Cargo.toml.
https://bugzilla.redhat.com/show_bug.cgi?id=1941896
--- Comment #5 from Rémi Lauzier remilauzier@protonmail.com --- Thanks!
Pam-sys has been update today but for now i must wait for pam-client to adapt to it. I will update pam-sys in my copr and open a review for it and the others dependency.
https://bugzilla.redhat.com/show_bug.cgi?id=1941896
Rémi Lauzier remilauzier@protonmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1943989
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1943989 [Bug 1943989] Review Request: rust-pam-sys - a library to access pam with rust code
https://bugzilla.redhat.com/show_bug.cgi?id=1941896
Rémi Lauzier remilauzier@protonmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1901106
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1901106 [Bug 1901106] Review Request: rust-pam-sys - FFI rust crate
https://bugzilla.redhat.com/show_bug.cgi?id=1941896 Bug 1941896 depends on bug 1943989, which changed state.
Bug 1943989 Summary: Review Request: rust-pam-sys - a library to access pam with rust code https://bugzilla.redhat.com/show_bug.cgi?id=1943989
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution|--- |DUPLICATE
https://bugzilla.redhat.com/show_bug.cgi?id=1941896
Rémi Lauzier remilauzier@protonmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1944392
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1944392 [Bug 1944392] Review Request: rust-build-env - Extract information about the build process from the environment
https://bugzilla.redhat.com/show_bug.cgi?id=1941896
Rémi Lauzier remilauzier@protonmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1944398
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1944398 [Bug 1944398] Review Request: rust-cstr-argument - A trait for converting function arguments to null terminated strings
https://bugzilla.redhat.com/show_bug.cgi?id=1941896
Rémi Lauzier remilauzier@protonmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1944403
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1944403 [Bug 1944403] Review Request: rust-enum-repr - Derive enum repr conversions compatible with type aliases.
https://bugzilla.redhat.com/show_bug.cgi?id=1941896
Rémi Lauzier remilauzier@protonmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1944408
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1944408 [Bug 1944408] Review Request: rust-libsystemd-sys - FFI bindings to libsystemd and libelogind
https://bugzilla.redhat.com/show_bug.cgi?id=1941896
Rémi Lauzier remilauzier@protonmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1944412
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1944412 [Bug 1944412] Review Request: rust-utf8-cstr - Type wrappers promising null termination and utf-8 validity. The intersection of `std::ffi::CStr` and `str`
https://bugzilla.redhat.com/show_bug.cgi?id=1941896
Rémi Lauzier remilauzier@protonmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1944422
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1944422 [Bug 1944422] Review Request: rust-systemd - A rust interface to libsystemd/libelogind provided APIs
https://bugzilla.redhat.com/show_bug.cgi?id=1941896
Rémi Lauzier remilauzier@protonmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1944463
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1944463 [Bug 1944463] Review Request: rust-pam-client - Application API wrapper to Pluggable Authentication Modules (PAM)
https://bugzilla.redhat.com/show_bug.cgi?id=1941896
--- Comment #6 from Rémi Lauzier remilauzier@protonmail.com --- Hi! I manage to put review for all dependency of rudo and to compile them in my copr. https://copr.fedorainfracloud.org/coprs/remilauzier/rudo/
For now i manage to compile rudo but the config file appear to install as directory even if it is a file in the final rpm. Thanks for your time.
https://bugzilla.redhat.com/show_bug.cgi?id=1941896
--- Comment #7 from Rémi Lauzier remilauzier@protonmail.com --- Hi! i manage to get the config file to install as file. i just have a problem with the man page. i must convert markdown to man page but i don't know how to do it. Thanks for your time!
https://bugzilla.redhat.com/show_bug.cgi?id=1941896
--- Comment #8 from Robert-André Mauchin 🐧 zebob.m@gmail.com --- Sent you a PR. Use go-md2man as indicated in the commit log.
https://bugzilla.redhat.com/show_bug.cgi?id=1941896
--- Comment #9 from Rémi Lauzier remilauzier@protonmail.com --- Thanks for the help! i got the package to compile and the man page to install. Can confirm that everything work on my end.
https://bugzilla.redhat.com/show_bug.cgi?id=1941896
Robert-André Mauchin 🐧 zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@fedoraproject.org |zebob.m@gmail.com Flags| |fedora-review?
--- Comment #10 from Robert-André Mauchin 🐧 zebob.m@gmail.com --- - /etc → %{_sysconfdir}
- Use install -p to keep timestamps
- Why are you doing this:
cp conf/rudo ~/ cp conf/rudo.conf ~/ cp man/rudo.1 ~/ cp man/rudo.conf.5 ~/
instead of just installing them from their current location?
mkdir -p %{buildroot}%{_sysconfdir} mkdir -p %{buildroot}%{_sysconfdir}/pam.d/ mkdir -p %{buildroot}%{_mandir}/man1 mkdir -p %{buildroot}%{_mandir}/man5 install -pm 0640 cp conf/rudo.conf %{buildroot}%{_sysconfdir}/rudo.conf install -pm 0644 conf/rudo %{buildroot}%{_sysconfdir}/pam.d/rudo install -pm 0644 man/rudo.1 %{buildroot}%{_mandir}/man1/rudo.1 install -pm 0644 man/rudo.conf.5 %{buildroot}%{_mandir}/man5/rudo.conf.5
- This is not needed anymore:
echo "pam-devel" echo "systemd-devel"
pam-devel is implied by the rust-pam-sys dep and systemd-devel by the rust-libsystemd-sys dep
- License ok - Latest version packaged - Builds in mock - No rpmlint errors - Conforms to Packaging Guidelines
https://bugzilla.redhat.com/show_bug.cgi?id=1941896
--- Comment #11 from Rémi Lauzier remilauzier@protonmail.com --- Done! Not sure if i should put some requires to systemd-libs for journald support? https://download.copr.fedorainfracloud.org/results/remilauzier/rudo/fedora-3...
https://bugzilla.redhat.com/show_bug.cgi?id=1941896
Robert-André Mauchin 🐧 zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #12 from Robert-André Mauchin 🐧 zebob.m@gmail.com --- I don't think this is necessary.
Package approved. You still need to find a sponsor.
https://bugzilla.redhat.com/show_bug.cgi?id=1941896
Robert-André Mauchin 🐧 zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Blocks|177841 (FE-NEEDSPONSOR) |
--- Comment #13 from Robert-André Mauchin 🐧 zebob.m@gmail.com --- Sponsored.
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor
https://bugzilla.redhat.com/show_bug.cgi?id=1941896
--- Comment #14 from Tomas Hrcka thrcka@redhat.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-rudo
https://bugzilla.redhat.com/show_bug.cgi?id=1941896 Bug 1941896 depends on bug 1944392, which changed state.
Bug 1944392 Summary: Review Request: rust-build-env - Extract information about the build process from the environment https://bugzilla.redhat.com/show_bug.cgi?id=1944392
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=1941896 Bug 1941896 depends on bug 1944398, which changed state.
Bug 1944398 Summary: Review Request: rust-cstr-argument - A trait for converting function arguments to null terminated strings https://bugzilla.redhat.com/show_bug.cgi?id=1944398
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=1941896 Bug 1941896 depends on bug 1944412, which changed state.
Bug 1944412 Summary: Review Request: rust-utf8-cstr - Type wrappers promising null termination and utf-8 validity. The intersection of `std::ffi::CStr` and `str` https://bugzilla.redhat.com/show_bug.cgi?id=1944412
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=1941896 Bug 1941896 depends on bug 1944403, which changed state.
Bug 1944403 Summary: Review Request: rust-enum-repr - Derive enum repr conversions compatible with type aliases. https://bugzilla.redhat.com/show_bug.cgi?id=1944403
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=1941896 Bug 1941896 depends on bug 1944408, which changed state.
Bug 1944408 Summary: Review Request: rust-libsystemd-sys - FFI bindings to libsystemd and libelogind https://bugzilla.redhat.com/show_bug.cgi?id=1944408
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=1941896 Bug 1941896 depends on bug 1944422, which changed state.
Bug 1944422 Summary: Review Request: rust-systemd - A rust interface to libsystemd/libelogind provided APIs https://bugzilla.redhat.com/show_bug.cgi?id=1944422
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=1941896 Bug 1941896 depends on bug 1944463, which changed state.
Bug 1944463 Summary: Review Request: rust-pam-client - Application API wrapper to Pluggable Authentication Modules (PAM) https://bugzilla.redhat.com/show_bug.cgi?id=1944463
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |CLOSED Resolution|--- |RAWHIDE
https://bugzilla.redhat.com/show_bug.cgi?id=1941896
Rémi Lauzier remilauzier@protonmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |CLOSED Resolution|--- |RAWHIDE Last Closed| |2021-07-11 05:07:25
https://bugzilla.redhat.com/show_bug.cgi?id=1941896 Bug 1941896 depends on bug 1901106, which changed state.
Bug 1901106 Summary: Review Request: rust-pam-sys - FFI rust crate https://bugzilla.redhat.com/show_bug.cgi?id=1901106
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |CLOSED Resolution|--- |CURRENTRELEASE
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com