[Bug 753855] New: Review Request: pslib - C-library to create PostScript files - package-review

List overview All Threads
Download

newer

[Bug 753855] New: Review Request: pslib - C-library to create PostScript files

older

[Bug 648549] New: Review Request:...

[Bug 689488] New: Review Request:...

Red Hat Bugzilla

14 Nov 2011 14 Nov '11

5:14 p.m.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

Summary: Review Request: pslib - C-library to create PostScript files

https://bugzilla.redhat.com/show_bug.cgi?id=753855

Summary: Review Request: pslib - C-library to create PostScript files Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: orion@cora.nwra.com QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: ---

Spec URL: http://www.cora.nwra.com/~orion/fedora/pslib.spec SRPM URL: http://www.cora.nwra.com/~orion/fedora/pslib-0.4.5-1.fc16.src.rpm Description: pslib is a C-library to create PostScript files on the fly. It offers many drawing primitives, inclusion of png and eps images and a very sophisticated text rendering including hyphenation, kerning and ligatures. It can read external Type1 fonts and embed them into the output file. It supports pdfmarks which makes it in combination with ghostscript's pdfwriter an alternative for libraries creating PDF.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Show replies by date

Red Hat Bugzilla

16 Nov 16 Nov

6:29 a.m.

New subject: [Bug 753855] Review Request: pslib - C-library to create PostScript files

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=753855

Parag AN(पराग) panemade@gmail.com changed:

--- Comment #1 from Parag AN(पराग) panemade@gmail.com 2011-11-16 01:29:05 EST --- Review:-

+ koji build -> http://koji.fedoraproject.org/koji/taskinfo?taskID=3518017 + rpmlint on package gave pslib.src: W: spelling-error %description -l en_US png -> pg, ping, pang pslib.src: W: spelling-error %description -l en_US eps -> esp, rps, es pslib.src: W: spelling-error %description -l en_US kerning -> keening, kenning, Kettering pslib.src: W: spelling-error %description -l en_US pdfmarks -> pockmarks pslib.src: W: spelling-error %description -l en_US ghostscript's -> ghost script's, ghost-script's, postscript's pslib.src: W: spelling-error %description -l en_US pdfwriter -> typewriter pslib.x86_64: W: spelling-error %description -l en_US png -> pg, ping, pang pslib.x86_64: W: spelling-error %description -l en_US eps -> esp, rps, es pslib.x86_64: W: spelling-error %description -l en_US kerning -> keening, kenning, Kettering pslib.x86_64: W: spelling-error %description -l en_US pdfmarks -> pockmarks pslib.x86_64: W: spelling-error %description -l en_US ghostscript's -> ghost script's, ghost-script's, postscript's pslib.x86_64: W: spelling-error %description -l en_US pdfwriter -> typewriter pslib.x86_64: W: shared-lib-calls-exit /usr/lib64/libps.so.0.4.5 exit@GLIBC_2.2.5 pslib.x86_64: W: spurious-executable-perm /usr/share/doc/pslib-0.4.5/ChangeLog pslib.x86_64: E: incorrect-fsf-address /usr/share/doc/pslib-0.4.5/COPYING pslib.x86_64: W: file-not-utf8 /usr/share/doc/pslib-0.4.5/AUTHORS pslib.x86_64: E: zero-length /usr/share/doc/pslib-0.4.5/NEWS pslib-devel.x86_64: W: no-documentation 3 packages and 0 specfiles checked; 2 errors, 16 warnings.

+ source match with upstream source as (sha1sum) 2ad904b650b7d55b7c12be0c99f77073770ece56 pslib-0.4.5.tar.gz 2ad904b650b7d55b7c12be0c99f77073770ece56 ../SOURCES/pslib-0.4.5.tar.gz

+ Package :pslib-0.4.5-1.fc17.x86_64 Provides: libps.so.0()(64bit) Requires: libc.so.6()(64bit) libc.so.6(GLIBC_2.11)(64bit) libc.so.6(GLIBC_2.14)(64bit) libc.so.6(GLIBC_2.2.5)(64bit) libc.so.6(GLIBC_2.3)(64bit) libc.so.6(GLIBC_2.3.4)(64bit) libc.so.6(GLIBC_2.4)(64bit) libc.so.6(GLIBC_2.7)(64bit) libjpeg.so.62()(64bit) libjpeg.so.62(LIBJPEG_6.2)(64bit) libpng15.so.15()(64bit) libpng15.so.15(PNG15_0)(64bit) libtiff.so.3()(64bit) rtld(GNU_HASH)

Package : pslib-devel-0.4.5-1.fc17.x86_64 Provides: pkgconfig(libps) = 0.4.5 Requires: /usr/bin/pkg-config libps.so.0()(64bit)

+ libps.pc file is present.

Suggestions: 1) remove the zero-length file NEWS 2) for the incorrect-fsf-address, you can contact upstream and ask them to correct in COPYING file 3) AUTHORS is not a utf8 file, you can make it utf8 as given at http://fedoraproject.org/wiki/Packaging_tricks#Convert_encoding_to_UTF-8 4) To remove executable permissions on ChangeLog use http://fedoraproject.org/wiki/Packaging_tricks#Exec_permission 5) you don't need to clean buildroot in %install 6) I think license is LGPLv2+ and MPL and MIT

See http://fedoraproject.org/wiki/Packaging:LicensingGuidelines#Multiple_Licensi...

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

4:38 p.m.

New subject: [Bug 753855] Review Request: pslib - C-library to create PostScript files

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=753855

--- Comment #2 from Orion Poplawski orion@cora.nwra.com 2011-11-16 11:38:03 EST --- Looks like it should be LGPLv2+ and MPLv1.0 and MIT (although I think the only MIT source is bmp.* which isn't currently being built). Now, MPLv1.0 is listed and GPL incompatible, does that also apply to the LGPL?

I'll report the issue with COPYING.

* Wed Nov 16 2011 Orion Poplawski orion@cora.nwra.com - 0.4.5-2 - Fix encoding - Fix permissions - Fix license tag

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

17 Nov 17 Nov

9:18 a.m.

New subject: [Bug 753855] Review Request: pslib - C-library to create PostScript files

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=753855

--- Comment #3 from Parag AN(पराग) panemade@gmail.com 2011-11-17 04:18:41 EST --- I can see libps library is also getting built using bmp.c file. also post the newer modified package links.

Regarding license you can ask to legal list for clarification.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

18 Nov 18 Nov

9:40 p.m.

New subject: [Bug 753855] Review Request: pslib - C-library to create PostScript files

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=753855

--- Comment #4 from Orion Poplawski orion@cora.nwra.com 2011-11-18 16:40:08 EST --- Ah, you are correct about bmp.c. I've sent a message to legal.

Spec URL: http://www.cora.nwra.com/~orion/fedora/pslib.spec SRPM URL: http://www.cora.nwra.com/~orion/fedora/pslib-0.4.5-2.fc16.src.rpm

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

9 Dec 9 Dec

9:40 p.m.

New subject: [Bug 753855] Review Request: pslib - C-library to create PostScript files

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=753855

--- Comment #5 from Orion Poplawski orion@cora.nwra.com 2011-12-09 16:40:11 EST --- Never got a response to my post in legal. I guess I don't have any concerns, but if you do we should block FE-LEGAL I think.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

21 Dec 21 Dec

10:12 a.m.

New subject: [Bug 753855] Review Request: pslib - C-library to create PostScript files

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=753855

Parag AN(पराग) panemade@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Blocks| |182235(FE-Legal)

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

5 Jan 5 Jan

5:36 p.m.

New subject: [Bug 753855] Review Request: pslib - C-library to create PostScript files

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=753855

Tom "spot" Callaway tcallawa@redhat.com changed:

--- Comment #6 from Tom "spot" Callaway tcallawa@redhat.com 2012-01-05 12:36:12 EST --- No real concern here. Lifting FE-Legal.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

6 Jan 6 Jan

2:51 a.m.

New subject: [Bug 753855] Review Request: pslib - C-library to create PostScript files

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=753855

Parag AN(पराग) panemade@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+

--- Comment #7 from Parag AN(पराग) panemade@gmail.com 2012-01-05 21:51:56 EST --- Package APPROVED.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

3:03 a.m.

New subject: [Bug 753855] Review Request: pslib - C-library to create PostScript files

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=753855

Orion Poplawski orion@cora.nwra.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?

--- Comment #8 from Orion Poplawski orion@cora.nwra.com 2012-01-05 22:03:19 EST --- New Package SCM Request ======================= Package Name: pslib Short Description: C-library to create PostScript files Owners: orion Branches: f16 f15 el6 el5 InitialCC:

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

3:06 a.m.

New subject: [Bug 753855] Review Request: pslib - C-library to create PostScript files

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=753855

--- Comment #9 from Jon Ciesla limburgher@gmail.com 2012-01-05 22:06:10 EST --- Git done (by process-git-requests).

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

3:40 a.m.

New subject: [Bug 753855] Review Request: pslib - C-library to create PostScript files

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=753855

Orion Poplawski orion@cora.nwra.com changed:

--- Comment #10 from Orion Poplawski orion@cora.nwra.com 2012-01-05 22:40:20 EST --- Checked in and built. Thanks everyone.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

4559

Age (days ago)

4612

Last active (days ago)

package-review@lists.fedoraproject.org

11 comments

1 participants

tags (0)

participants (1)

Red Hat Bugzilla