https://bugzilla.redhat.com/show_bug.cgi?id=2217970
Bug ID: 2217970 Summary: Review Request: mikktspace - A common standard for tangent space used in baking tools to produce normal maps Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Assignee: nobody@fedoraproject.org Reporter: nfrizzel@redhat.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://download.copr.fedorainfracloud.org/results/nfrizzel/MikkTSpace/fedor... SRPM URL: https://download.copr.fedorainfracloud.org/results/nfrizzel/MikkTSpace/fedor... Description: A common standard for tangent space used in baking tools to produce normal maps. Fedora Account System Username: nfrizzel
This is my first package submission, so there may be some things in it that need adjusting, and I believe this also means I need a sponsor. I've started with a relatively straightfoward (from the standpoint of packaging) project. The upstream is https://github.com/mmikk/MikkTSpace
https://bugzilla.redhat.com/show_bug.cgi?id=2217970
Fedora Review Service fedora-review-bot@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- URL| |http://www.mikktspace.com/
--- Comment #1 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/6119196 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2217970
--- Comment #3 from nfrizzel@redhat.com --- I've taken another look at this and hopefully fixed the problems relating to proper versioning I was concerned about. One other area that may need a look at for review is the build flags to make sure they are being specified properly. The updated links are:
Spec URL: https://download.copr.fedorainfracloud.org/results/nfrizzel/mikktspace/fedor...
SRPM URL: https://download.copr.fedorainfracloud.org/results/nfrizzel/mikktspace/fedor...
https://bugzilla.redhat.com/show_bug.cgi?id=2217970
nfrizzel@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Whiteboard|NotReady |
https://bugzilla.redhat.com/show_bug.cgi?id=2217970
--- Comment #4 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Created attachment 1975638 --> https://bugzilla.redhat.com/attachment.cgi?id=1975638&action=edit The .spec file difference from Copr build 6119196 to 6170301
https://bugzilla.redhat.com/show_bug.cgi?id=2217970
--- Comment #5 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/6170301 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
package-review@lists.fedoraproject.org