[Bug 747031] New: Review Request: ghc-hs-bibutils - Haskell bindings to bibutils, the bibliography conversion utilities
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: ghc-hs-bibutils - Haskell bindings to bibutils, the bibliography conversion utilities
https://bugzilla.redhat.com/show_bug.cgi?id=747031
Summary: Review Request: ghc-hs-bibutils - Haskell bindings to bibutils, the bibliography conversion utilities Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: unspecified Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: tpr@d5k.net QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: ---
Spec URL: http://stetson.frozenhat.fi/~tpr/fedora/ghc-hs-bibutils.spec SRPM URL: http://stetson.frozenhat.fi/~tpr/fedora/ghc-hs-bibutils-4.12-0.fc15.src.rpm
rpmlint:
ghc-hs-bibutils.src: W: spelling-error %description -l en_US interconverts -> inter converts, inter-converts, interconnects ghc-hs-bibutils.src: W: spelling-error %description -l en_US http -> HTTP ghc-hs-bibutils.src: W: spelling-error %description -l en_US www -> WWW, wow ghc-hs-bibutils.src: W: spelling-error %description -l en_US scripps -> scrips, scripts, scrimps ghc-hs-bibutils.src: W: spelling-error %description -l en_US edu -> ed, educ, due ghc-hs-bibutils.src: W: spelling-error %description -l en_US cdputnam -> Putnam ghc-hs-bibutils.src: W: spelling-error %description -l en_US html -> HTML, ht ml, ht-ml ghc-hs-bibutils.src:74: W: macro-in-comment %define 1 packages and 0 specfiles checked; 0 errors, 8 warnings.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=747031
--- Comment #1 from Jens Petersen petersen@redhat.com 2011-10-19 03:01:16 EDT --- Thanks Teemu, generally your package looks ok. I have a few smaller comments/suggestions:
%global common_summary Haskell bindings to bibutils, the bibliography conversion utilities
I think "Haskell bindings to bibutils" is sufficient and succinct enough for the summary.
%global common_description Haskell bindings to Chris Putnam's bibutils, a\
(I would break the line before "a".:)
For more details about bibutils, please check:\ http://www.scripps.edu/~cdputnam/software/bibutils/.\ The original API documentation is available here:\ http://www.scripps.edu/~cdputnam/software/bibutils/library_specs.html.\
Not sure both the urls are really necessary (people can get to them from the hackage page anyway: personally I would remove the second sentence anyway.
The package release number refers to the release number of \ the included bibutils library.
I think better to remove this.
Anyway you are pretty free to edit the description to your liking.
Release: 0%{?dist}
You need to bump this.
License: GPLv2
I see a potential problem here: Bibutils.hsc proclaims itself to be BSD license. Is it because bibutils is GPL that hs-bibutils is saying it is GPL too, or something else?
If you are not sure I suggest contacting the maintainer to clarify the license.
# BEGIN cabal2spec
:
BuildRequires: ghc-Cabal-devel BuildRequires: ghc-rpm-macros BuildRequires: ghc-syb-devel BuildRequires: ghc-base-prof
Actually @DEPENDENCIES@ below is a placeholder for these. So better to place them outside the "cabal2spec" commented block.
:
# END cabal2spec
:
#BuildRequires: @DEPENDENCIES@
Here! ^ :)
#%define cabal_configure_options -f "opt1 -opt2 ..."
You can remove this to get rid of the warning you mentioned:
ghc-hs-bibutils.src:74: W: macro-in-comment %define
%changelog
- Thu Oct 13 2011 Fedora Haskell SIG haskell-devel@lists.fedoraproject.org - 4.12-0
- initial packaging for Fedora automatically generated by cabal2spec-0.24.1
You need to add a comment to document the changes you make each time you update the spec file.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=747031
Jens Petersen petersen@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status Whiteboard| |NotReady
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=747031
--- Comment #2 from Teemu Rytilahti tpr@d5k.net 2011-11-29 15:33:49 EST --- First of all, sorry for so late response. I just fixed these issues (hopefully), and as I mentioned in IRC the licensing issue should also be resolved. Citing from a mail from the author:
originally hs-bibutils was shipped separately from bibutils and so, while the second was and still is GPL, my bindings were BSD.
Now hs-bibutils comes with an included copy of the bibutils library, and so I had to change the hs-bibutils' license to GPL in order to comply with bibutils' requirements.
In other terms, starting from version 4.12 hs-bibutils is covered by the GNU GPL too.
According to bibutils license file it is licensed (specifically) under GPLv2.
Spec URL: http://stetson.frozenhat.fi/~tpr/fedora/ghc-hs-bibutils.spec SRPM URL: http://stetson.frozenhat.fi/~tpr/fedora/ghc-hs-bibutils-4.12-1.fc15.src.rpm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=747031
Jens Petersen petersen@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@fedoraproject.org |petersen@redhat.com Status Whiteboard|NotReady |Ready Flag| |fedora-review?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=747031
Jens Petersen petersen@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=747031
--- Comment #3 from Jens Petersen petersen@redhat.com 2012-02-07 05:06:54 EST --- Very sorry to sit on this into the New Year... :-(
Apologies to ask now but would you be able to update the packaging to current cabal2spec-0.25? It is somewhat simpler and cleaner than 0.24.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=747031
Jens Petersen petersen@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status Whiteboard|Ready |
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=747031
Jens Petersen petersen@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status Whiteboard| |NotReady
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=747031
--- Comment #4 from Jens Petersen petersen@redhat.com 2012-04-08 23:33:23 EDT --- Do you still want to submit this package?
Perhaps it is quicker if I submit? :)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=747031
JudeNagurney jude@pwan.org changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |jude@pwan.org
--- Comment #5 from JudeNagurney jude@pwan.org 2012-04-18 01:30:26 EDT --- I'm commenting on this ticket as per https://bugzilla.redhat.com/show_bug.cgi?id=656892#c11
You may want to use the %gh_files macro to make sure the LICENSE and README file are published at the expected location. I don't know if this macro is available in cabal2spec 0.24, so I would also reiterate comment #3 request to update the packaging to use cabal2spec 0.25.4. An example of using %ghc_files is at http://code.haskell.org/augeas/packaging/rpm/ghc-augeas.spec
https://bugzilla.redhat.com/show_bug.cgi?id=747031
Jens Petersen petersen@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Whiteboard|NotReady |NotReady - needs bibutils
--- Comment #6 from Jens Petersen petersen@redhat.com --- I noticed now that hs-bibutils embeds a copy of bibutils which is not allowed in Fedora - so I think bibutils would need to be packaged first for Fedora, and then this package should BR: bibutils-devel.
https://bugzilla.redhat.com/show_bug.cgi?id=747031
Jens Petersen petersen@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW Assignee|petersen@redhat.com |nobody@fedoraproject.org Flags|fedora-review? |
https://bugzilla.redhat.com/show_bug.cgi?id=747031
Jens Petersen petersen@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |861782
https://bugzilla.redhat.com/show_bug.cgi?id=747031
Jens Petersen petersen@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Blocks|861782 | Resolution|--- |DUPLICATE Last Closed| |2012-10-01 07:28:49
--- Comment #7 from Jens Petersen petersen@redhat.com ---
*** This bug has been marked as a duplicate of bug 861923 ***
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla