[Bug 205043] New: Review Request: geda-gattrib - Attribute editor for gEDA

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=205043

Summary: Review Request: geda-gattrib - Attribute editor for gEDA
           Product: Fedora Extras
           Version: devel
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: normal
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]

Spec URL: http://chitlesh.funpic.de/rpm/geda-gattrib.spec
SRPM URL: http://chitlesh.funpic.de/rpm/geda-gattrib-20060123-3.src.rpm
Description:
Gattrib is gEDA's attribute editor. It reads a set of gschem .sch files
(schematic files), and creates a spreadsheet showing all components in
rows, with the associated component attributes listed in the columns.
It allows the user to add, modify, or delete component attributes outside
of gschem, and then save the .sch files back out. When it is completed,
it will allow the user to edit attributes attached to components, nets,
and pins. (Currently, only component attribute editing is implemented;
pin attributes are displayed only, and net attributes are TBD.)

[Bug 205043] Review Request: geda-gattrib - Attribute editor for gEDA

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: geda-gattrib - Attribute editor for gEDA

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=205043

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

------- Additional Comments From [e-mail]  2006-09-02 18:06 EST -------
*** Bug 177413 has been marked as a duplicate of this bug. ***

[Bug 205043] Review Request: geda-gattrib - Attribute editor for gEDA

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: geda-gattrib - Attribute editor for gEDA

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=205043

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|[e-mail]    |[e-mail]
OtherBugsDependingO|163776                      |163778
              nThis|                            |

[Bug 205043] Review Request: geda-gattrib - Attribute editor for gEDA

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: geda-gattrib - Attribute editor for gEDA

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=205043

------- Additional Comments From [e-mail]  2006-09-04 03:05 EST -------
First review of geda-gattrib.

1. From http://fedoraproject.org/wiki/Packaging/Guidelines :

* BuildRequires:
     - libpng-devel <- required by gd-devel
                    <- required by libgeda-devel

* Desktop files:
     - No icon is installed in a proper directory.
     fedora-gattrib.desktop says that "gattrib.{png,xpm}" should
     be installed in a proper directory.

2. From http://fedoraproject.org/wiki/Packaging/ReviewGuidelines :

= Nothing.

3. Other things I have noticed :

= Nothing.

[Bug 205043] Review Request: geda-gattrib - Attribute editor for gEDA

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: geda-gattrib - Attribute editor for gEDA

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=205043

------- Additional Comments From [e-mail]  2006-09-04 08:57 EST -------
Updated:
Spec URL: http://chitlesh.funpic.de/rpm/geda-gattrib.spec
SRPM URL: http://chitlesh.funpic.de/rpm/geda-gattrib-20060123-4.src.rpm

[Bug 205043] Review Request: geda-gattrib - Attribute editor for gEDA

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: geda-gattrib - Attribute editor for gEDA

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=205043

------- Additional Comments From [e-mail]  2006-09-04 10:44 EST -------
Well;

I just wondered why no icon are shown on Gattrib menu and
I found the problem.

Source1 has a typo:

icon=gattrib should be Icon=gattrib .

Just fix it. Then I recheck if a proper icon appears on Gattrib menu.

[Bug 205043] Review Request: geda-gattrib - Attribute editor for gEDA

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: geda-gattrib - Attribute editor for gEDA

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=205043

------- Additional Comments From [e-mail]  2006-09-04 17:01 EST -------
Updated:
Spec URL: http://chitlesh.funpic.de/rpm/geda-gattrib.spec
SRPM URL: http://chitlesh.funpic.de/rpm/geda-gattrib-20060824-1.src.rpm

Example:
gattrib /usr/share/gEDA/examples/RF_Amp/RF_Amp/MSA-2643.sch

[Bug 205043] Review Request: geda-gattrib - Attribute editor for gEDA

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: geda-gattrib - Attribute editor for gEDA

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=205043

------- Additional Comments From [e-mail]  2006-09-05 03:31 EST -------
Well...

[tasaka1@dhcp151 geda-gattrib]$ gattrib
/usr/share/gEDA/examples/RF_Amp/RF_Amp/MSA-2643.sch
gEDA/gattrib version 20060824
gEDA/gattrib comes with ABSOLUTELY NO WARRANTY; see COPYING for more details.
This is free software, and you are welcome to redistribute it under certain
conditions; please see the COPYING file for more details.
Loading file [/usr/share/gEDA/examples/RF_Amp]
Couldn't load schematic [/usr/share/gEDA/examples/RF_Amp]
No components found in entire design!
Do you have refdeses on your components?  
Exiting. . . .

What does this mean?

[Bug 205043] Review Request: geda-gattrib - Attribute editor for gEDA

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: geda-gattrib - Attribute editor for gEDA

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=205043

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

------- Additional Comments From [e-mail]  2006-09-05 09:49 EST -------
I am the author of this program.

Well...

[tasaka1@dhcp151 geda-gattrib]$ gattrib
  /usr/share/gEDA/examples/RF_Amp/RF_Amp/MSA-2643.sch
  gEDA/gattrib version 20060824
  gEDA/gattrib comes with ABSOLUTELY NO WARRANTY; see COPYING for more details.
  This is free software, and you are welcome to redistribute it under certain
  conditions; please see the COPYING file for more details.
  Loading file [/usr/share/gEDA/examples/RF_Amp]
  Couldn't load schematic [/usr/share/gEDA/examples/RF_Amp]
  No components found in entire design!
  Do you have refdeses on your components?  
  Exiting. . . .

What does this mean?

This is the correct behavior.  You tried loading a non-existant file.  The 
path "/usr/share/gEDA/examples/RF_Amp/RF_Amp/MSA-2643.sch" probably doesn't 
exist.  You probably want "/usr/share/gEDA/examples/RF_Amp/MSA-2643.sch" 
(remove one RF_Amp from diretory list).

In general, gattrib will try to open your .sch file and look for valid 
components.  If it can't find then, it will bail out with the above error 
message.

I agree that the error message might be improved to say "file not found" in 
this case.  I can add that to the list of improvements I intend to do.

Stuart Brorson

[Bug 205043] Review Request: geda-gattrib - Attribute editor for gEDA

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: geda-gattrib - Attribute editor for gEDA

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=205043

------- Additional Comments From [e-mail]  2006-09-05 10:18 EST -------
(In reply to comment #7)
> This is the correct behavior.  You tried loading a non-existant file.  The 
> path "/usr/share/gEDA/examples/RF_Amp/RF_Amp/MSA-2643.sch" probably doesn't 
> exist.  You probably want "/usr/share/gEDA/examples/RF_Amp/MSA-2643.sch" 
> (remove one RF_Amp from diretory list).
>
> In general, gattrib will try to open your .sch file and look for valid 
> components.  If it can't find then, it will bail out with the above error 
> message.> 
> I agree that the error message might be improved to say "file not found" in 
> this case.  I can add that to the list of improvements I intend to do.
>
> Stuart Brorson

Hello, Stuart.

Oops... Actually /usr/share/gEDA/examples/RF_Amp/RF_Amp/MSA-2643.sch wasn't
exist... my bad......
Well, I installed geda-examples (I have not accepted geda-examples yet)
and it seems to go right.

Okay, then I recheck this package again. Thank you.

[Bug 205043] Review Request: geda-gattrib - Attribute editor for gEDA

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: geda-gattrib - Attribute editor for gEDA

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=205043

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163778                      |163779
              nThis|                            |

------- Additional Comments From [e-mail]  2006-09-05 11:05 EST -------
Okay. No problem.

This package (geda-gattrib) is APPROVED by me.

[Bug 205043] Review Request: geda-gattrib - Attribute editor for gEDA

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: geda-gattrib - Attribute editor for gEDA

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=205043

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |NEXTRELEASE

[Bug 205043] Review Request: geda-gattrib - Attribute editor for gEDA

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: geda-gattrib - Attribute editor for gEDA

https://bugzilla.redhat.com/show_bug.cgi?id=205043

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |medium
           Priority|normal                      |medium
            Product|Fedora Extras               |Fedora
            Version|devel                       |rawhide

[Bug 205043] Review Request: geda-gattrib - Attribute editor for gEDA

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=205043

Chitlesh GOORAH  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?

--- Comment #10 from Chitlesh GOORAH   2008-12-21 14:51:47 EDT ---
New Package CVS Request
=======================
Package Name: geda-gattrib
Short Description: Attribute editor for gEDA
Owners: chitlesh
Branches: EL-5

[Bug 205043] Review Request: geda-gattrib - Attribute editor for gEDA

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=205043

Kevin Fenzi  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-cvs?                 |fedora-cvs+

--- Comment #11 from Kevin Fenzi   2008-12-22 22:26:22 EDT ---
cvs done.

[Bug 205043] Review Request: geda-gattrib - Attribute editor for gEDA

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=205043

Chitlesh GOORAH  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-cvs+                 |fedora-cvs?

--- Comment #12 from Chitlesh GOORAH   2008-12-24 10:33:07 EDT ---
Sorry Kevin you haven't created the EL-5 branch for geda-gattrib.

[Bug 205043] Review Request: geda-gattrib - Attribute editor for gEDA

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=205043

Kevin Fenzi  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-cvs?                 |fedora-cvs+

--- Comment #13 from Kevin Fenzi   2008-12-24 19:44:55 EDT ---
Sorry, it was done in pkgdb, but for some reason didn't setup right on cvs. 
Try now? I think I have it fixed.

[Bug 205043] Review Request: geda-gattrib - Attribute editor for gEDA

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=205043

--- Comment #14 from Chitlesh GOORAH   2008-12-25 06:32:18 EDT ---
thanks it's fine now.